From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#44581: 28.0.50; undo comment-region error Date: Sun, 15 Nov 2020 13:31:59 +0000 Message-ID: <20201115133159.GD3913@ACM> References: <5FB7F45B-CC9B-491B-ABFA-5AAB455D1196@acm.org> <7A64CD95-49C7-4C16-9FF8-5E2221CDCCB1@acm.org> <20201115122018.GC3913@ACM> <035431D2-0D65-4554-B410-EB43693A4B1F@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22430"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44581-done@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 15 14:33:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1keI9V-0005jW-Ej for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 15 Nov 2020 14:33:09 +0100 Original-Received: from localhost ([::1]:51040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keI9U-00030N-2V for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 15 Nov 2020 08:33:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keI9O-000309-5T for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2020 08:33:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41213) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1keI9N-00055Y-SN for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2020 08:33:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1keI9N-0002m8-Oi for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2020 08:33:01 -0500 Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Nov 2020 13:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 44581 X-GNU-PR-Package: emacs Mail-Followup-To: 44581@debbugs.gnu.org, acm@muc.de, mattiase@acm.org Original-Received: via spool by 44581-done@debbugs.gnu.org id=D44581.160544712810604 (code D ref 44581); Sun, 15 Nov 2020 13:33:01 +0000 Original-Received: (at 44581-done) by debbugs.gnu.org; 15 Nov 2020 13:32:08 +0000 Original-Received: from localhost ([127.0.0.1]:52759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keI8W-0002ky-6e for submit@debbugs.gnu.org; Sun, 15 Nov 2020 08:32:08 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:63873 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1keI8U-0002kU-HI for 44581-done@debbugs.gnu.org; Sun, 15 Nov 2020 08:32:07 -0500 Original-Received: (qmail 81559 invoked by uid 3782); 15 Nov 2020 13:31:59 -0000 Original-Received: from acm.muc.de (p4fe15510.dip0.t-ipconnect.de [79.225.85.16]) by localhost.muc.de (tmda-ofmipd) with ESMTP; Sun, 15 Nov 2020 14:31:59 +0100 Original-Received: (qmail 3334 invoked by uid 1000); 15 Nov 2020 13:31:59 -0000 Content-Disposition: inline In-Reply-To: <035431D2-0D65-4554-B410-EB43693A4B1F@acm.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193356 Archived-At: Hello again, Mattias. On Sun, Nov 15, 2020 at 13:30:28 +0100, Mattias Engdegård wrote: > 15 nov. 2020 kl. 13.20 skrev Alan Mackenzie : > > Maybe I need the same change in uncomment-region-default too, but > > I'm not sure. > It seems more difficult to provoke uncomment-region to change text > outside the region. Until we have a concrete example, better leave > that code unchanged. Yes, I agree. > > Here is a provisional patch, based on the master branch (although the > > fix should probably go into emacs-27). Could you test it, please. > Seems to work nicely. Thank you! Thanks! I've committed it to the emacs-27 branch, and I'm closing the bug with this post. -- Alan Mackenzie (Nuremberg, Germany).