From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Steven Allen Newsgroups: gmane.emacs.bugs Subject: bug#44542: [PATCH] Only use nbutlast when we actually want to modify the original list Date: Mon, 9 Nov 2020 15:53:31 -0800 Message-ID: <20201109235331.50177-1-steven@stebalien.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16395"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Michael Albinus To: 44542@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 10 00:54:21 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kcGzN-00049r-GM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 10 Nov 2020 00:54:21 +0100 Original-Received: from localhost ([::1]:50018 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcGzM-00007h-5E for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 Nov 2020 18:54:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36646) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcGz4-00007U-Cj for bug-gnu-emacs@gnu.org; Mon, 09 Nov 2020 18:54:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52597) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kcGz4-0006zm-3V for bug-gnu-emacs@gnu.org; Mon, 09 Nov 2020 18:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kcGz4-0005mx-2Q for bug-gnu-emacs@gnu.org; Mon, 09 Nov 2020 18:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Steven Allen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Nov 2020 23:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 44542 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.160496602122215 (code B ref -1); Mon, 09 Nov 2020 23:54:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 9 Nov 2020 23:53:41 +0000 Original-Received: from localhost ([127.0.0.1]:35910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcGyj-0005mE-61 for submit@debbugs.gnu.org; Mon, 09 Nov 2020 18:53:41 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:38788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcGyg-0005m4-4Z for submit@debbugs.gnu.org; Mon, 09 Nov 2020 18:53:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcGyf-00006Y-Rn for bug-gnu-emacs@gnu.org; Mon, 09 Nov 2020 18:53:37 -0500 Original-Received: from outgoing-stata.csail.mit.edu ([128.30.2.210]:57956) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcGyd-0006wS-Gd for bug-gnu-emacs@gnu.org; Mon, 09 Nov 2020 18:53:36 -0500 Original-Received: from cpe-66-75-240-41.san.res.rr.com ([66.75.240.41] helo=localhost) by outgoing-stata.csail.mit.edu with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kcGya-000KDd-Ss; Mon, 09 Nov 2020 18:53:33 -0500 X-Mailer: git-send-email 2.29.2 Received-SPF: pass client-ip=128.30.2.210; envelope-from=steven@stebalien.com; helo=outgoing-stata.csail.mit.edu X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/09 18:53:33 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192982 Archived-At: * lisp/net/tramp-gvfs.el (tramp-gvfs-dbus-byte-array-to-string): Don't modify the byte array. lisp/net/tramp-integration.el (tramp-eshell-directory-change): Don't modify the underlying exec-path. --- lisp/net/tramp-gvfs.el | 2 +- lisp/net/tramp-integration.el | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/net/tramp-gvfs.el b/lisp/net/tramp-gvfs.el index 8f8e628ab9d..86fb45a43b7 100644 --- a/lisp/net/tramp-gvfs.el +++ b/lisp/net/tramp-gvfs.el @@ -876,7 +876,7 @@ Return nil for null BYTE-ARRAY." byte-array (car byte-array)))) (dbus-byte-array-to-string (if (and (consp byte-array) (zerop (car (last byte-array)))) - (nbutlast byte-array) byte-array)))) + (butlast byte-array) byte-array)))) (defun tramp-gvfs-stringify-dbus-message (message) "Convert a D-Bus MESSAGE into readable UTF8 strings, used for traces." diff --git a/lisp/net/tramp-integration.el b/lisp/net/tramp-integration.el index f712600072e..7e4a9bf05e5 100644 --- a/lisp/net/tramp-integration.el +++ b/lisp/net/tramp-integration.el @@ -132,7 +132,7 @@ been set up by `rfn-eshadow-setup-minibuffer'." ;; Use `path-separator' as it does eshell. (setq eshell-path-env (mapconcat - #'identity (nbutlast (tramp-compat-exec-path)) path-separator))) + #'identity (butlast (tramp-compat-exec-path)) path-separator))) (with-eval-after-load 'esh-util (add-hook 'eshell-mode-hook -- 2.29.2