From: Steven Allen <steven@stebalien.com>
To: 44542@debbugs.gnu.org
Cc: Michael Albinus <michael.albinus@gmx.de>
Subject: bug#44542: [PATCH] Only use nbutlast when we actually want to modify the original list
Date: Mon, 9 Nov 2020 15:53:31 -0800 [thread overview]
Message-ID: <20201109235331.50177-1-steven@stebalien.com> (raw)
* lisp/net/tramp-gvfs.el (tramp-gvfs-dbus-byte-array-to-string): Don't
modify the byte array.
lisp/net/tramp-integration.el (tramp-eshell-directory-change): Don't
modify the underlying exec-path.
---
lisp/net/tramp-gvfs.el | 2 +-
lisp/net/tramp-integration.el | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/net/tramp-gvfs.el b/lisp/net/tramp-gvfs.el
index 8f8e628ab9d..86fb45a43b7 100644
--- a/lisp/net/tramp-gvfs.el
+++ b/lisp/net/tramp-gvfs.el
@@ -876,7 +876,7 @@ Return nil for null BYTE-ARRAY."
byte-array (car byte-array))))
(dbus-byte-array-to-string
(if (and (consp byte-array) (zerop (car (last byte-array))))
- (nbutlast byte-array) byte-array))))
+ (butlast byte-array) byte-array))))
(defun tramp-gvfs-stringify-dbus-message (message)
"Convert a D-Bus MESSAGE into readable UTF8 strings, used for traces."
diff --git a/lisp/net/tramp-integration.el b/lisp/net/tramp-integration.el
index f712600072e..7e4a9bf05e5 100644
--- a/lisp/net/tramp-integration.el
+++ b/lisp/net/tramp-integration.el
@@ -132,7 +132,7 @@ been set up by `rfn-eshadow-setup-minibuffer'."
;; Use `path-separator' as it does eshell.
(setq eshell-path-env
(mapconcat
- #'identity (nbutlast (tramp-compat-exec-path)) path-separator)))
+ #'identity (butlast (tramp-compat-exec-path)) path-separator)))
(with-eval-after-load 'esh-util
(add-hook 'eshell-mode-hook
--
2.29.2
next reply other threads:[~2020-11-09 23:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 23:53 Steven Allen [this message]
2020-11-10 9:08 ` bug#44542: [PATCH] Only use nbutlast when we actually want to modify the original list Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109235331.50177-1-steven@stebalien.com \
--to=steven@stebalien.com \
--cc=44542@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.