From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Boruch Baum Newsgroups: gmane.emacs.bugs Subject: bug#44306: package-delete exiting on encountering system/dependency packages Date: Sun, 1 Nov 2020 09:33:46 -0500 Message-ID: <20201101143346.ujtjrnyondllx3mp@E15-2016.optimum.net> References: <20201029125237.t4a5fiwrosfulpev@E15-2016.optimum.net> <87sg9vhn7w.fsf@gnus.org> <20201101024828.7gt3eq4khxclbgk5@E15-2016.optimum.net> <877dr5dz5y.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32198"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: NeoMutt/20180716 Cc: 44306@debbugs.gnu.org, Stefan Kangas To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 01 15:34:40 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZERL-0008Ev-OX for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Nov 2020 15:34:39 +0100 Original-Received: from localhost ([::1]:48522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZERK-0004nn-Gf for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Nov 2020 09:34:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZEQk-0004na-QT for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 09:34:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52793) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZEQk-0000ll-HR for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 09:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZEQk-0008LS-CM for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 09:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Nov 2020 14:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44306 X-GNU-PR-Package: emacs Original-Received: via spool by 44306-submit@debbugs.gnu.org id=B44306.160424123832068 (code B ref 44306); Sun, 01 Nov 2020 14:34:02 +0000 Original-Received: (at 44306) by debbugs.gnu.org; 1 Nov 2020 14:33:58 +0000 Original-Received: from localhost ([127.0.0.1]:36106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZEQf-0008LA-Pg for submit@debbugs.gnu.org; Sun, 01 Nov 2020 09:33:58 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:59239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZEQd-0008Kr-Pa for 44306@debbugs.gnu.org; Sun, 01 Nov 2020 09:33:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1604241229; bh=uB/06X9seQt3XN9BBzvQorDanyYkhefY3+TxHyjRxPE=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=VUHxufrgKEAhjeWgxf1guaQHhYE60Y+4YM7ycL6i5UkyT0d2gRhU+taQh7dCc2aCQ +Bjk5unf2nf/p0isHLBslnovIaAB8aOiWWhAMSt5hHKgGioe78OyNc4Mi/QiS+l3PL D0rV66Gr/mv03aLVOE2KIzmOKwhG0tzAqB1BKdm8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from E15-2016.optimum.net ([71.105.138.177]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MF3He-1kbUYe3Zuq-00FVnm; Sun, 01 Nov 2020 15:33:49 +0100 Content-Disposition: inline In-Reply-To: <877dr5dz5y.fsf@gnus.org> X-Provags-ID: V03:K1:PAKsoiAc2CvgdffFrd8H7KzOCfB1vGwCRo25o3137oXdq+OxESv 6G0ZRf1KwSnMvIf025oFrY/jbWWm0hjLCFhq9xAK1r3LB9RBJFTcN6TgGdbFd4MDAnWPLU6 flWz8Nfudsth6oa1yI7ZJ4nYXUpwWdeAZ6Kp7gRHYLwCm+7zbCbY4Ql/G7qeDyO/Ex2ix6y H1DDFrvvwR6kAV+3Q6J+w== X-UI-Out-Filterresults: notjunk:1;V03:K0:Ni5SNGZraoU=:CF4J8ByChCMawTj/3p6WUx U9CFUxb2lEbOePirSFfjwvXk6ea/WMdrBM43adVlUW6Sq5RAP7uolBb1L1+L0HAwK3nwjfo4q bNAJXyQv8lkjgfHybtsMp4xmEHvLCYz1tW+LJVhvIdUFNEi+xaniFncvggkxaPnMByWN98/6E 36gQBXy6wsrcxaJ16vq9mvigrx4cWhNe1C4eX8T9Tr5Oy9RZuFpWoO09CC730HWqkH8reMWxF EHKrs44iXddkWJNMHZOaW+PI7PVTuP2c9uUwvXjD8LBiMJmjf0JCjT1pi9hBiBnIO1RPvUCfR AqyHj60XO0kW+fb3ufDCI1xM4o/SA61XazRYo8ou+D1oBVloG1ojd39E7+iFaZOC6Ym8/vQVH KSqN1g6iSfdO9Fohkoew/UfL0ZoPsoEsOFu6GLYexsrxWtSN8qrXy8PIg0MPuA5m41KMte46b MmkIiV/JoflVCPhy18xENvZvthCZYwMkr98j4Y0kPueJZ3OrfbX/KflM5Gvwf1LlwgyFFs7nf hXju4qJmvJAIaf7qOLrg3b0/NltU4GwjjIf/eDIFsA4TFU3C8VkKFr7J6OflubUpbUDcENaN7 S2Jpya51NtlhOnPdRxu8wIxkLm78dyV5KAlk0ttgyxYJh9ORTiOsHExwj3QJP62KGpjTgqByI g6ykmAd031IlrMNW/ajWK6BA6O4xPY+qq4I6mRN2fd7GuB8tM8LNBmesrfw3iNeb3WqrKb3IH rXh+CEJEvOdMvE5Oy0XAzoAMuK1ljPz33sLkMBJ4t9+jmA5PVO95h8CwKtdfM1JivC4VY8mb X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192386 Archived-At: On 2020-11-01 13:44, Lars Ingebrigtsen wrote: > Boruch Baum writes: > > > That's not really my point. My point in the bug report is that while > > technically the use of function 'error' is correct in this case, it wo= rks > > out to be counter-productive and should be replaced with a simple use = of > > the function 'message' logging the condition to the *Messages* buffer. > > Since it sounds like package-autoremove is making a list of candidates > that includes packages that should not be removed, the `error' there > sounds like exactly the right thing? Because it's uncovering a bug in > package-autoremove. But it shouldn't prevent the user from auto-removing all the other legitimate packages! I had been ignoring this for a long time until the accumulated list exceeded 40 packages. In the end, this bug denied removal of 28, which were all removed when I replaced the 'error' with a 'message'. With my approach, users still get the notification of the problem, and are able to perform the legitimate parts of the operation. Another way of thinking about the issue it to imagine offering the user to auto-remove packages individually, selecting one package at a time. In that imaginary (and burdensome) case would you also deny the user to remove package F because some other package B was improperly on some list? Yet another way of thinking about the issue is to think of the consequences. In this case, the error function isn't stopping anything bad from happening (the system package wouldn't get removed even without the abort), it only stops other good things from happening (legitimate packages don't get removed). If you absolutely insist on using the 'error' function, you can delay it until processing *all* the packages, accumulating the names of the system ones. That approach will also generate a more informative error message than is currently done because it could report all the packages wrongfully on the list (currently, only the first is reported). =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0