bug#44306: package-delete exiting on encountering system/dependency packages

[Boruch Baum <boruch_baum@gmx.com>]

On 2020-11-01 13:44, Lars Ingebrigtsen wrote:
> Boruch Baum <boruch_baum@gmx.com> writes:
>
> > That's not really my point. My point in the bug report is that while
> > technically the use of function 'error' is correct in this case, it works
> > out to be counter-productive and should be replaced with a simple use of
> > the function 'message' logging the condition to the *Messages* buffer.
>
> Since it sounds like package-autoremove is making a list of candidates
> that includes packages that should not be removed, the `error' there
> sounds like exactly the right thing?  Because it's uncovering a bug in
> package-autoremove.

But it shouldn't prevent the user from auto-removing all the other
legitimate packages! I had been ignoring this for a long time until the
accumulated list exceeded 40 packages. In the end, this bug denied
removal of 28, which were all removed when I replaced the 'error' with a
'message'. With my approach, users still get the notification of the
problem, and are able to perform the legitimate parts of the operation.

Another way of thinking about the issue it to imagine offering the user
to auto-remove packages individually, selecting one package at a time.
In that imaginary (and burdensome) case would you also deny the user to
remove package F because some other package B was improperly on some
list?

Yet another way of thinking about the issue is to think of the
consequences. In this case, the error function isn't stopping anything
bad from happening (the system package wouldn't get removed even without
the abort), it only stops other good things from happening (legitimate
packages don't get removed).

If you absolutely insist on using the 'error' function, you can delay it
until processing *all* the packages, accumulating the names of the system
ones. That approach will also generate a more informative error message
than is currently done because it could report all the packages
wrongfully on the list (currently, only the first is reported).


--
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0