From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Boruch Baum Newsgroups: gmane.emacs.bugs Subject: bug#44306: package-delete exiting on encountering system/dependency packages Date: Sat, 31 Oct 2020 22:48:28 -0400 Message-ID: <20201101024828.7gt3eq4khxclbgk5@E15-2016.optimum.net> References: <20201029125237.t4a5fiwrosfulpev@E15-2016.optimum.net> <87sg9vhn7w.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5548"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: NeoMutt/20180716 Cc: Lars Ingebrigtsen , 44306@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 01 03:49:47 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZ3RD-0001MP-C3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Nov 2020 03:49:47 +0100 Original-Received: from localhost ([::1]:53956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZ3RB-0007xA-NZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Oct 2020 22:49:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34130) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZ3QU-0007wz-OJ for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2020 22:49:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51885) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZ3QU-0003eC-FG for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2020 22:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZ3QU-0000iJ-CW for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2020 22:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Nov 2020 02:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44306 X-GNU-PR-Package: emacs Original-Received: via spool by 44306-submit@debbugs.gnu.org id=B44306.16041989192707 (code B ref 44306); Sun, 01 Nov 2020 02:49:02 +0000 Original-Received: (at 44306) by debbugs.gnu.org; 1 Nov 2020 02:48:39 +0000 Original-Received: from localhost ([127.0.0.1]:35198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZ3Q7-0000hb-KO for submit@debbugs.gnu.org; Sat, 31 Oct 2020 22:48:39 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:44305) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZ3Q5-0000hO-LM for 44306@debbugs.gnu.org; Sat, 31 Oct 2020 22:48:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1604198911; bh=NLDEDKC41wxqtVubRI89LgcI/BUd7VurzrMPh18S4Ik=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=XBDXnONWh8AuqvZYy7hiQRaZIG0/ylWNb9qhGFSha4S633/91pI5+JNLB48WdTnBK 3tMO/P9Mh7QyVtnsOvfg1Mtr6tTVmTr973uAHxFDvI52Qi7xtbQC9jyRp28W5aJa91 SiS8ljuJRRCPpJ4QPRBoAVMIHufcOvuTKdp0c2ZI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from E15-2016.optimum.net ([71.105.138.177]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1N1wlv-1kOVZX2ooL-012GuO; Sun, 01 Nov 2020 03:48:31 +0100 Content-Disposition: inline In-Reply-To: X-Provags-ID: V03:K1:WNVsLEGCuDtPxBlO1JNrupByOrUd6WGhRR8eBzQLPVVuPmO68aE sjF7LBEKWbM8+fsc5Ie/x9Uqn3+QGe8ZB2klICsOP5ts9GdGDoXr5+MMHYLrEU2lEYghSwu QyGNNh8TmFb/XKc2cva7jEUr57NMHuDJoB2fH4xatfxh9YfMEXbQVypqA9Qj77MhVn2fES+ PMIfQWA0rRgy/Hf78ollQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:jh3u9iFKT5U=:zjdteF6fy4fhDjVEnSvmDK HuU7X84U/CMLu5HJ+nLBMqqXrtDM4cHCHjr9wyYjilHKIzh2ZFb+Cvn3ZHqVRiAm+Izyw0N/C I+3ULaBzasDIxOijfiVwaBbhsaTTdNrb8WNbPuQklP5upyix73PAO3Tw52HKf4MHA4vGyyDuj 8J7dZoKJUW0AUTTrRGSwxP34yyaiRWGrxjYhOFxJldb4Vbs6WWcKSFVd106/JIk2OdR5S7Lk0 RpVfSTlAIfC1wgC+mR7kCgfzlr+S/7kemgGm9mExscFi3xCYTKiYXFrxOzAkRSlDsPj7UIrb1 LmDVdNXRo9j7CES7x8gHA57WqIgyCyr1/dUKdh2Is/pHV8fSqJnx+XO4nPjJcARwpZEgDYYGT qcXYOzLsc15cM/wGPXXZO4Fc+JSeTQZlrVj3RGMrkjE3Kpzb0ifVQGDIbiYOX9zDjgTjtJAIF oaQb9tVHQmpOBjw+TTasPAyI7T7LZwe9tls3s2C6xi1qtLbBhs5mmv7u3n1DZNiKSnBQwMwce OQE+b4yudW6h4rPTgc6d2qMLBGwhaSrF7wiw2XWbLBKbxQnyhaPZXTPEmRjKxGuSeZawRhB8f OyER7Ae1khwI36L4/i+reHz+3qI/QFZZYBbbsF05twgiYVaJJSrd+uo732sF/bZvRrIyi3CIT lZnRZnuZAe24Wt35SzvWphpVDLi8+cYGTjMfng1XqrFAdTWlcOvCeXqux3Q9Tv/pePzTqR2VO ShGb/WgPO35jtv8Yy7FTD5nBYUP26dPMrm2EWna7q0CwDxU/lX2RxQISHmycgKmkW3JMEFl6 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192327 Archived-At: On 2020-10-30 13:34, Stefan Kangas wrote: > Lars Ingebrigtsen writes: > > > Boruch Baum writes: > > > >> When attempting to perform package-autoremove to clean up obsolete > >> packages, my emacs would abort with an error that `foo' is a system > >> package. Thus, it had become impossible to perform the operation. I > >> altered function package-delete to replace its two calls to function > >> `error' with simple `message' and can now clean up the packages. > > > > It kinda sounds like there something wrong in what package-autoremove = is > > trying to delete. > > Indeed. The question is why these packages are considered for removal > at all. The function that builds the candidate list, package--removable-packages, doesn't take into account the criteria used in function 'package-delete'. > If we can avoid doing that, the error "Package `%s' is used by `%s' as > dependency, not deleting" seems correct to me - it will catch bugs. That's not really my point. My point in the bug report is that while technically the use of function 'error' is correct in this case, it works out to be counter-productive and should be replaced with a simple use of the function 'message' logging the condition to the *Messages* buffer. Using the error function aborts the entire auro-remove process for all packages on the list, and in this case isn't even useful for the specific package because the function is written to independently reject further processing for the package. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0