From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#44206: 28.0.50; SVG image fail to show Date: Mon, 26 Oct 2020 19:36:20 +0000 Message-ID: <20201026193620.GI59267@breton.holly.idiocy.org> References: <87o8krkmwg.fsf@gmail.com> <20201025160105.GE59267@breton.holly.idiocy.org> <45cc75c5-080f-4b93-84c4-95cc459e7821@www.fastmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26227"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44206@debbugs.gnu.org To: Sheng Yang Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 26 21:22:30 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kX90g-0006kC-3c for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Oct 2020 21:22:30 +0100 Original-Received: from localhost ([::1]:46124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kX90f-0001Gh-13 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Oct 2020 16:22:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60712) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kX8Ii-0006wd-Vv for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 15:37:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58127) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kX8Ig-0002Te-8O for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 15:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kX8Ig-00086E-65 for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 15:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Oct 2020 19:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44206 X-GNU-PR-Package: emacs Original-Received: via spool by 44206-submit@debbugs.gnu.org id=B44206.160374099431099 (code B ref 44206); Mon, 26 Oct 2020 19:37:02 +0000 Original-Received: (at 44206) by debbugs.gnu.org; 26 Oct 2020 19:36:34 +0000 Original-Received: from localhost ([127.0.0.1]:41440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX8ID-00085X-Ml for submit@debbugs.gnu.org; Mon, 26 Oct 2020 15:36:34 -0400 Original-Received: from mailout-l3b-97.contactoffice.com ([212.3.242.97]:57606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX8IB-00085I-IZ for 44206@debbugs.gnu.org; Mon, 26 Oct 2020 15:36:32 -0400 Original-Received: from smtpauth1.co-bxl (smtpauth1.co-bxl [10.2.0.15]) by mailout-l3b-97.contactoffice.com (Postfix) with ESMTP id AEA271923; Mon, 26 Oct 2020 20:36:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1603740984; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To; l=2111; bh=LwLTa9MEYUfyh9dI+ofrDvLGKG4AElLYglxU74r7COg=; b=F4zP+EMnL41JSz4//iIjDbLwV7OssxVBYe44bX4xMaXgVWA0JkpVJSPg7nvtnymS 1KJMQStGrC0J5OSQTS0vwzno1EYXv5T7A75eP4jP8w4GP0xugfLmQqoLbtlww1FeStD a3SdRt60/cKPH5qQWeC/y1Lg9TOtJl59dOHjPIKSxReGMgLcz6U2w15a1gMXov1FMlR eeCGKcpyl5M5vZjRqmzl2pXKEbQhdp3fIFjh2TR/l0ViAtbEhMIOSrHrDAINVeT1j6Q NoyhydvvYb1tJKsHUlDgRYDHmbYR9Xh6xD+iK6vQpxs5EbmTsHqT2K8W94JUXlzQ4wk l6B4a02saA== Original-Received: by smtp.mailfence.com with ESMTPA ; Mon, 26 Oct 2020 20:36:21 +0100 (CET) Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id C9B4A20263FDF2; Mon, 26 Oct 2020 19:36:20 +0000 (GMT) Mail-Followup-To: Alan Third , Sheng Yang , 44206@debbugs.gnu.org Content-Disposition: inline In-Reply-To: <45cc75c5-080f-4b93-84c4-95cc459e7821@www.fastmail.com> X-ContactOffice-Account: com:241649512 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191647 Archived-At: On Sun, Oct 25, 2020 at 12:17:16PM -0500, Sheng Yang wrote: > Thanks for your effort! Patch works for me, librsvg 2.50 on Archlinux. > > On Sun, Oct 25, 2020, at 11:01, Alan Third wrote: > > Anyway, I've thrown in another attempt at calculating the image size, > > and it works for this and also for the previous images. This one is > > more complex because it's trying to convert CSS sizes to pixel sizes > > and I don't think we can be entirely sure of some of them (like ex > > height? Maybe we can query that, but then we have to know font and > > font size). > > > > I have no doubt that there are many more SVG files out there that > > won't display properly even with this patch. > > I checked places where I use SVG files, especially telega, > everything I checked looks good to me now. Hope there are not too > many corner cases. Thanks. > > librsvg is really not helping here. The documentation makes it pretty > > clear that they don't want us to be querying the SVG dimensions and > > would prefer us to just give them the dimensions we want and/or to use > > Cairo. > > So could the future of SVG in Emacs lie in Cairo? Forgive me if I am > asking a dumb question. Not a dumb question. This came up a little while back and I think there might be potential issues with getting Cairo on Windows, so it's not necessarily a great solution. One thing is that, in theory, if we were using SVGs for parts of the UI, like fringe bitmaps, we wouldn't have to worry too much about resizing and so on as we control the SVGs and can define them to suit our uses. > > > Affected librsvg version: 2:2.50.1-1 in Archlinux, and 2.44.10-2.1 in Debian. > > > > I'm concerned that librsvg 2.44 is affected as it should be using the > > same code path as before the commit in question. > > My fault, librsvg 2.44 on Debian is NOT affect by this. (I guess I > was having internet issue with my vps running debian. Last time I > waited for a few seconds and the image was not showing up. I waited > a bit longer this time.) Ah, good to know. Thanks! -- Alan Third