From: Boruch Baum <boruch_baum@gmx.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 44021@debbugs.gnu.org
Subject: bug#44021: delete-non-matching-lines optional arg REND not really optional
Date: Fri, 16 Oct 2020 02:42:51 -0400 [thread overview]
Message-ID: <20201016064251.i67dn7sjily5jyds@E15-2016.optimum.net> (raw)
In-Reply-To: <87sgaeraud.fsf@gnus.org>
On 2020-10-16 07:36, Lars Ingebrigtsen wrote:
> I've now mentioned this in the doc string.
Not the solution I was expecting. I was expecting the ARG to really
become optional, to be consistent with similar END arguments in other
emacs functions. Something like:
(setq rend (or rend (point-max)))
Also, as a quibble, for consistency the args should be renamed START and
END, instead of RSTART and REND. See, for instance,
(delete-trailing-whitespace &optional START END)
(narrow-to-region START END)
This is true even in the same elisp file replace.el:
(replace-regexp regexp to-string &optional delimited start end backward)
(replace-string from-string to-string &optional delimited start end backward)
and many other functions in the same file, so it seems to have been an
oversight in integrating the function. The standard seems to be that the
args are named START and END and really are optional.
--
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0
prev parent reply other threads:[~2020-10-16 6:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 18:57 bug#44021: delete-non-matching-lines optional arg REND not really optional Boruch Baum
2020-10-16 5:36 ` Lars Ingebrigtsen
2020-10-16 6:42 ` Boruch Baum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016064251.i67dn7sjily5jyds@E15-2016.optimum.net \
--to=boruch_baum@gmx.com \
--cc=44021@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.