From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Koichi Arakawa Newsgroups: gmane.emacs.bugs Subject: bug#44026: [PATCH] vc.el: vc-revision-other-window does not select the buffer Date: Fri, 16 Oct 2020 12:14:15 +0900 (=?UTF-8?Q?=E6=9D=B1=E4=BA=AC?= (=?UTF-8?Q?=E6=A8=99=E6=BA=96=E6=99=82?=)) Message-ID: <20201016.121415.833818327181483184.arakawa@pp.iij4u.or.jp> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31304"; mail-complaints-to="usenet@ciao.gmane.io" To: 44026@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 16 05:15:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTGD5-00083d-Jl for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Oct 2020 05:15:16 +0200 Original-Received: from localhost ([::1]:52970 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTGD4-0001Jx-I3 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Oct 2020 23:15:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTGCs-0001Jk-KI for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2020 23:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45602) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kTGCs-0004oB-Av for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2020 23:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kTGCs-0007n9-74 for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2020 23:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Koichi Arakawa Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Oct 2020 03:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 44026 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.160281807329899 (code B ref -1); Fri, 16 Oct 2020 03:15:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 16 Oct 2020 03:14:33 +0000 Original-Received: from localhost ([127.0.0.1]:57148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTGCP-0007mB-ED for submit@debbugs.gnu.org; Thu, 15 Oct 2020 23:14:33 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:41734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTGCN-0007m3-Bk for submit@debbugs.gnu.org; Thu, 15 Oct 2020 23:14:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40692) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTGCN-0001Gj-6f for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2020 23:14:31 -0400 Original-Received: from mo-sw1510.iijmio.jp ([203.180.38.129]:37516 helo=mo-sw.iijmio.jp) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kTGCK-0004aR-6T for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2020 23:14:30 -0400 DKIM-Signature: v=1;a=rsa-sha256;c=relaxed/simple;d=pp.iij4u.or.jp;h=Date: Message-Id:To:Subject:From:Mime-Version:Content-Type: Content-Transfer-Encoding;i=arakawa@pp.iij4u.or.jp;s=20200530.mm;t= 1602818058; x=1604027658; bh=lHBcqP4ups/+KKfRAJAcrVSarILTx4cr+KLvFzJBf4I=; b=kB1 resqWNLrOKlLXOgss67fhZGD/SSiaxudUbI/0M4hGPOV7QgKE/CTyDYC9TLxw2IsqcFN4Jkq75lUz A+KKD7Q3EXg+jj0JNfGuoFCLbInyHxU7ymNwSMZZwW2hTaW5zWVFEmKRPS1V5oIIefIfuhWL+tYZ7 Znk7UsH1oocZ/KiJwg6cm7uBrJPNHi6ncyknDSURt9qvsZkQz3XX8GmYcoJo9zEKL1fVCZ5tzLefT cTvV+ErS74WwRqFxA1NL+i68DOLCzwsI0OKUwBjjj/DFWfnVvynIlWRSFxwddj4Qo9WUb+DJjZ/v0 p4x+pV9op/G5wf9sEArz9h17JLekNJA==; Original-Received: by mo-sw.iijmio.jp (mio-mo-sw1510) id 09G3EIjc002098; Fri, 16 Oct 2020 12:14:18 +0900 Original-Received: from localhost (corsica.s2factory.co.jp [122.220.15.114]) by mbox.iij4u.or.jp (mio-4u-mbox1511) id 09G3EHMo000957 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 16 Oct 2020 12:14:17 +0900 X-Mailer: Mew version 6.8 on Emacs 28.0 Received-SPF: pass client-ip=203.180.38.129; envelope-from=arakawa@pp.iij4u.or.jp; helo=mo-sw.iijmio.jp X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/15 23:14:19 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -7 X-Spam_score: -0.8 X-Spam_bar: / X-Spam_report: (-0.8 / 5.0 requ) BAYES_00=-1.9, BUG6152_INVALID_DATE_TZ_ABSURD=0.1, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, INVALID_DATE=1.096, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190636 Archived-At: Hi, The current version of vc-revision-other-window does not select a buffer which contains the specified revision. But ediff-vc-internal, for example, expects the buffer is selected as the current one. So I think the following patch is needed. Regards, Koichi Arakawa diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 46c44fa54b..f34bd0f2a1 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -2058,13 +2058,12 @@ If `F.~REV~' already exists, use it instead of checking it out again." (list (vc-read-revision "Revision to visit (default is working revision): " (list buffer-file-name))))) - (with-current-buffer (or (buffer-base-buffer) (current-buffer)) - (vc-ensure-vc-buffer) - (let* ((file buffer-file-name) - (revision (if (string-equal rev "") - (vc-working-revision file) - rev))) - (switch-to-buffer-other-window (vc-find-revision file revision))))) + (vc-ensure-vc-buffer) + (let* ((file buffer-file-name) + (revision (if (string-equal rev "") + (vc-working-revision file) + rev))) + (switch-to-buffer-other-window (vc-find-revision file revision)))) (defun vc-find-revision (file revision &optional backend) "Read REVISION of FILE into a buffer and return the buffer.