From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Boruch Baum Newsgroups: gmane.emacs.bugs Subject: bug#43709: minibuffer keybinding cheatsheet and launcher [CODE SUBMISSION] Date: Thu, 1 Oct 2020 14:25:04 -0400 Message-ID: <20201001182504.mrdldh3rdf3uuvbm@E15-2016.optimum.net> References: <20200929165957.ibj67dnyaem6nezg@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15485"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: NeoMutt/20180716 Cc: 43709@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 01 20:27:34 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kO3Ij-0003sf-DP for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Oct 2020 20:27:33 +0200 Original-Received: from localhost ([::1]:59850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kO3Ii-0001sV-8E for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Oct 2020 14:27:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46988) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kO3HG-0001rB-Oj for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 14:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54957) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kO3HG-0003YB-99 for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 14:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kO3HG-0005Y4-6B for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 14:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Oct 2020 18:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43709 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43709-submit@debbugs.gnu.org id=B43709.160157672221282 (code B ref 43709); Thu, 01 Oct 2020 18:26:02 +0000 Original-Received: (at 43709) by debbugs.gnu.org; 1 Oct 2020 18:25:22 +0000 Original-Received: from localhost ([127.0.0.1]:38270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO3Gb-0005XB-MG for submit@debbugs.gnu.org; Thu, 01 Oct 2020 14:25:21 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:33991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO3GX-0005Wt-6r for 43709@debbugs.gnu.org; Thu, 01 Oct 2020 14:25:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1601576708; bh=NCNnfNoWMu0JWE+V0QrE7Q2n3EJdJgNzpIRr1aKAmB4=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=TfEmmIjdTok1ZO4OrFHq/uRdk5a+MYIvTl8Y6wil9l8jkDxdWEOnjQNpPKK8OklA/ he2Uid9XJKPcefMkhIo/RYISkcea3JZUsBkowC8lUipvJCtph/H7lC05kgTffTwQds bnVU78qr/cx96QilCZB7DJMDqVqJdiA7RbJKrj7Q= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1McpJq-1kwpqj2w2k-00ZtX4; Thu, 01 Oct 2020 20:25:08 +0200 Content-Disposition: inline In-Reply-To: X-Provags-ID: V03:K1:oZckP0OIoHIMAN9FeUPG+A+iJHZ/bQKpyxtHnSnhgRAuoz8R4Kp C/L7mThy6CQ+2Ki+m077R4/PQdXTv0UKgHgcrp4U4RQC4YKrLf2bz7DV+X/s7LKScHZOvcK 37jk9i7NKJ+6I1GgmnvZA6TnLUaY9Z/yzo37xckSKSot5AtTlG73CfAgOVF/JGCJGB5NCfW U5qRZn1RRMEKApeOsqmSg== X-UI-Out-Filterresults: notjunk:1;V03:K0:uAT1P2RPIiE=:8fTNjX7pHbtAepg8i4FwtC 5iYqg/DfJqmWNg6qOLlDTt0khh2ODVSpwZ5Wh44UcZq5R0s352u2LH0xRDBKDGbJ5Tz6MSRUS m5BTpyOP16HhTzDxdxQmQqPkZPhF+TmvZ1iqQL6iqg872LofYy9lm16Ynq3nbx8cKqVNYMUZ6 kmk58BScDAZg57UId47lMgpnEY3MBVQdL+J4XO+KFAPrE3BfgOj3PyG0b05rVSyblocnkhPg/ f5Tu9lgP2lZJTcTYiBIDXsEOD31gjo7wTMzPfltBc9yzeQ6oyLinZEcLQPtntY1qCXsz67a1w NZDBHEDTI/iljXzFgkjTOB5o1xKtgmcDEJVrkq2rQ0gjaOYO8erSU9s9SEAJ8XmlBTXR5PqjN Z7t6pJte5lbwvlrVFCS8W0TkQ4ONaiKEkTpPMB3hRZk5jWxv2xZ7RmziVGsUci+GLlYGzyC5k B60GOcC5zLpUO16FMK3CSSGv9rcOvEEyJFbUHRY3QhxCX/K61jCMoG2u75Tce4r3yLBAMBRPo TgZK4G2PIhVGzsVO00TaDoPwhl7SISQCoF3bqCWJwA6etMXmEr9YJs1hBhbeHJS4rQC56ItlK zBDA+G1hNRcqdlGDMKT2Hsho1XBRghLgU4zdQO8FCttWFG0sDfrAQtUDlFI/4Vd056LppcPSm nlRt0HJ35wrtPSgdf5agZhEWapumhs7FWbRO9Q3ObJer4wqIqx2sGL9DVfsNDQxmVYY/6lfXN VlWIZKs7I19sR4BA/WcAvOJSs7CRHJOFmBLmHeiOZcAQTkhrhiIvowjGMoQf/s5GYFbcdoQg X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189552 Archived-At: On 2020-10-01 09:51, Stefan Monnier wrote: > > ;; If you've ever used packages such as `ivy' or `magit', you've > For those who haven't, it would be good to describe what your package do= es. In progress... > > (require 'cl-seq) ;; cl-member, cl-position > Please require `cl-lib`grather than `cl-seq` Done. > > (let ((not-found t)) > > (mapc (lambda (x) > > (when (string-match x (format "%s" cmd)) > > (setq not-found nil))) > > key-assist-exclude-regexps) > > not-found))) > > You should move the `(format "%s" cmd)` out of the loop (and use > `dolist` instead of `mapc`). Done, but I went with symbol-name instead of format. > > ((keymapp spec) > > (let (cmd) > > (dolist (elem spec) > > Please use `map-keymap` rather than `dolist` so as to handle all the > different keymap formats. I had tried that originally, but map-keymap brings in data from parent keymaps, which is undesirable in this case. There is a function map-keymap-internal which might be a usable alternative, but it returns a single unusable cruft element (the parent keymap) when it exists, so the result doesn't seem much better than the current code, no? > > (funcall (car (nth choice commands)))))) > > This should probably be `command-execute` rather than `funcall` to fix > the wrong-number-of-arguments error I bumped into. Great catch. It solves the bug you found. Done. As for posting updates to the code submission, I can do any combination of the following, or something else, but want guidance before proceeding: 1) post to this list; 2) post to the pre-existing thread on emacs-bugs; 3) create a github repo, and post there (and gain potential wider audience, more features, but fragment communication over two platforms); 4) create a repo on some imagined savannah / gnu server; Finally: Tomorrow approaching sunset I go offline for about nine days[1], so what I can squeeze in before then, great; afterwards I welcome any continued feedback but please be patient and don't expect any response for ~10-12 days. But really finally this time: I've twice already made passing reference to another package about ready to submit, that adds a lot of new functionality to dired. I can post it now in its current state, and inconsiderately disappear offline for 9+ days, or I could just as inconsiderately not post it and deny you for 9+ days. I'm undecided, so unless I hear otherwise, I'll wait. =2D- [1] https://en.wikipedia.org/wiki/Sukkot =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0