From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#43470: 27.1; Drag and Drop not working properly in 27.1 on OSX Date: Fri, 18 Sep 2020 13:54:24 +0100 Message-ID: <20200918125424.GF635@breton.holly.idiocy.org> References: <0EB1A591-9FE4-4128-96A0-C2A8E36BC8CE@duke.edu> <20200917174640.GB635@breton.holly.idiocy.org> <32895e7e-d608-48ad-8f03-397f2d03cd06_IMAP_ADDED_MISSING@ICHABOD> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5018"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Paul Magwene, Ph.D." , 43470@debbugs.gnu.org To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 18 14:56:36 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJFwJ-0001C4-Sf for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Sep 2020 14:56:36 +0200 Original-Received: from localhost ([::1]:44008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJFwI-0004Gn-S2 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Sep 2020 08:56:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37252) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJFuo-0002yR-TT for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 08:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57895) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJFuo-0006M4-Ao for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 08:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJFuo-0008Kf-8r for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 08:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Sep 2020 12:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43470 X-GNU-PR-Package: emacs Original-Received: via spool by 43470-submit@debbugs.gnu.org id=B43470.160043368031991 (code B ref 43470); Fri, 18 Sep 2020 12:55:02 +0000 Original-Received: (at 43470) by debbugs.gnu.org; 18 Sep 2020 12:54:40 +0000 Original-Received: from localhost ([127.0.0.1]:41208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJFuS-0008Jv-67 for submit@debbugs.gnu.org; Fri, 18 Sep 2020 08:54:40 -0400 Original-Received: from mailout-l3b-97.contactoffice.com ([212.3.242.97]:46070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJFuP-0008Jh-DD for 43470@debbugs.gnu.org; Fri, 18 Sep 2020 08:54:38 -0400 Original-Received: from smtpauth2.co-bxl (smtpauth2.co-bxl [10.2.0.24]) by mailout-l3b-97.contactoffice.com (Postfix) with ESMTP id A00C515AF; Fri, 18 Sep 2020 14:54:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1600433670; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To; l=1560; bh=6f3JkgsLFJCV5SVoDTvymTwHyudXUELFTHHuSKrVCl0=; b=Udq1chqmb4Hfkg+KXGWxE/kxZOCHNcgnL79DY1K/p/9KI1xhI91sKXsBMXjeSYe2 tyIuw/csNFe7A18eNCQBYIHkFr3V0taxmlPExB9AaSLFyXWOzd2WupQKP4FBOCXypR5 m6K8WDdwBLpQKPN2SOw+cI1BjN3D0oyzPcfamaPEcNgsNX3UGWGlTDAQDRr8AL6yHfE SJ6upwJFbljYAspLW6woJaCODNjhxocKT6t82R7vBsT2Z393tXqpiFpyHi7Q6H8m6Oi sRaQxbwISFLw11A6TrNioA3NZAaGmqGSQV5rzbnsx2sfpAnj1NdYiZda0Je/mCojsUQ LOE7GwnyXg== Original-Received: by smtp.mailfence.com with ESMTPA ; Fri, 18 Sep 2020 14:54:26 +0200 (CEST) Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 30ED020256B8D7; Fri, 18 Sep 2020 13:54:24 +0100 (BST) Mail-Followup-To: Alan Third , Daniel =?UTF-8?Q?Mart=C3=ADn?= , "Paul Magwene, Ph.D." , 43470@debbugs.gnu.org Content-Disposition: inline In-Reply-To: X-ContactOffice-Account: com:241649512 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188295 Archived-At: On Fri, Sep 18, 2020 at 02:00:16PM +0200, Daniel Martín wrote: > Alan Third writes: > > > IIRC (and I could definitely be wrong here) a simple find/replace > > breaks the ability to handle more than one file being dragged at a > > time, which is why I left it (it used to work fine even though it was > > flagged as deprecated). > > You're right. I also misread the FIXME, which mentions this particular > problem. That part of the patch is not correct. > > I think we need to use the same constant names as those that are > included in the ns_drag_types array, at least until we implement proper > support for the new pasteboard API. This means that three constant names > should be renamed in nsterm.m. I'll have to have a look at the new API again, I can't remember anything about it or why I didn't use it the last time I worked on this. If you fancy giving it a go, feel free. > I've attached a new patch that implements this idea. I've tested the > following drag and drop operations work correctly after the patch is > applied: > > - Drag a URL. > - Drag arbitrary text from another application. > - Drag tabular text from another application. > - Drag a couple of files from the OS file manager. It correctly creates > a couple of buffers in Emacs that visit those files. This looks good to me. I think we'll want to apply it to Emacs 27 since this is a regression from Emacs 26 and the fix is minimal, so can you please rebase against emacs-27 and I'll push it there. Thanks! -- Alan Third