From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#22369: 24.5; comment-style 'extra-line' doesn't correctly indent with tabs Date: Thu, 17 Sep 2020 19:21:38 +0000 Message-ID: <20200917192138.GA5562@ACM> References: <20160115115628.56863.qmail@mail.muc.de> <87a6xonw12.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2505"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Geyslan G. Bem" , 22369@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 17 21:22:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIzTv-0000YB-WB for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Sep 2020 21:22:11 +0200 Original-Received: from localhost ([::1]:58432 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIzTv-0002JY-03 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Sep 2020 15:22:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIzTm-0002IN-Qm for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 15:22:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55802) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIzTm-0001Pp-Hk for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 15:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIzTm-00049h-Du for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 15:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Sep 2020 19:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22369 X-GNU-PR-Package: emacs Original-Received: via spool by 22369-submit@debbugs.gnu.org id=B22369.160037050815950 (code B ref 22369); Thu, 17 Sep 2020 19:22:02 +0000 Original-Received: (at 22369) by debbugs.gnu.org; 17 Sep 2020 19:21:48 +0000 Original-Received: from localhost ([127.0.0.1]:39115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIzTY-00049B-1B for submit@debbugs.gnu.org; Thu, 17 Sep 2020 15:21:48 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:48285 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1kIzTV-00048v-RU for 22369@debbugs.gnu.org; Thu, 17 Sep 2020 15:21:46 -0400 Original-Received: (qmail 25442 invoked by uid 3782); 17 Sep 2020 19:21:39 -0000 Original-Received: from acm.muc.de (p4fe15ef3.dip0.t-ipconnect.de [79.225.94.243]) by localhost.muc.de (tmda-ofmipd) with ESMTP; Thu, 17 Sep 2020 21:21:38 +0200 Original-Received: (qmail 4876 invoked by uid 1000); 17 Sep 2020 19:21:38 -0000 Content-Disposition: inline In-Reply-To: <87a6xonw12.fsf@gnus.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188247 Archived-At: Hello, Lars and Geyslan. On Thu, Sep 17, 2020 at 19:38:33 +0200, Lars Ingebrigtsen wrote: > Alan Mackenzie writes: > >> May I suggest the addition of a new comment-style option that does like this? > >> /* void main() > >> * { > >> * int i; > >> * int b; > >> * printf("format string"); > >> * } > >> */ > > OK, because of this feature request, I'll leave the bug open. This would > > indeed not be difficult to implement, but it'll have to be discussed on > > the developers' mailing list. > Was this ever discussed any further? It looks a bit odd to me... I don't think there was any more discussion about this. To be exact, the feature request was to have another option for comment-style called something like bottom-extra which would add an extra comment line at the bottom of a group, but not one at the top. Four years on, I'm not convinced the feature is worth implementing, even if it wouldn't be difficult. It would involve extending the spec of comment-styles such that each entry would have EXTRA-TOP and EXTRA-BOTTOM in place of the current EXTRA. Backward compatibility could be had at the cost of counting the number of elements in each entry. One quirk the OP, Geyslan, pointed out was a possibly obtrusive space when an empty line gets commented in comment-style extra-line, something like: /* * foo(); * <=========== possibly obtrusive space. * bar(); */ I'm not sure whether or not this is a bug or a feature. If a bug, it wouldn't be difficult to fix. Geyslan, have you any more thoughts about this bug? > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no -- Alan Mackenzie (Nuremberg, Germany).