From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Uniquify change [PATCH] Date: Tue, 15 Sep 2020 13:34:55 +0200 Message-ID: <20200915113455.qg7e4nxya2ibtga4@Ergus> References: <20200912115007.tze35edwcdo5vdoc.ref@Ergus> <20200912115007.tze35edwcdo5vdoc@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29963"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 15 13:36:48 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kI9GR-0007jt-8H for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Sep 2020 13:36:47 +0200 Original-Received: from localhost ([::1]:51794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kI9GQ-0001n7-3v for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Sep 2020 07:36:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kI9Es-0000TN-8h for emacs-devel@gnu.org; Tue, 15 Sep 2020 07:35:10 -0400 Original-Received: from sonic314-13.consmr.mail.bf2.yahoo.com ([74.6.132.123]:40449) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kI9Eo-0002eS-CE for emacs-devel@gnu.org; Tue, 15 Sep 2020 07:35:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1600169704; bh=9zkmvD6dsw6EZxFBVrn+Cjn3Ceg10IIWCRJzSDjC9VQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=ZM2YpZ2rWrN+jMWHGeYb5DsdksDKO4cOhGBBWyO0s/hX5DF5uPD5G3Y+PQsn+9O7ojIt/bX2S2eIH/Q1G2qcFgQbU5N/na2pUNhCoOlRaidpqK/3R/icOcdd9+2/Fq93yeysDWvSHyQ7Kdog5U0hUyKY5i7bPAslL0Blz45C/bFw5L8Fbl7Zm10wFZoDeOo+cPMNZm0EORCorWsCsrg2JQ0D/2DTPYz9gflFgMOF03VSBkKNlM2qI82gkNCn7eIFkFLdvq/qAlqTBSguxI+gZgSXPkX+xiGW0+YWZbdcMSCeufvlVupyZTvJtmpMc6jPc+6DefnnQOYkM2gKH+6p8w== X-YMail-OSG: R9EFJCAVM1kxitRNV_ZMjkqMwbzAEY9wHb6Y9TtrHgXRRigQnvoUg_9YY9ffGuC DtliZbHUCFtJuMm33jNOeplPqYk6HRMB9LYFuj9HcfFG.4Sr2VQs6h9B_RlPUQvT.Uvbrf.jC3Gk WMdAQ0jN8Bzkm1FPyjWBl2M5F4evTzfVSXnNsd.41AMicC2A4RtmfswjAcy58NdCQVxJTbP6eqNa xgQjomeOv3kxKLgzVuvqeHbTlZYVb_lHZcktW.5EVMU9oc5yFwSSX30IGDlkzOzxPXIdzu9QyX96 9TouqgTCCjm2wEVRkAGyPQkFpYNlhUVf92nyEJq2MpngjsH7axLWo1sibLo6W4243gbeB35PbMd7 AQFVZ7JRNNDfe4MsoNkBq45q1o2jFj9SS2y85PvkznFneA6if76JQUzo0TuAteBYtr_umxgbUlLp pqAiqIoB3hhASi17VtJbJPcTe6QhqV6XtcHh9F18D9Whv5sMAAk6UZCm65kb4HaSV4wQKi.e_iFV nyWuZUXIaw0NMaO__r7.8JUEuM3L89r5bXYJ9xb.PS2r8Yul5JHEobbsMkI5YdwNE4YyW.E.wfB5 iblKmZGCttbTGTD3IaVw.CE52BS_k4qMEuVJpJi2OvB5EWlbcLk8VxGmhBElqWWAuEpspoeKIrVh fdZn1Oc6.ehGhfvT3lQGj8sFykHr9Td6xQ9OuH4jKodFi50UxeLfjEiipFPeHpEPRw1HsjFTBdOg hG2eSN5s3lGDl_9G0T.D0NlrRxDeuYiN66bgSaIidCZlP8QxVLzAOk2ueoOwM.sMgg6_arh4XYgk HILWzFhtzZiKc.Nvds_.iwv5gsjhJAJ.3xqfnm5wcA Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.bf2.yahoo.com with HTTP; Tue, 15 Sep 2020 11:35:04 +0000 Original-Received: by smtp423.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 5e16132ebd73cb664c9bbe8f42fb9c75; Tue, 15 Sep 2020 11:35:03 +0000 (UTC) Content-Disposition: inline In-Reply-To: X-Mailer: WebService/1.1.16583 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) Received-SPF: pass client-ip=74.6.132.123; envelope-from=spacibba@aol.com; helo=sonic314-13.consmr.mail.bf2.yahoo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/15 07:35:04 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255734 Archived-At: On Sun, Sep 13, 2020 at 03:02:44PM -0400, Stefan Monnier wrote: >> I want to add this patch to master. Could you give it a look and suggest >> where in NEWS I should mention this? > >Looks very good to me. See below for the nitpicks, > >> diff --git a/lisp/uniquify.el b/lisp/uniquify.el >> index 70e8ecee74..8439d9d874 100644 >> --- a/lisp/uniquify.el >> +++ b/lisp/uniquify.el >> @@ -104,6 +104,13 @@ uniquify-buffer-name-style >> post-forward-angle-brackets name name >> nil name name<2> >> >> +The value can be set to a customized function with two mandatory >> +arguments. For example the current implementation for >> +post-forward-angle-brackets could be: > >You should describe those arguments rather than only tell the number of >args and show an example. E.g. > > The value can be set to a customized function which will be called > two arguments BASE and EXTRA-STRINGS where BASE is a string and > EXTRA-STRINGS is a list of strings. For example the current > implementation for post-forward-angle-brackets could be: > >> +(defun my-post-forward-angle-brackets (base extra-string) >> + (concat base \"<\" (mapconcat 'identity extra-string \"/\") \">\")) > >I'd use #' rather than ' to quote `identity`. > > > Stefan > > There is a new branch feature/uniquify-as-function. I added some documentation too. If it is fine confirm to merge into master.