From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Changes for emacs 28 Date: Sat, 12 Sep 2020 22:03:22 +0200 Message-ID: <20200912200322.gt4zicy4uiagndbr@Ergus> References: <20200910231420.kvqg6ohvxetpup5c@Ergus> <875z8lhz3p.fsf@gmail.com> <83tuw4hkad.fsf@gnu.org> <83tuw4flzy.fsf@gnu.org> <83r1r8fkbn.fsf@gnu.org> <87imckb8dm.fsf@gmail.com> <878sdevofl.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24735"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Robert Pluim , Eli Zaretskii , rekado@elephly.net, ghe@sdf.org, drew.adams@oracle.com, emacs-devel@gnu.org To: Caio Henrique Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 12 22:04:06 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHBkk-0006K7-3S for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Sep 2020 22:04:06 +0200 Original-Received: from localhost ([::1]:33462 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHBkj-0006iw-5z for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Sep 2020 16:04:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHBkF-0006KP-2b for emacs-devel@gnu.org; Sat, 12 Sep 2020 16:03:35 -0400 Original-Received: from sonic309-14.consmr.mail.bf2.yahoo.com ([74.6.129.124]:38957) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHBkC-0003SA-EH for emacs-devel@gnu.org; Sat, 12 Sep 2020 16:03:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1599941010; bh=31Brg4X/87NsK3uWiAOONrTTFvkz795L88R07lA7BwQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=p5uLfj1dnJ+d5Irt5OxIubqrmpk8xgnd/s9vAR3Rm73X16/wFak+BrPVodJK74ssImRL1JT3YacITgqrXs1ZE11YmEwE6/rE381i43GJds/CJG0alCaYZjxLmiZX3PspJLsvrhQYrsRovMOQW4tehJCzThoLnaVi9QS/NbdPnhp7Gr/iBxe4/R3oaCL34WI0hhlPQkSRjBen/s2TVXD1ogP7Z5SfjeI57zl4aL1Q2GMDieUFjwVnqH8S2HMJQ363mtSItfWk5VEuN13AlvVSyrKOWDTRZ4iiIiklccvAKt+red+j73Ig/Ilvs/3EbSfFamfwecK7UliASkRrfEZ4dg== X-YMail-OSG: VjhTYH0VM1lJoZjIK_l2.LJFI78u9Fjr3Df7CAYd7G.q5EKcDAPDj728g.q5Z1w eQ8y6sdKBKozCWuW4WJGtx0Ro373LVwClnxK.rCdlOmUjvPpSoClbxZfAIlFnSRRBWETC6TQ8Sx2 df2E1gfTBWCB3u.r_FXmAP_jj_blrlepMEiYrjG87zFSL_ZgG4H05yRJXwvSObfvn_aOMUpPtYdj VOHlCWjtFGG8CjObEXg6BYi42PTdgCFVknHRq7Ek8fPHAeyDwcroYZN9dcsQVp1vdP2A5UjHEtOy J2anEDrCtDxbJxYjAB7bUR4MHOGdlB1vqpuB1ExXntY1d.a2lOTEVuyhEd.tqrdM2eNMUSMf6G5S b5RsInthb6yojO8ZBrJQDvXLEiYf9lUyYQZ2sJfd03jN9hY_KDkjsujMOg4du_L_BwZ1hHqmTjJk En2iFUVUzi.SwVf75y8sdV_p2ght8OqeP6rVEly4VTwGmcmU8l63yYs5O4m6udDomOa.aSv83SrD _h6j1m5ync4lT7QDFZwHeRk_UCjLbmRaSIzetrEGcvJMEdTXlKTrJsHqUButv598kxmkzVB7KMsE aC3M.e97vV.iEr2VVlJoHUNANYwmXhi2OmYDPal63C3FYEMI3nHiZP32d5tNl6xHaL1cOLVZ.XHp 1U2ThX1KrOC9IAo8NgMCIMNKdlD8rUyGPJtp591cYyiv2EgLRLsV7NMaYFSdQgZFXafXedY3BDE5 lMBRz0qxm8XRQWt5osjwkVhjsCJx4kSnUEv52bRZ9lhmPtS.yn9.axY966YQMIF92wiA2cFPiSuJ lzJ4cDpn28p0lePNdSjGa9u3GB7HpEKRenngKWJgSu Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.bf2.yahoo.com with HTTP; Sat, 12 Sep 2020 20:03:30 +0000 Original-Received: by smtp412.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 2dcd51fef6310e3acf276c6684dccb97; Sat, 12 Sep 2020 20:03:27 +0000 (UTC) Content-Disposition: inline In-Reply-To: <878sdevofl.fsf@gmail.com> X-Mailer: WebService/1.1.16583 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) Received-SPF: pass client-ip=74.6.129.124; envelope-from=spacibba@aol.com; helo=sonic309-14.consmr.mail.bf2.yahoo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/12 16:03:31 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255404 Archived-At: On Sat, Sep 12, 2020 at 03:29:34PM -0300, Caio Henrique wrote: >Robert Pluim writes: > > > >I believe that this is a bug (see the images attached comparing before >and after this patch). > >_____ >diff --git a/lisp/tool-bar.el b/lisp/tool-bar.el >index 7df1e28e06..bec45c1ea4 100644 >--- a/lisp/tool-bar.el >+++ b/lisp/tool-bar.el >@@ -256,9 +256,9 @@ tool-bar-setup > (tool-bar-add-item-from-menu 'dired "diropen" nil :vert-only t) > (tool-bar-add-item-from-menu 'kill-this-buffer "close" nil :vert-only t) > (tool-bar-add-item-from-menu 'save-buffer "save" nil >- :label "Save") >+ :label "Save" :vert-only t) > (define-key-after (default-value 'tool-bar-map) [separator-1] menu-bar-separator) >- (tool-bar-add-item-from-menu 'undo "undo" nil) >+ (tool-bar-add-item-from-menu 'undo "undo" nil :vert-only t) > (define-key-after (default-value 'tool-bar-map) [separator-2] menu-bar-separator) > (tool-bar-add-item-from-menu (lookup-key menu-bar-edit-menu [cut]) > "cut" nil :vert-only t) >_____ > > Why you think it is a bug? :vert-only means exactly what I see.