From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: 68033285 * .gitlab-ci.yml (test-all): Run only when needed. Date: Mon, 31 Aug 2020 10:23:48 +0200 (CEST) Message-ID: <20200831082345.GD65922@breton.holly.idiocy.org> References: <20200830192159.GC65922@breton.holly.idiocy.org> <8736435mb9.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32762"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs-Devel To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 31 10:24:34 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kCf7A-0008QS-OF for ged-emacs-devel@m.gmane-mx.org; Mon, 31 Aug 2020 10:24:32 +0200 Original-Received: from localhost ([::1]:36132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCf79-0007Mw-PX for ged-emacs-devel@m.gmane-mx.org; Mon, 31 Aug 2020 04:24:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40366) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCf6Z-0006Xc-Ch for emacs-devel@gnu.org; Mon, 31 Aug 2020 04:23:55 -0400 Original-Received: from mailout-l3b-97.contactoffice.com ([212.3.242.97]:49214) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCf6X-00059P-G6 for emacs-devel@gnu.org; Mon, 31 Aug 2020 04:23:55 -0400 Original-Received: from smtpauth1.co-bxl (smtpauth1.co-bxl [10.2.0.15]) by mailout-l3b-97.contactoffice.com (Postfix) with ESMTP id 500CC3B4; Mon, 31 Aug 2020 10:23:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1598862230; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To; l=1238; bh=Af25C0ciOCsJxO7rt7QeNgPYbAn+OMTLQizgayCL5ZE=; b=HZ11Wm5zvIwrg/z4PqnhxZmnEws6CdV547XuFwPD5kvSXsy2pxKzePARlQNR4ktX b/EvYRkDQ7w6qpy/VeIhhp21N4hj9lWDhsPrkcnV4WNLlJ+4EsaeJP1U8+HMNuSZMqX lpxv93f9+xgAd+w/trZ3Dx/VeOTXUVNrf6eaU4iSotN2pr6W8SarETzz0aR3RjD5tah zRLpUfEfa90286pUBWCQa0FHgmEgTKtU6Eyu7oj9SAj3tk9rNCaC5z3PMiwY2DV38kf SOP1KVHduKlP+oWMqpomPES2k2NxUI2uiCqBDOmiQWkJvHnnt5B9WTCbkXHsRXKRQfH yvx+s8dNyg== Original-Received: by smtp.mailfence.com with ESMTPA ; Mon, 31 Aug 2020 10:23:47 +0200 (CEST) Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 57FA5202504A13; Mon, 31 Aug 2020 09:23:45 +0100 (BST) Mail-Followup-To: Alan Third , Michael Albinus , Emacs-Devel Content-Disposition: inline In-Reply-To: <8736435mb9.fsf@gmx.de> X-ContactOffice-Account: com:241649512 Received-SPF: pass client-ip=212.3.242.97; envelope-from=alan@idiocy.org; helo=mailout-l3b-97.contactoffice.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/31 04:23:50 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:254438 Archived-At: On Mon, Aug 31, 2020 at 09:03:38AM +0200, Michael Albinus wrote: > Alan Third writes: > > I think you may have made a copy/paste mistake with the wildcards in > > this commit. > > > > "- src/*.{h,m}" means any file with a .h or .m extension but I guess > > you intended src/*.{h,c}. There are a lot more types of files in src/, > > though, so I don't know if it should just be src/*? > > There aren't so many files except *.c and *.h which matter. But these > other files are changed not very often, so it might be OK. > > OTOH, I don't know what happens if a file is matched in both > only/changes due to src/*, and in except/changes due to src/ns*.{h,m}. Yes, I'm not sure either. I've gone with {h,c}. > > Since we're now excluding the test-all job from running when NS .m > > files are updated, should we add make check to the end of the > > test-gnustep job? > > Fine with me. Does a gnustep Emacs build runs also in a Debian environment? Yes, although since the test environment is headless it will just be running in -nw mode, I guess? I've left this out for now. We can see how the changes to the only and except sections work and decide if we need to add it later. -- Alan Third