* Issue building master
[not found] <20200825001901.sjmpwyjwn62bsizh.ref@Ergus>
@ 2020-08-25 0:19 ` Ergus
2020-08-25 6:17 ` Eli Zaretskii
2020-08-25 13:39 ` Stefan Monnier
0 siblings, 2 replies; 17+ messages in thread
From: Ergus @ 2020-08-25 0:19 UTC (permalink / raw)
To: emacs-devel
Hi:
I am trying to build the master branch and I am getting this error:
make[2]: Leaving directory '/mnt/almacen/repo/gits/emacs/build_arch/admin/charsets'
CC xdisp.o
CC gtkutil.o
CC coding.o
CC dbusbind.o
../../src/xdisp.c: In function ‘char_can_wrap_before’:
../../src/xdisp.c:541:8: error: ‘Vword_wrap_by_category’ undeclared (first use in this function)
541 | if (!Vword_wrap_by_category)
| ^~~~~~~~~~~~~~~~~~~~~~
../../src/xdisp.c:541:8: note: each undeclared identifier is reported only once for each function it appears in
../../src/xdisp.c: In function ‘char_can_wrap_after’:
../../src/xdisp.c:563:8: error: ‘Vword_wrap_by_category’ undeclared (first use in this function)
563 | if (!Vword_wrap_by_category)
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from ../../src/xdisp.c:439:
../../src/xdisp.c: In function ‘syms_of_xdisp’:
../../src/lisp.h:3094:33: error: ‘struct emacs_globals’ has no member named ‘f_Vword_wrap_by_category’
3094 | = {Lisp_Fwd_Bool, &globals.f_##vname}; \
| ^
../../src/xdisp.c:34775:3: note: in expansion of macro ‘DEFVAR_BOOL’
34775 | DEFVAR_BOOL("word-wrap-by-category", Vword_wrap_by_category, doc: /*
| ^~~~~~~~~~~
../../src/xdisp.c:34790:3: error: ‘Vword_wrap_by_category’ undeclared (first use in this function)
34790 | Vword_wrap_by_category = false;
| ^~~~~~~~~~~~~~~~~~~~~~
CC keyboard.o
CC macros.o
make[1]: *** [Makefile:401: xdisp.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/mnt/almacen/repo/gits/emacs/build_arch/src'
make: *** [Makefile:424: src] Error 2
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Issue building master
2020-08-25 0:19 ` Issue building master Ergus
@ 2020-08-25 6:17 ` Eli Zaretskii
2020-08-25 7:23 ` Ergus
2020-08-25 13:39 ` Stefan Monnier
1 sibling, 1 reply; 17+ messages in thread
From: Eli Zaretskii @ 2020-08-25 6:17 UTC (permalink / raw)
To: Ergus; +Cc: emacs-devel
> Date: Tue, 25 Aug 2020 02:19:01 +0200
> From: Ergus <spacibba@aol.com>
>
> I am trying to build the master branch and I am getting this error:
>
> make[2]: Leaving directory '/mnt/almacen/repo/gits/emacs/build_arch/admin/charsets'
> CC xdisp.o
> CC gtkutil.o
> CC coding.o
> CC dbusbind.o
> ../../src/xdisp.c: In function ‘char_can_wrap_before’:
> ../../src/xdisp.c:541:8: error: ‘Vword_wrap_by_category’ undeclared (first use in this function)
> 541 | if (!Vword_wrap_by_category)
> | ^~~~~~~~~~~~~~~~~~~~~~
> ../../src/xdisp.c:541:8: note: each undeclared identifier is reported only once for each function it appears in
Something is wrong with regenerating globals.h (which should happen as
part of the build). I have no idea why this happens in your case.
Perhaps because you seem to be building outside of the source tree?
Or because there's a stale globals.h somewhere? Try "make distclean"
first.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Issue building master
2020-08-25 6:17 ` Eli Zaretskii
@ 2020-08-25 7:23 ` Ergus
2020-08-25 7:28 ` Eli Zaretskii
0 siblings, 1 reply; 17+ messages in thread
From: Ergus @ 2020-08-25 7:23 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
On Tue, Aug 25, 2020 at 09:17:17AM +0300, Eli Zaretskii wrote:
>> Date: Tue, 25 Aug 2020 02:19:01 +0200
>> From: Ergus <spacibba@aol.com>
>>
>> I am trying to build the master branch and I am getting this error:
>>
>> make[2]: Leaving directory '/mnt/almacen/repo/gits/emacs/build_arch/admin/charsets'
>> CC xdisp.o
>> CC gtkutil.o
>> CC coding.o
>> CC dbusbind.o
>> ../../src/xdisp.c: In function ???char_can_wrap_before???:
>> ../../src/xdisp.c:541:8: error: ???Vword_wrap_by_category??? undeclared (first use in this function)
>> 541 | if (!Vword_wrap_by_category)
>> | ^~~~~~~~~~~~~~~~~~~~~~
>> ../../src/xdisp.c:541:8: note: each undeclared identifier is reported only once for each function it appears in
>
>Something is wrong with regenerating globals.h (which should happen as
>part of the build). I have no idea why this happens in your case.
>Perhaps because you seem to be building outside of the source tree?
>Or because there's a stale globals.h somewhere? Try "make distclean"
>first.
>
Hi Eli:
This solved the issue very thanks.
BTW when emacs was loading in: dump mode: nil mode
Many commands were failing here and there; one specially recurrent was
with an error in `load-history-filename-element` telling: wrong argument
type stringp (require 'something).
Is this "normal"?
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Issue building master
2020-08-25 7:23 ` Ergus
@ 2020-08-25 7:28 ` Eli Zaretskii
2020-08-25 17:58 ` Ergus
0 siblings, 1 reply; 17+ messages in thread
From: Eli Zaretskii @ 2020-08-25 7:28 UTC (permalink / raw)
To: Ergus; +Cc: emacs-devel
> Date: Tue, 25 Aug 2020 09:23:18 +0200
> From: Ergus <spacibba@aol.com>
> Cc: emacs-devel@gnu.org
>
> BTW when emacs was loading in: dump mode: nil mode
>
> Many commands were failing here and there; one specially recurrent was
> with an error in `load-history-filename-element` telling: wrong argument
> type stringp (require 'something).
>
> Is this "normal"?
What is "dump mode: nil mode"? where did you see this?
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Issue building master
2020-08-25 7:28 ` Eli Zaretskii
@ 2020-08-25 17:58 ` Ergus
2020-08-25 18:24 ` Eli Zaretskii
0 siblings, 1 reply; 17+ messages in thread
From: Ergus @ 2020-08-25 17:58 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
On Tue, Aug 25, 2020 at 10:28:52AM +0300, Eli Zaretskii wrote:
>> Date: Tue, 25 Aug 2020 09:23:18 +0200
>> From: Ergus <spacibba@aol.com>
>> Cc: emacs-devel@gnu.org
>>
>> BTW when emacs was loading in: dump mode: nil mode
>>
>> Many commands were failing here and there; one specially recurrent was
>> with an error in `load-history-filename-element` telling: wrong argument
>> type stringp (require 'something).
>>
>> Is this "normal"?
>
>What is "dump mode: nil mode"? where did you see this?
>
I already had this issue some time ago but yesterday it came back
again.
This message appear in the top of the Messages buffer when emacs can't
find the dump file (usually after a compilation issue like this if I
make bootstrap but not distclean). Then emacs loads all the packages
after that message which takes some time.
Stefan reported a similar issue about the problem of finding the
dump. And of course we shouldn't be using that mode but I won't expect
an error like that in load-history-filename-element.
Best,
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Issue building master
2020-08-25 17:58 ` Ergus
@ 2020-08-25 18:24 ` Eli Zaretskii
0 siblings, 0 replies; 17+ messages in thread
From: Eli Zaretskii @ 2020-08-25 18:24 UTC (permalink / raw)
To: Ergus; +Cc: emacs-devel
> Date: Tue, 25 Aug 2020 19:58:03 +0200
> From: Ergus <spacibba@aol.com>
> Cc: emacs-devel@gnu.org
>
> >> Is this "normal"?
> >
> >What is "dump mode: nil mode"? where did you see this?
> >
> I already had this issue some time ago but yesterday it came back
> again.
>
> This message appear in the top of the Messages buffer when emacs can't
> find the dump file (usually after a compilation issue like this if I
> make bootstrap but not distclean). Then emacs loads all the packages
> after that message which takes some time.
This shouldn't happen, so perhaps there's a bug in one of the clean
targets in the Makefile: I guess it deletes the .pdmp file, but leaves
the executable.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Issue building master
2020-08-25 0:19 ` Issue building master Ergus
2020-08-25 6:17 ` Eli Zaretskii
@ 2020-08-25 13:39 ` Stefan Monnier
1 sibling, 0 replies; 17+ messages in thread
From: Stefan Monnier @ 2020-08-25 13:39 UTC (permalink / raw)
To: emacs-devel
> 34775 | DEFVAR_BOOL("word-wrap-by-category", Vword_wrap_by_category, doc: /*
BTW, our convention is to use V<foo> for Lisp_Object variables exposed
to Lisp, not for bool variables exposed to Lisp, so the name should
likely lose the `V`.
Stefan
^ permalink raw reply [flat|nested] 17+ messages in thread
[parent not found: <20210227201948.bpdla6ogrkdahvna.ref@Ergus>]
* Issue building master
[not found] <20210227201948.bpdla6ogrkdahvna.ref@Ergus>
@ 2021-02-27 20:19 ` Ergus
2021-02-27 22:18 ` Michael Heerdegen
0 siblings, 1 reply; 17+ messages in thread
From: Ergus @ 2021-02-27 20:19 UTC (permalink / raw)
To: help-gnu-emacs
Hi:
I am building master today and I get this error:
```
make[2]: Entering directory '/mnt/almacen/repo/gits/emacs/build_arch/doc/misc'
GEN ../../../doc/misc/modus-themes.texi
File ‘../../../doc/misc/modus-themes.org’ not readable
make[2]: *** [Makefile:245: ../../../doc/misc/modus-themes.texi] Error 1
```
I already rebuilt the bootstrap and the usual fixes; but that didn't
solve the issue.
Any idea?
Best,
Ergus
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Issue building master
2021-02-27 20:19 ` Ergus
@ 2021-02-27 22:18 ` Michael Heerdegen
2021-02-28 5:33 ` Ergus
0 siblings, 1 reply; 17+ messages in thread
From: Michael Heerdegen @ 2021-02-27 22:18 UTC (permalink / raw)
To: help-gnu-emacs
Ergus <spacibba@aol.com> writes:
> Hi:
>
> I am building master today and I get this error:
>
> ```
> make[2]: Entering directory
> '/mnt/almacen/repo/gits/emacs/build_arch/doc/misc'
> GEN ../../../doc/misc/modus-themes.texi
> File ‘../../../doc/misc/modus-themes.org’ not readable
> make[2]: *** [Makefile:245: ../../../doc/misc/modus-themes.texi] Error 1
> ```
Worked for me some minutes ago. There have been changes to the Makefile
only minutes and hours ago. Maybe it is fixed meanwhile?
Michael.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: Issue building master
2021-02-27 22:18 ` Michael Heerdegen
@ 2021-02-28 5:33 ` Ergus
0 siblings, 0 replies; 17+ messages in thread
From: Ergus @ 2021-02-28 5:33 UTC (permalink / raw)
To: Michael Heerdegen; +Cc: help-gnu-emacs
On Sat, Feb 27, 2021 at 11:18:09PM +0100, Michael Heerdegen wrote:
>Ergus <spacibba@aol.com> writes:
>
>> Hi:
>>
>> I am building master today and I get this error:
>>
>> ```
>> make[2]: Entering directory
>> '/mnt/almacen/repo/gits/emacs/build_arch/doc/misc'
>> GEN ../../../doc/misc/modus-themes.texi
>> File ‘../../../doc/misc/modus-themes.org’ not readable
>> make[2]: *** [Makefile:245: ../../../doc/misc/modus-themes.texi] Error 1
>> ```
>
>Worked for me some minutes ago. There have been changes to the Makefile
>only minutes and hours ago. Maybe it is fixed meanwhile?
>
>Michael.
>
Yes seems to be fixed now. Thanks
^ permalink raw reply [flat|nested] 17+ messages in thread
* `cl-macs' [was: about keysee]
@ 2022-12-11 17:09 Drew Adams
2022-12-11 17:35 ` Stefan Monnier
0 siblings, 1 reply; 17+ messages in thread
From: Drew Adams @ 2022-12-11 17:09 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 'Help-Gnu-Emacs (help-gnu-emacs@gnu.org)'
[-- Attachment #1: Type: text/plain, Size: 2117 bytes --]
> >> For that, you can just use `M-x load-library' to load
> >> `cl-macs.el' and `M-x load-file to load `sortie.el'
> >> and then `keysee.el'.
>
> You should never need to load/require explicitly `cl-macs`.
> Instead you should load/require `cl-lib` (which will then load cl-macs
> and other parts of cl-lib as/when needed).
> If you need to manually load `cl-macs` there's probably a bug somewhere.
`cl-macs' is autoloaded by `cl-lib'/`cl-loaddefs'.
So you don't need to load it explicitly if you
instead load `cl-lib'. Of course.
But there's no need to load `cl-lib' or `cl', if
all you want is a macro from `cl-macs'. Keysee
uses just 2 macros, nothing else from `cl*', and
both are in `cl-macs'.
Occam says "Just pull in what you really need."
(Same thing applies to a function definition,
but macros are often needed only when compiling,
in which case requiring them only at compile
time doesn't add libraries to your session.)
It's not about _needing_ to load `cl-macs'. It's
about needing _only_ `cl-macs', and _not_ all of
`cl-lib'. (And for older Emacs, not all of `cl'.)
If you just need a macro then you just need to
load the file that defines it (unless the macro
definition needs some other file, of course).
Or to use your language, "You should never need to
load/require explicitly" cl-lib if all you need is
available from just cl-macs. No?
Why should using `keysee' require you to also add
`cl-lib' to your session? That's overreach. I'd
sooner code without using something as simple as
`cl-case' than oblige someone to load `cl-lib'
just because I've used `cl-case'.
[And yes, things like `case' should just be part
of Emacs (just as `push' is). And yes, `pcase'
is overkill for the simple variable-value case.]
[Plus, things have changed in `cl*' world over the
years. What's there, and where, for older Emacs
can differ from what's there, and where, for more
recent releases. Libraries that are usable with
multiple releases don't necessarily follow a "do
this" injunction that makes sense only for some
later releases.]
[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 13677 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: `cl-macs' [was: about keysee]
2022-12-11 17:09 `cl-macs' [was: about keysee] Drew Adams
@ 2022-12-11 17:35 ` Stefan Monnier
2022-12-11 21:35 ` [External] : " Drew Adams
0 siblings, 1 reply; 17+ messages in thread
From: Stefan Monnier @ 2022-12-11 17:35 UTC (permalink / raw)
To: Drew Adams; +Cc: 'Help-Gnu-Emacs (help-gnu-emacs@gnu.org)'
> Why should using `keysee' require you to also add
> `cl-lib' to your session? That's overreach. I'd
Requiring `cl-macs` won't help you there, because the first thing
`cl-macs` does is (require 'cl-lib). Instead you want
(eval-when-compile (require 'cl-lib))
> [Plus, things have changed in `cl*' world over the
> years. What's there, and where, for older Emacs
> can differ from what's there, and where, for more
> recent releases. Libraries that are usable with
> multiple releases don't necessarily follow a "do
> this" injunction that makes sense only for some
> later releases.]
That's exactly why you should require `cl-lib` rather than `cl-macs`:
because things can move between the different files of `cl-lib`.
Stefan
^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: [External] : Re: `cl-macs' [was: about keysee]
2022-12-11 17:35 ` Stefan Monnier
@ 2022-12-11 21:35 ` Drew Adams
2022-12-12 0:05 ` Issue building master Ergus via Users list for the GNU Emacs text editor
0 siblings, 1 reply; 17+ messages in thread
From: Drew Adams @ 2022-12-11 21:35 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 'Help-Gnu-Emacs (help-gnu-emacs@gnu.org)'
> Requiring `cl-macs` won't help you there, because the
> first thing `cl-macs` does is (require 'cl-lib).
Ah, darn, so it does; too bad. But thanks.
> Instead you want (eval-when-compile (require 'cl-lib))
Normally I do use eval-when-compile, in particular for
a macros file. I don't recall why I didn't do it here,
for `cl-macs'.
Anyway it turns out that's insufficient, because I also
use `cl-remove-if', which is in `cl-seq'. Just picking
up `cl-lib' at compile time leaves that undefined.
(No doubt loading `cl-macs' at runtime took care of
`cl-remove-if' because it was loading `cl-lib', though I
likely wasn't aware of that.)
And `cl-seq' also requires `cl-lib'. So I might as well
just require `cl-lib' at runtime. That has the same
effect as what I've been doing all along (requiring
`cl-macs'). Anyway, I've made that change now.
Too bad - looks like there's no easy way to load just
the parts of `cl*' that are actually needed - separation
into different files provides no such benefit apparently.
> > [Plus, things have changed in `cl*' world over the
> > years. What's there, and where, for older Emacs
> > can differ from what's there, and where, for more
> > recent releases. Libraries that are usable with
> > multiple releases don't necessarily follow a "do
> > this" injunction that makes sense only for some
> > later releases.]
>
> That's exactly why you should require `cl-lib` rather than `cl-macs`:
> because things can move between the different files of `cl-lib`.
It's not just about changes within the `cl-lib' circus.
Some of my libraries are compatible back to earlier
releases that predate `cl-lib' (added in Emacs 23).
And `cl-macs' does still contain the macros.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Issue building master
2022-12-11 21:35 ` [External] : " Drew Adams
@ 2022-12-12 0:05 ` Ergus via Users list for the GNU Emacs text editor
0 siblings, 0 replies; 17+ messages in thread
From: Ergus via Users list for the GNU Emacs text editor @ 2022-12-12 0:05 UTC (permalink / raw)
To: 'Help-Gnu-Emacs (help-gnu-emacs@gnu.org)'
Hi:
I just build master and I am getting this error in -nw:
Symbol's function definition is void: internal-echo-keystrokes-prefix
and this in gui:
Loading loadup.el (source)...Dump mode: nilUsing load-path (/home/ergo/.local/share/emacs/30.0.50/lisp /home/ergo/.local/share/emacs/30.0.50/lisp/emacs-lisp /home/ergo/.local/share/emacs/30.0.50/lisp/progmodes /home/ergo/.local/share/emacs/30.0.50/lisp/language /home/ergo/.local/share/emacs/30.0.50/lisp/international /home/ergo/.local/share/emacs/30.0.50/lisp/textmodes /home/ergo/.local/share/emacs/30.0.50/lisp/vc)Loading emacs-lisp/debug-early...Symbol's function definition is void: file-name-sans-extension
I tried the ussual: make extraclean, make bootstrap and the issue persists... Any other advise??
Thanks in advance, Ergus
^ permalink raw reply [flat|nested] 17+ messages in thread
[parent not found: <167080778504.14972.16819452979975432761@vcs2.savannah.gnu.org>]
end of thread, other threads:[~2022-12-12 17:16 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200825001901.sjmpwyjwn62bsizh.ref@Ergus>
2020-08-25 0:19 ` Issue building master Ergus
2020-08-25 6:17 ` Eli Zaretskii
2020-08-25 7:23 ` Ergus
2020-08-25 7:28 ` Eli Zaretskii
2020-08-25 17:58 ` Ergus
2020-08-25 18:24 ` Eli Zaretskii
2020-08-25 13:39 ` Stefan Monnier
[not found] <20210227201948.bpdla6ogrkdahvna.ref@Ergus>
2021-02-27 20:19 ` Ergus
2021-02-27 22:18 ` Michael Heerdegen
2021-02-28 5:33 ` Ergus
2022-12-11 17:09 `cl-macs' [was: about keysee] Drew Adams
2022-12-11 17:35 ` Stefan Monnier
2022-12-11 21:35 ` [External] : " Drew Adams
2022-12-12 0:05 ` Issue building master Ergus via Users list for the GNU Emacs text editor
[not found] <167080778504.14972.16819452979975432761@vcs2.savannah.gnu.org>
[not found] ` <20221212011625.58E8AC004B4@vcs2.savannah.gnu.org>
2022-12-12 2:41 ` emacs-29 b8d2ec920f: Revert "Improve last change to xfaces.c" (05ece1eb8b) Po Lu
2022-12-12 2:48 ` Po Lu
2022-12-12 9:09 ` Gregory Heytings
2022-12-12 9:37 ` Issue building master Ergus
2022-12-12 13:33 ` Eli Zaretskii
[not found] ` <2127787931.394320.1670853418624@mail.yahoo.com>
2022-12-12 14:12 ` Eli Zaretskii
2022-12-12 15:49 ` Ergus
2022-12-12 16:04 ` Eli Zaretskii
2022-12-12 17:16 ` Ergus
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.