From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Herbert J. Skuhra" Newsgroups: gmane.emacs.devel Subject: Re: master 6e70b37: When decrypting non-decrypted files, make epa show the raw files Date: Mon, 24 Aug 2020 11:16:00 +0200 Message-ID: <20200824091600.GA42401@mail.bsd4all.net> References: <20200804194302.9117.35185@vcs0.savannah.gnu.org> <20200804194304.43835209B0@vcs0.savannah.gnu.org> <87k0xpytfg.wl-herbert@gojira.at> <20200823213651.GA73398@mail.bsd4all.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13025"; mail-complaints-to="usenet@ciao.gmane.io" Cc: spwhitton@spwhitton.name To: emacs-devel@gnu.org, Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 24 11:18:45 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kA8cm-0003C8-Gl for ged-emacs-devel@m.gmane-mx.org; Mon, 24 Aug 2020 11:18:44 +0200 Original-Received: from localhost ([::1]:40496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kA8cl-0004X9-DX for ged-emacs-devel@m.gmane-mx.org; Mon, 24 Aug 2020 05:18:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kA8aE-0003dH-A8 for emacs-devel@gnu.org; Mon, 24 Aug 2020 05:16:06 -0400 Original-Received: from mail.bsd4all.net ([2a01:4f8:13b:240c::25]:58179) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kA8aB-00010e-FC for emacs-devel@gnu.org; Mon, 24 Aug 2020 05:16:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=gojira.at; s=mail202005; t=1598260560; bh=veb1VWkN6j7PAszD/phC8tCsDGDq+ycVeAK3rJWWJi0=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type; b=E7Ij05IlJWSfHuKDu7N36R2lRF67wgIRW1m3oAYtXlXzWBBy97vT9U6XEeI/vG6Dd hhzWjg8+KrvlcIMWW6NcQeoHgWFlNI0awYzXdCvDq/dOlPxQeYuIP0y7DuEjN2rL1d B6/GJcXCGO5GcMbov2UjqPVmuUTSPcPwqY/3u1+Yx+vDZxBqgcDqTsHEvypNx5xfFg s6jsWpZBCjK30rRxcen+I6xowM6GRKyd6out9kF0ZfgA6IQQhY3GgC8umxp2cEWR5X 3pHxWJ1SYXn3UkIpRYOOfP4jgLkoP0nMCgz3/mCUJeHxp3nOoy60gqV7vWXgJT6y4e UJNg8+aInM1xw== Content-Disposition: inline In-Reply-To: <20200823213651.GA73398@mail.bsd4all.net> Received-SPF: pass client-ip=2a01:4f8:13b:240c::25; envelope-from=herbert@gojira.at; helo=mail.bsd4all.net X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:254174 Archived-At: On Sun, Aug 23, 2020 at 11:36:51PM +0200, Herbert J. Skuhra wrote: > On Sun, Aug 23, 2020 at 10:54:27PM +0200, Herbert J. Skuhra wrote: > > On Tue, 04 Aug 2020 21:43:03 +0200, larsi@gnus.org wrote: > > > > > > branch: master > > > commit 6e70b3793b9cb7730ab8a7132aa6e99f1ca13f98 > > > Author: Lars Ingebrigtsen > > > Commit: Lars Ingebrigtsen > > > > > > When decrypting non-decrypted files, make epa show the raw files > > > > > > * lisp/epa-file.el (epa-file-insert-file-contents): When trying to > > > decrypt a non-decrypted file, just show the bytes from the file > > > instead (bug#3829). > > > > After this commit running 'C-x C-f ~/newfile.gpg' produces an error: > > > > epa-file-insert-file-contents: Wrong type argument: char-or-string-p, nil > > > > Debugger entered--Lisp error: (wrong-type-argument char-or-string-p nil) > > epa-file-decode-and-insert(nil "/home/herbert/newfile.gpg" t nil nil nil) > > epa-file-insert-file-contents("/home/herbert/newfile.gpg" t nil nil nil) > > apply(epa-file-insert-file-contents ("/home/herbert/newfile.gpg" t nil nil nil)) > > epa-file-handler(insert-file-contents "/home/herbert/newfile.gpg" t nil nil nil) > > insert-file-contents("~/newfile.gpg" t) > > find-file-noselect-1(# "~/newfile.gpg" nil nil "~/newfile.gpg" nil) > > find-file-noselect("~/newfile.gpg" nil nil t) > > find-file("~/newfile.gpg" t) > > funcall-interactively(find-file "~/newfile.gpg" t) > > call-interactively(find-file nil nil) > > command-execute(find-file) > > > > If I run the command 'find-file' again it works. > > But I am not asked to select a gpg key ... only symmetric encryption is > offered! > > There is obviously another bug (but unrelated to this commit): > > If I revert the above commit and try to create and save an encrypted > file I get: > > Select recipients for encryption. > If no one is selected, symmetric encryption will be performed. > - ‘m’ to mark a key on the line > - ‘u’ to unmark a key on the line > [Cancel][OK] > > > How do you proceed with symmetric encryption? Just pressing OK without > selecting a key does not work. The second bug is obviously caused by: commit 7479c11b4e73fcb9aa9d42788012b850ee3245c5 (HEAD) Author: Sean Whitton Date: Fri Jul 24 13:36:39 2020 -0700 -- Herbert