From: Alan Third <alan@idiocy.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 42904@debbugs.gnu.org
Subject: bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS
Date: Tue, 18 Aug 2020 19:28:26 +0200 (CEST) [thread overview]
Message-ID: <20200818172824.GA90575@breton.holly.idiocy.org> (raw)
In-Reply-To: <243A5DA8-2865-485D-A8A2-1F543B046BAA@acm.org>
On Tue, Aug 18, 2020 at 01:48:10PM +0200, Mattias Engdegård wrote:
> 18 aug. 2020 kl. 10.43 skrev Alan Third <alan@idiocy.org>:
> > Anyway, as I understand it the internal representation of NS strings
> > are UTF-16, so the conversion through UTF-8 seems a bit of a waste if
> > we can go direct.
>
> Maybe, but the conversion to UTF-16 then has to be done on the Emacs
> side instead, probably less efficiently than in the NS libs. It's
> probably a wash.
>
> Anyway, here is an alternative patch using your method. Tell us what
> you think.
Looks good to me. The only thought I have is that perhaps we should
consider extending NSString to handle these lisp strings rather than
making it a separate function? We could provide a method to convert to
a lisp string as well, although that's not as complex.
I believe using categories would do it without us having to create a
new EmacsString class or similar.
I don't know if this is worth it because I don't know if we really
need these clean conversions elsewhere, but the neatness of
newStr = [NSString withLispObject:str];
appeals. :)
--
Alan Third
next prev parent reply other threads:[~2020-08-18 17:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 14:11 bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS Mattias Engdegård
2020-08-17 14:54 ` Andrii Kolomoiets
2020-08-17 15:55 ` Mattias Engdegård
2020-08-17 15:55 ` Eli Zaretskii
2020-08-17 16:11 ` Mattias Engdegård
2020-08-17 17:05 ` Eli Zaretskii
2020-08-17 18:48 ` Mattias Engdegård
2020-08-17 19:56 ` Alan Third
2020-08-18 8:07 ` Mattias Engdegård
2020-08-18 8:43 ` Alan Third
2020-08-18 11:48 ` Mattias Engdegård
2020-08-18 12:22 ` Eli Zaretskii
2020-08-18 17:28 ` Alan Third [this message]
2020-08-20 9:27 ` Mattias Engdegård
2020-08-20 13:24 ` Eli Zaretskii
2020-08-20 18:46 ` Mattias Engdegård
2020-08-20 19:13 ` Eli Zaretskii
2020-08-21 9:39 ` Mattias Engdegård
2020-08-21 13:26 ` Eli Zaretskii
2020-08-21 14:53 ` Mattias Engdegård
2020-08-21 15:27 ` Eli Zaretskii
2020-08-21 15:50 ` Mattias Engdegård
2020-08-23 17:23 ` Mattias Engdegård
2020-08-20 13:24 ` Alan Third
2020-08-20 17:44 ` Mattias Engdegård
2020-08-18 12:24 ` Eli Zaretskii
2020-08-18 14:11 ` Mattias Engdegård
2020-08-18 14:40 ` Eli Zaretskii
2020-08-18 15:21 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818172824.GA90575@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=42904@debbugs.gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.