all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ergus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: Tino Calancha <tino.calancha@gmail.com>,
	npostavs@gmail.com, 39512@debbugs.gnu.org, contovob@tcd.ie,
	Lars Ingebrigtsen <larsi@gnus.org>,
	eliz@gnu.org, drew.adams@oracle.com
Subject: bug#39512: 28.0.50; Add command isearch-yank-region
Date: Thu, 13 Aug 2020 05:14:20 +0200	[thread overview]
Message-ID: <20200813031420.7vq5bz7loeqiuntx@Ergus> (raw)
In-Reply-To: <87h7t7ieqe.fsf@mail.linkov.net>

On Thu, Aug 13, 2020 at 02:44:33AM +0300, Juri Linkov wrote:
>
>The problem is that the name of the command bound to 'M-s .' is
>isearch-forward-symbol-at-point that implies that it has to call
>isearch-forward-symbol.  So not using symbol search on the active region
>will make a mess from this command.
>
>A cleaner solution would be to add a new non-symbol command with a name like
>isearch-forward-thing-at-point-or-region bound to 'M-s M-.' and based on
>thing-at-point-or-region.
>
I would prefer using `M-s .` for consistency (even if it requires
changing the command name). In swiper it works like that and it is very
comfortable and consistent with the "expected" experience; but I
understand that someone will complain for sure... (as usual)

So without any other alternative, `M-s M-.` will be good enough. In
general it would be better (for consistency) if we "reserve" `M-.`
"suffixes" for future thing-at-point-or-region commands right?


>In the previous message you sent a link to `ivy-thing-at-point` that
>also uses (thing-at-point 'url) and also tries to get a filename at point.
>Do you think `thing-at-point-or-region` should do the same?

With the interactive experience in mind I think this could make sense as
it does in `ivy-thing-at-point`.

In my opinion from the api point of view, the important modification
could be the method to know the "kind the thing" detected after calling
the function (region, word, symbol, url) but also a function to get the
bounds instead of the text (like bounds-of-thing-at-point-or-region).





  reply	other threads:[~2020-08-13  3:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-08 18:04 bug#39512: 28.0.50; Add command isearch-yank-region Tino Calancha
2020-02-08 23:47 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-02-09  0:31 ` Juri Linkov
2020-02-09 11:21   ` Tino Calancha
2020-02-09 12:38   ` Tino Calancha
2020-02-10  0:45     ` Juri Linkov
2020-02-12 22:10       ` Juri Linkov
2020-08-09 11:28   ` Lars Ingebrigtsen
2020-08-09 23:23     ` Juri Linkov
2020-08-10  1:19       ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-10 23:49         ` Juri Linkov
2020-08-11  1:12           ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-11 23:13             ` Juri Linkov
2020-08-12 17:41               ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-12 23:44                 ` Juri Linkov
2020-08-13  3:14                   ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-04-15 20:52                     ` Juri Linkov
2021-04-18 15:34                       ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-20 20:29                         ` Juri Linkov
2021-04-21 20:41                           ` Juri Linkov
2020-08-10 17:00       ` Tino Calancha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200813031420.7vq5bz7loeqiuntx@Ergus \
    --to=bug-gnu-emacs@gnu.org \
    --cc=39512@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=drew.adams@oracle.com \
    --cc=eliz@gnu.org \
    --cc=juri@linkov.net \
    --cc=larsi@gnus.org \
    --cc=npostavs@gmail.com \
    --cc=spacibba@aol.com \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.