all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jonas Bernoulli <jonas@bernoul.li>
To: 42397@debbugs.gnu.org
Subject: bug#42397: [PATCH v2 14/16] * lisp/font-lock.el: No longer use headings as end of section markers.
Date: Mon, 10 Aug 2020 23:14:28 +0200	[thread overview]
Message-ID: <20200810211430.22502-15-jonas@bernoul.li> (raw)
In-Reply-To: <20200810211430.22502-1-jonas@bernoul.li>

Each section ends right before the following section begins and IMO
that means that it is unnecessary to mark the end of sections.

For users of `outline-minor-mode' the old end-of-section markers were
a distraction.  They made it much harder to parse the overview outline
state because each section heading was followed by a end-of-section
marker that was formatted as a section heading.  Because of this I
wanted to remove the end-of-section markers.

But as Eli pointed out these sections are long and not everyone uses
`outline-minor-mode'.

So instead of removing them, I am turning the end-of-section markers
into regular comments (beginning with just two semicolons) instead of
section headings (beginning with tree semicolons).  That way users of
`outline-minor-mode' won't be distracted by them and others can still
benefit from the markers as before.
---
 lisp/font-lock.el | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/lisp/font-lock.el b/lisp/font-lock.el
index cf88100ab5..c633877e64 100644
--- a/lisp/font-lock.el
+++ b/lisp/font-lock.el
@@ -986,7 +986,7 @@ font-lock-after-unfontify-buffer
 	((bound-and-true-p lazy-lock-mode)
 	 (lazy-lock-after-unfontify-buffer))))
 
-;;; End of Font Lock Support mode.
+;; End of Font Lock Support mode.
 \f
 ;;; Fontification functions.
 
@@ -1393,7 +1393,7 @@ font-lock-fontify-block
 	      (font-lock-fontify-region (point) (mark)))
 	  ((error quit) (message "Fontifying block...%s" error-data)))))))
 
-;;; End of Fontification functions.
+;; End of Fontification functions.
 \f
 ;;; Additional text property functions.
 
@@ -1485,7 +1485,7 @@ font-lock--remove-face-from-text-property
 		      (put-text-property start next prop new object))))))
       (setq start (text-property-not-all next end prop nil object)))))
 
-;;; End of Additional text property functions.
+;; End of Additional text property functions.
 \f
 ;;; Syntactic regexp fontification functions.
 
@@ -1591,7 +1591,7 @@ font-lock-fontify-syntactic-keywords-region
 	  (setq highlights (cdr highlights))))
       (setq keywords (cdr keywords)))))
 
-;;; End of Syntactic regexp fontification functions.
+;; End of Syntactic regexp fontification functions.
 \f
 ;;; Syntactic fontification functions.
 
@@ -1650,7 +1650,7 @@ font-lock-fontify-syntactically-region
         (setq state (parse-partial-sexp (point) end nil nil state
 				        'syntax-table))))))
 
-;;; End of Syntactic fontification functions.
+;; End of Syntactic fontification functions.
 \f
 ;;; Keyword regexp fontification functions.
 
@@ -1784,9 +1784,9 @@ font-lock-fontify-keywords-region
       (setq keywords (cdr keywords)))
     (set-marker pos nil)))
 
-;;; End of Keyword regexp fontification functions.
+;; End of Keyword regexp fontification functions.
 \f
-;; Various functions.
+;;; Various functions.
 
 (defun font-lock-compile-keywords (keywords &optional syntactic-keywords)
   "Compile KEYWORDS into the form (t KEYWORDS COMPILED...)
@@ -2102,7 +2102,7 @@ font-lock-regexp-grouping-construct
   "Font Lock mode face used to highlight grouping constructs in Lisp regexps."
   :group 'font-lock-faces)
 
-;;; End of Color etc. support.
+;; End of Color etc. support.
 \f
 ;;; Menu support.
 
@@ -2204,7 +2204,7 @@ font-lock-regexp-grouping-construct
 ;;  ;; Deactivate less/more fontification entries.
 ;;  (setq font-lock-fontify-level nil))
 
-;;; End of Menu support.
+;; End of Menu support.
 \f
 ;;; Various regexp information shared by several modes.
 ;; ;; Information specific to a single mode should go in its load library.
-- 
2.28.0






  parent reply	other threads:[~2020-08-10 21:14 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16 14:47 bug#42397: [PATCH 00/14] Use outline headings and some cosmetics Jonas Bernoulli
2020-07-16 14:54 ` bug#42397: [PATCH 01/14] ; * lisp/epg.el (epg-signature-to-string): Use cl-case Jonas Bernoulli
2020-07-16 14:54   ` bug#42397: [PATCH 02/14] ; * lisp/epg.el (epg-signature-to-string): Tiny refactor Jonas Bernoulli
2020-07-16 14:54     ` bug#42397: [PATCH 03/14] ; * lisp/epg.el (epg-no-data-reason-alist): Fix typo in message Jonas Bernoulli
2020-07-16 14:54       ` bug#42397: [PATCH 04/14] * lisp/epa.el (epa--derived-mode-p): Remove unnecessary alias Jonas Bernoulli
2020-07-16 14:54         ` bug#42397: [PATCH 05/14] Split EasyPG libraries into outline sections Jonas Bernoulli
2020-07-16 14:54           ` bug#42397: [PATCH 06/14] * lisp/emacs-lisp/eldoc.el (eldoc-minibuffer-message): Fix indentation Jonas Bernoulli
2020-07-16 14:54             ` bug#42397: [PATCH 07/14] * lisp/progmodes/compile.el: Remove unnecessary comments Jonas Bernoulli
2020-07-16 14:54               ` bug#42397: [PATCH 08/14] ; * lisp/whitespace.el: Capitalize "Code" section heading Jonas Bernoulli
2020-07-16 14:54                 ` bug#42397: [PATCH 09/14] * lisp/mail/smtpmail.el: Use outline headings Jonas Bernoulli
2020-07-16 14:54                   ` bug#42397: [PATCH 10/14] * test/src/emacs-module-tests.el: Use proper " Jonas Bernoulli
2020-07-16 14:54                     ` bug#42397: [PATCH 11/14] * lisp/obsolete/longlines.el: " Jonas Bernoulli
2020-07-16 14:54                       ` bug#42397: [PATCH 12/14] * lisp/net/imap.el: " Jonas Bernoulli
2020-07-16 14:54                         ` bug#42397: [PATCH 13/14] * lisp/font-lock.el: Split the Commentary into subsections Jonas Bernoulli
2020-07-16 14:54                           ` bug#42397: [PATCH 14/14] * lisp/font-lock.el: No longer mark each end of a section explicitly Jonas Bernoulli
2020-07-16 15:24                             ` Eli Zaretskii
2020-07-16 15:27             ` bug#42397: [PATCH 06/14] * lisp/emacs-lisp/eldoc.el (eldoc-minibuffer-message): Fix indentation Eli Zaretskii
2020-07-16 16:56               ` Jonas Bernoulli
2020-07-16 17:17                 ` Robert Pluim
2020-07-16 17:54                   ` Jonas Bernoulli
2020-07-16 18:23                     ` Noam Postavsky
2020-07-16 18:40                       ` Jonas Bernoulli
2020-07-16 19:25                 ` Eli Zaretskii
2020-07-16 21:52                   ` Jonas Bernoulli
2020-07-17  3:40                     ` Eli Zaretskii
2020-07-17 18:19                       ` Jonas Bernoulli
2020-07-17 10:49             ` Basil L. Contovounesios
2020-07-17 18:23               ` Jonas Bernoulli
2020-07-16 15:21       ` bug#42397: [PATCH 03/14] ; * lisp/epg.el (epg-no-data-reason-alist): Fix typo in message Eli Zaretskii
2020-07-16 16:57         ` Jonas Bernoulli
2020-07-16 17:24     ` bug#42397: [PATCH 02/14] ; * lisp/epg.el (epg-signature-to-string): Tiny refactor Robert Pluim
2020-07-16 18:03       ` Jonas Bernoulli
2020-07-16 17:22   ` bug#42397: [PATCH 01/14] ; * lisp/epg.el (epg-signature-to-string): Use cl-case Robert Pluim
2020-07-16 17:57     ` Jonas Bernoulli
2020-07-16 15:09 ` bug#42397: This message is a test Jonas Bernoulli
2020-07-16 15:12 ` bug#42397: [PATCH 00/14] Use outline headings and some cosmetics Drew Adams
2020-07-16 15:30   ` Eli Zaretskii
2020-07-16 18:34     ` Jonas Bernoulli
2020-07-17  6:29       ` Eli Zaretskii
2020-08-10 21:14 ` bug#42397: [PATCH v2 00/16] " Jonas Bernoulli
2020-08-10 21:14   ` bug#42397: [PATCH v2 01/16] ; * lisp/epg.el (epg-signature-to-string): Use cl-case Jonas Bernoulli
2020-08-10 21:14   ` bug#42397: [PATCH v2 02/16] ; * lisp/epg.el (epg-signature-to-string): Tiny refactor Jonas Bernoulli
2020-08-10 21:14   ` bug#42397: [PATCH v2 03/16] ; * lisp/epg.el (epg-no-data-reason-alist): Fix typo in message Jonas Bernoulli
2020-08-10 21:14   ` bug#42397: [PATCH v2 04/16] * lisp/epa.el (epa--derived-mode-p): Remove unnecessary alias Jonas Bernoulli
2020-08-10 21:14   ` bug#42397: [PATCH v2 05/16] Split EasyPG libraries into outline sections Jonas Bernoulli
2020-08-10 21:14   ` bug#42397: [PATCH v2 06/16] Merge two conditions and fix indentation Jonas Bernoulli
2020-08-10 21:14   ` bug#42397: [PATCH v2 07/16] * lisp/progmodes/compile.el: Remove unnecessary comments Jonas Bernoulli
2020-08-10 21:14   ` bug#42397: [PATCH v2 08/16] ; * lisp/whitespace.el: Capitalize "Code" section heading Jonas Bernoulli
2020-08-10 21:14   ` bug#42397: [PATCH v2 09/16] * lisp/mail/smtpmail.el: Use outline headings Jonas Bernoulli
2020-08-10 21:14   ` bug#42397: [PATCH v2 10/16] * test/src/emacs-module-tests.el: Use proper " Jonas Bernoulli
2020-08-10 21:14   ` bug#42397: [PATCH v2 11/16] * lisp/obsolete/longlines.el: " Jonas Bernoulli
2020-08-10 21:14   ` bug#42397: [PATCH v2 12/16] * lisp/net/imap.el: " Jonas Bernoulli
2020-08-10 21:14   ` bug#42397: [PATCH v2 13/16] * lisp/font-lock.el: Split the Commentary into subsections Jonas Bernoulli
2020-08-10 21:14   ` Jonas Bernoulli [this message]
2020-08-10 21:14   ` bug#42397: [PATCH v2 15/16] ; * lisp/emacs-lisp/autoload.el: Begin summary line with three semicolons Jonas Bernoulli
2020-08-10 21:14   ` bug#42397: [PATCH v2 16/16] Update section heading conventions for libraries Jonas Bernoulli
2020-08-12 16:54     ` Eli Zaretskii
2020-08-16 18:43 ` bug#42397: [PATCH 00/14] Use outline headings and some cosmetics Jonas Bernoulli
2020-08-16 19:29   ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200810211430.22502-15-jonas@bernoul.li \
    --to=jonas@bernoul.li \
    --cc=42397@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.