all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jonas Bernoulli <jonas@bernoul.li>
To: 41276@debbugs.gnu.org
Subject: bug#41276: [PATCH v2 7/8] epa-key-list-mode-map: Use widget-keymap as parent keymap
Date: Tue,  7 Jul 2020 17:47:38 +0200	[thread overview]
Message-ID: <20200707154739.1829-8-jonas@bernoul.li> (raw)
In-Reply-To: <20200707154739.1829-7-jonas@bernoul.li>

Normally when one keymap is to be treated as the parent of another,
then that relationship is setup once at the time when the child is
being defined, i.e. at birth.  For some reason, this was not done
here; instead `widget-keymap' is set as `epa-key-list-mode-map'
parent every time the former is setup to be used as the local map.

This appears to be a mistake.  A few other keymaps use `widget-keymap'
as their parent and in those cases the relationship is established
just once. `epa-key-list-mode-map' is the only exception and because
there is absolutely no indication that that is justified, we remove
this inconsistency.

* lisp/epa.el (epa-key-list-mode-map): Set the parent of this keymap
while defining it.
* lisp/epa.el (epa--list-keys): Do not set the parent of the local
keymap here.
---
 lisp/epa.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/epa.el b/lisp/epa.el
index e4d1e5b414..8f45c667b9 100644
--- a/lisp/epa.el
+++ b/lisp/epa.el
@@ -188,6 +188,7 @@ epa-last-coding-system-specified
 (defvar epa-key-list-mode-map
   (let ((keymap (make-sparse-keymap))
 	(menu-map (make-sparse-keymap)))
+    (set-keymap-parent keymap widget-keymap)
     (define-key keymap "m" 'epa-mark-key)
     (define-key keymap "u" 'epa-unmark-key)
     (define-key keymap "d" 'epa-decrypt-file)
@@ -399,8 +400,7 @@ epa--list-keys
       (goto-char point))
 
     (epa--insert-keys (epg-list-keys context name secret))
-    (widget-setup)
-    (set-keymap-parent (current-local-map) widget-keymap))
+    (widget-setup))
   (make-local-variable 'epa-list-keys-arguments)
   (setq epa-list-keys-arguments (list name secret))
   (goto-char (point-min))
-- 
2.26.0






  reply	other threads:[~2020-07-07 15:47 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14 19:13 bug#41276: [PATCH 0/9] Various small improvements to EasyPG Jonas Bernoulli
2020-05-14 19:13 ` bug#41272: [PATCH 1/9] * lisp/epa.el (epa-faces): Move definition Jonas Bernoulli
2020-05-14 19:13 ` bug#41269: [PATCH 2/9] Add all epa faces to epa-faces Custom group Jonas Bernoulli
2020-05-14 19:13 ` bug#41270: [PATCH 3/9] * lisp/epg-config.el (epg-config--make-gpg-configuration): Fix indentation Jonas Bernoulli
2020-05-14 19:13 ` bug#41275: [PATCH 4/9] Split EasyPG libraries into outline sections Jonas Bernoulli
2020-05-14 19:13 ` bug#41277: [PATCH 5/9] Improve and add doc-strings Jonas Bernoulli
2020-05-14 19:13 ` bug#41268: [PATCH 6/9] Drop unnecessary backward compatibility aliases Jonas Bernoulli
2020-05-14 19:13 ` bug#41271: [PATCH 7/9] Cosmetic changes to epa libraries Jonas Bernoulli
2020-05-14 19:13 ` bug#41273: [PATCH 8/9] epa-key-list-mode-map: Use widget-keymap as parent keymap Jonas Bernoulli
2020-05-14 19:13 ` bug#41274: [PATCH 9/9] * lisp/epa.el (epa-show-key): New command Jonas Bernoulli
2020-06-23 22:57   ` Basil L. Contovounesios
2020-07-07 15:34     ` Jonas Bernoulli
     [not found] ` <handler.41276.B.15894836275636.ack@debbugs.gnu.org>
2020-05-14 20:14   ` bug#41276: Acknowledgement ([PATCH 0/9] Various small improvements to EasyPG) Jonas Bernoulli
2020-05-14 22:33     ` Stefan Kangas
2020-05-15  7:26     ` Eli Zaretskii
2020-05-15 11:27       ` Jonas Bernoulli
2020-05-15 11:52         ` Eli Zaretskii
2020-05-15 16:56           ` Jonas Bernoulli
2020-05-15 17:42             ` Eli Zaretskii
2020-05-15 22:42               ` Jonas Bernoulli
2020-05-16  6:45                 ` Eli Zaretskii
2020-05-14 20:16 ` bug#41276: [PATCH 1/9] * lisp/epa.el (epa-faces): Move definition Jonas Bernoulli
2020-05-14 20:16   ` bug#41276: [PATCH 2/9] Add all epa faces to epa-faces Custom group Jonas Bernoulli
2020-05-15  9:32     ` Robert Pluim
2020-06-23 22:57       ` Basil L. Contovounesios
2020-07-07 15:32         ` Jonas Bernoulli
2020-05-14 20:16   ` bug#41276: [PATCH 3/9] * lisp/epg-config.el (epg-config--make-gpg-configuration): Fix indentation Jonas Bernoulli
2020-05-14 20:16   ` bug#41276: [PATCH 4/9] Split EasyPG libraries into outline sections Jonas Bernoulli
2020-05-14 20:16   ` bug#41276: [PATCH 5/9] Improve and add doc-strings Jonas Bernoulli
2020-05-14 20:16   ` bug#41276: [PATCH 6/9] Drop unnecessary backward compatibility aliases Jonas Bernoulli
2020-05-14 20:16   ` bug#41276: [PATCH 7/9] Cosmetic changes to epa libraries Jonas Bernoulli
2020-05-14 20:16   ` bug#41276: [PATCH 8/9] epa-key-list-mode-map: Use widget-keymap as parent keymap Jonas Bernoulli
2020-05-15  7:27     ` Eli Zaretskii
2020-05-14 20:16   ` bug#41276: [PATCH 9/9] * lisp/epa.el (epa-show-key): New command Jonas Bernoulli
2020-05-14 23:04 ` bug#41276: [PATCH 0/9] Various small improvements to EasyPG Stefan Kangas
2020-05-15  9:26   ` Robert Pluim
2020-05-25  1:34     ` Noam Postavsky
2020-07-17  7:30       ` Robert Pluim
2020-07-07 15:47 ` bug#41276: [PATCH v2 0/8] " Jonas Bernoulli
2020-07-07 15:47   ` bug#41276: [PATCH v2 1/8] * lisp/epa.el (epa-faces): Move definition Jonas Bernoulli
2020-07-07 15:47     ` bug#41276: [PATCH v2 2/8] Add all epa faces to epa-faces Custom group Jonas Bernoulli
2020-07-07 15:47       ` bug#41276: [PATCH v2 3/8] * lisp/epg-config.el (epg-config--make-gpg-configuration): Fix indentation Jonas Bernoulli
2020-07-07 15:47         ` bug#41276: [PATCH v2 4/8] Improve and add doc-strings Jonas Bernoulli
2020-07-07 15:47           ` bug#41276: [PATCH v2 5/8] Drop unnecessary backward compatibility aliases Jonas Bernoulli
2020-07-07 15:47             ` bug#41276: [PATCH v2 6/8] Cosmetic changes to epa libraries Jonas Bernoulli
2020-07-07 15:47               ` Jonas Bernoulli [this message]
2020-07-07 15:47                 ` bug#41276: [PATCH v2 8/8] * lisp/epa.el (epa-show-key): New command Jonas Bernoulli
2020-07-07 18:30   ` bug#41276: [PATCH v2 0/8] Various small improvements to EasyPG Eli Zaretskii
2020-07-07 21:09     ` Jonas Bernoulli
2020-07-08  2:29       ` Eli Zaretskii
2020-07-08 12:08         ` Jonas Bernoulli
2020-07-14 18:09           ` Jonas Bernoulli
2020-07-14 18:16             ` Eli Zaretskii
2020-07-14 18:27               ` Jonas Bernoulli
2020-07-14 18:57                 ` Eli Zaretskii
2020-07-14 20:20                   ` Jonas Bernoulli
2020-07-15  2:22                     ` Eli Zaretskii
2020-08-05 19:03 ` bug#41276: [PATCH 0/9] " Lars Ingebrigtsen
2020-08-06  7:22   ` bug#41268: " Jonas Bernoulli
2020-08-06  7:26     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200707154739.1829-8-jonas@bernoul.li \
    --to=jonas@bernoul.li \
    --cc=41276@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.