From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: vertical fido-mode Date: Thu, 11 Jun 2020 15:03:41 +0200 Message-ID: <20200611130341.zwxcpwtwaxrq2qwm@ergus> References: <87a71apgk2.fsf@penguin> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="124223"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: NeoMutt/20180716 Cc: emacs-devel@gnu.org To: Omar =?utf-8?Q?Antol=C3=ADn?= Camarena Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 11 15:04:47 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jjMsw-000WDJ-Ra for ged-emacs-devel@m.gmane-mx.org; Thu, 11 Jun 2020 15:04:46 +0200 Original-Received: from localhost ([::1]:44156 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jjMsv-0005l9-QO for ged-emacs-devel@m.gmane-mx.org; Thu, 11 Jun 2020 09:04:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjMs3-0003rt-7O for emacs-devel@gnu.org; Thu, 11 Jun 2020 09:03:51 -0400 Original-Received: from sonic317-26.consmr.mail.bf2.yahoo.com ([74.6.129.81]:39310) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jjMs1-0002qQ-9C for emacs-devel@gnu.org; Thu, 11 Jun 2020 09:03:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1591880626; bh=P8JO3jsK5ibWGhNtY6I3o5/tI7AOE5WOocloePJMgs0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=DteHFZgD93oriFfgRxKqBV3VDtNGtv8/ptH2e82fq/K1h5YJnPBE9bfvTrGP5PIM6qrQMv9QpkRTuYmDFkxfxmBLfa6wQF73KNQuxfDhYhvfDlB1xFeMeyosbtzSX/vuNmL7zGrUQ1SAuEjLzhhMzp9npMkEXyHiggwW5rz/3zYucs2lBEQqbJM9saXAHXGqS5FeoKEnNcG8lW5mJ7QENpbdhrF53Yura4ToNDjwNUlcckt7/J3paoa/aOaqmzmmZn5/NfDiUzlB7Smvd0ny2eNxUOn4IvLcsDeRS3E3dlfZtzMRBjFi7sLZAoxUvt1pyqnQWtq5AJ9dcAMKZzR7OA== X-YMail-OSG: HUbs5M0VM1ne4NzIH8SYTc9jRwgfkvvGkrBd4c6O0pcLkUmxpm72TJvhq3IN07B uB_M3kDgwUdgfM.MeLjGEXy.aEls9__LzKV_Mr36ENIljp6QW6GKKy0qFkRyM2LjG_tGGu2Qr6TN 6JvIkmM3K65GnuGBrh4uFZVUXbZIarUqAMZfiY49j9NZ1vHijqBw4WPUgAvWZ3eMUbdu.tlQ1rZA sBp0LEfTEY0pp31yKzvIKMkHNUwjZJrlG3kGvzUDbbT9HWIgpgTRdm7ZjNwImW6p7VgeN5UNHQG3 UQq3YQ2YxA5YT2qBWawLtuH1u_sf0oviLX1VBqEm.UKTi_.oMUX9nERzXE64hSiZEfPEYvOwiOGD 1trEq30ew5_0NwDxFgaa1OG_GLTmDJD77W0J7KgjImE30npQMZo5VdjK4WTQq_qsBbIztE04_WDq Leotn0KJQCpnK6tLc_R1ComjmMAQNjKfPigv8VL5hapfHAKUe0ScfJP4YxcqpyBLf2L.fvhoBeFF lqCHN.imY74b36qt_gZU08NRDLTJfs9D1OATds.IVRrIIMvNBVv_FgPkOrrvKPMeUsZ8LkU3xsSp dFDy56U5aKKS3rpam9.4WPhHfZHadCEj.DSZ2Bk9KDP4w.YhQ3qitqtl3cb3EeTwjEv9IwTIn2N_ xSgul..bAMUwrvIAnN9WKlXZep0SJd6.WAuUfUy0Hrle7PA60Ib7vgFyChJAqpWA4FdkqPIwl1eq CJWmd4Enm1O6Sg1bdILOjao7dxz6mBQkNraDdr_gydfSShgx3vpHMYIhjEZadBzqVgk.ym6Md1qj HGDWNk3mxvaSWHzHlY5bNlnhNr0YGYoW.NLKAKbqTi Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.bf2.yahoo.com with HTTP; Thu, 11 Jun 2020 13:03:46 +0000 Original-Received: by smtp416.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 9f3175871c8490d6bbd69b26c6facd05; Thu, 11 Jun 2020 13:03:44 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87a71apgk2.fsf@penguin> X-Mailer: WebService/1.1.16072 hermes_aol Apache-HttpAsyncClient/4.1.4 (Java/11.0.6) Received-SPF: pass client-ip=74.6.129.81; envelope-from=spacibba@aol.com; helo=sonic317-26.consmr.mail.bf2.yahoo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/11 09:03:46 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252105 Archived-At: Hi Omar! Good to know that you agree with the needed changes as I proposed them. Are you willing to implement them? If so, do you have a copyright assignment? I am available to help you with anything you need (I am not a good lisper any way). But I am really interested into see this functionality in vanilla for fido-mode. Best, Ergus On Wed, Jun 10, 2020 at 07:55:09PM -0500, Omar Antol�n Camarena wrote: >Hi! I'm the author of icomplete-vertical. I'd be very happy to see the icomplete-vertical functionality included in Emacs, and Ergus is completely correct: > >> But as I see the code in icomplete-vertical-mode; it relies in a hook (icomplete-vertical-minibuffer-setup) and an advice (icomplete-vertical-format-completions) which in principle we don't need with a very simple modification of icomplete-completions and icomplete-minibuffer-setup. If icomplete-completions produces the formated output it will be more efficient and clean than adding an advice or do a reformat. > >That's exactly what should be done: not include the icomplete-vertical package as is, but instead make small modifications of the existing icomplete package to incorporate the changes. > >> There are also some customizable options that for a simple working vertical mode we shouldn't need (like icomplete-vertical-separator-alist or a face icomplete-vertical-separator) unless we want to add them now. > >Again, Ergus is completely right! Those, with the benefit of hindsight, are over-engineered and shouldn't be included in Emacs. Heck, they shouldn't even be in icomplete-vertical. (I've learned that lesson and although I subsequently wrote a few more completion UIs, I didn't include options analogous to those.) > >-- >Omar Antol�n Camarena >