From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#41649: 27.0.91; beginning-of-defun doesn't work inside React markup in js-jsx-mode Date: Thu, 4 Jun 2020 16:23:40 +0000 Message-ID: <20200604162340.GA17119@ACM> References: <20200602171221.19097.qmail@mail.muc.de> <0cbfd145-bdb2-4e1c-2f81-864c55894bc2@yandex.ru> <20200603193946.GA8484@ACM> <954aaf5b-ebd9-d6f2-0104-6db8a3cf7083@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="73464"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41649@debbugs.gnu.org To: Dmitry Gutov , Brian Leung Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 04 18:24:19 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jgsfD-000J0E-OT for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jun 2020 18:24:19 +0200 Original-Received: from localhost ([::1]:41024 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgsfC-0003G4-P4 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jun 2020 12:24:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgsew-0002yw-Ot for bug-gnu-emacs@gnu.org; Thu, 04 Jun 2020 12:24:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35817) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jgsew-0007oM-Dl for bug-gnu-emacs@gnu.org; Thu, 04 Jun 2020 12:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jgsew-0001ws-AQ for bug-gnu-emacs@gnu.org; Thu, 04 Jun 2020 12:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jun 2020 16:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41649 X-GNU-PR-Package: emacs Original-Received: via spool by 41649-submit@debbugs.gnu.org id=B41649.15912878247468 (code B ref 41649); Thu, 04 Jun 2020 16:24:02 +0000 Original-Received: (at 41649) by debbugs.gnu.org; 4 Jun 2020 16:23:44 +0000 Original-Received: from localhost ([127.0.0.1]:47363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgsee-0001wN-H8 for submit@debbugs.gnu.org; Thu, 04 Jun 2020 12:23:44 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:56543 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1jgsec-0001wB-2h for 41649@debbugs.gnu.org; Thu, 04 Jun 2020 12:23:43 -0400 Original-Received: (qmail 86780 invoked by uid 3782); 4 Jun 2020 16:23:40 -0000 Original-Received: from acm.muc.de (p4fe15c7a.dip0.t-ipconnect.de [79.225.92.122]) by localhost.muc.de (tmda-ofmipd) with ESMTP; Thu, 04 Jun 2020 18:23:39 +0200 Original-Received: (qmail 17303 invoked by uid 1000); 4 Jun 2020 16:23:40 -0000 Content-Disposition: inline In-Reply-To: <954aaf5b-ebd9-d6f2-0104-6db8a3cf7083@yandex.ru> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181517 Archived-At: Hello, Dmitry and Brian. On Wed, Jun 03, 2020 at 23:08:09 +0300, Dmitry Gutov wrote: > On 03.06.2020 22:39, Alan Mackenzie wrote: > > I'll get a patch onto the list as soon as I've got the time and energy to > > check it over carefully. > Thanks! Would you please try out the following patch, which ought to fix the problem the patch should fix. Seeing as how it corrects the value of a number of configuration variables (around fifteen), there might be further incidental benefits. diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el index 5ec3e94275..04b449ecd2 100644 --- a/lisp/progmodes/js.el +++ b/lisp/progmodes/js.el @@ -4591,7 +4591,6 @@ js-mode (setq imenu-create-index-function #'js--imenu-create-index) ;; for filling, pretend we're cc-mode - (c-init-language-vars js-mode) (setq-local comment-line-break-function #'c-indent-new-comment-line) (setq-local comment-multi-line t) (setq-local electric-indent-chars It might well be too late to include this patch in the Emacs 27 release. If you're reading this, Eli, what do you say? -- Alan Mackenzie (Nuremberg, Germany).