bug#5953: 23.1.95; objc-mode doesn't fontify Objective-C 2.0 keywords @syntesize and @property correctly

bug#5953: 23.1.95; objc-mode doesn't fontify Objective-C 2.0 keywords @syntesize and @property correctly

[Aleksandr Skobelev]

objc-mode doesn't know anything about the new Objective-C 2.0
keywords like @property and @syntesize, for example. 

bug#5953: 23.1.95; objc-mode doesn't fontify Objective-C 2.0 keywords @syntesize and @property correctly

[Leo]

On 2010-04-15 23:00 +0800, Aleksandr Skobelev wrote:
> objc-mode doesn't know anything about the new Objective-C 2.0
> keywords like @property and @syntesize, for example. 

Here is a list of OjbC2.0 directives with annotations:

  http://maniacdev.com/cheatsheetobjccd.pdf

Leo

bug#5953: 23.1.95; objc-mode doesn't fontify Objective-C 2.0 keywords @syntesize and @property correctly

[Leo]

[-- Attachment #1: Type: text/plain, Size: 620 bytes --]

On 2012-08-22 11:32 +0800, Leo wrote:
> Here is a list of OjbC2.0 directives with annotations:
>
>   http://maniacdev.com/cheatsheetobjccd.pdf
>
> Leo

I have compiled a patch to improve support for Objective C.

I am not sure where to add the following keywords so they live in
c-other-decl-kwds for now. Please review the patch. Thanks.

  1. @property
     : @property (attributes) Type propertyName;
  2. @dynamic
     : @dynamic aProperty, bProperty;
  3. @synthesize
     : @synthesize aProperty, bProperty, cProperty=_ivar;
  4. @compatibility_alias
     : @compatibility_alias AliasClassName ExistingClassName;


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-ObjC-2.0-directives-support.patch --]
[-- Type: text/x-patch, Size: 2116 bytes --]

From 3ea4329978ebe2e5cb9d4bfd1e544277cf8e0352 Mon Sep 17 00:00:00 2001
From: Leo Liu <sdl.web@gmail.com>
Date: Wed, 22 Aug 2012 16:54:18 +0800
Subject: [PATCH] Add ObjC 2.0 directives support

---
 lisp/progmodes/cc-langs.el | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/lisp/progmodes/cc-langs.el b/lisp/progmodes/cc-langs.el
index 78be8ac2..4aed2048 100644
--- a/lisp/progmodes/cc-langs.el
+++ b/lisp/progmodes/cc-langs.el
@@ -1884,7 +1884,8 @@ (c-lang-defconst c-other-decl-kwds
 `c-<>-type-kwds', or `c-<>-arglist-kwds' then the associated clauses
 will be handled."
   t       nil
-  objc    '("@class" "@end" "@defs")
+  objc    '("@class" "@defs" "@end" "@property" "@dynamic" "@synthesize"
+	    "@compatibility_alias")
   java    '("import" "package")
   pike    '("import" "inherit"))
 
@@ -2006,7 +2007,8 @@ (c-lang-defconst c-protection-kwds
   "Access protection label keywords in classes."
   t    nil
   c++  '("private" "protected" "public")
-  objc '("@private" "@protected" "@public"))
+  objc '("@private" "@protected" "@package" "@public"
+	 "@required" "@optional"))
 
 (c-lang-defconst c-block-decls-with-vars
   "Keywords introducing declarations that can contain a block which
@@ -2176,7 +2178,7 @@ (c-lang-defconst c-block-stmt-1-kwds
   "Statement keywords followed directly by a substatement."
   t    '("do" "else")
   c++  '("do" "else" "try")
-  objc '("do" "else" "@finally" "@try")
+  objc '("do" "else" "@finally" "@try" "@autoreleasepool")
   java '("do" "else" "finally" "try")
   idl  nil)
 
@@ -2292,7 +2294,8 @@ (c-lang-defconst c-constant-kwds
   t       nil
   (c c++) '("NULL" ;; Not a keyword, but practically works as one.
 	    "false" "true")		; Defined in C99.
-  objc    '("nil" "Nil" "YES" "NO" "NS_DURING" "NS_HANDLER" "NS_ENDHANDLER")
+  objc    '("nil" "Nil" "YES" "NO" "IBAction" "IBOutlet"
+	    "NS_DURING" "NS_HANDLER" "NS_ENDHANDLER")
   idl     '("TRUE" "FALSE")
   java    '("true" "false" "null") ; technically "literals", not keywords
   pike    '("UNDEFINED")) ;; Not a keyword, but practically works as one.
-- 
1.7.12

bug#5953: 23.1.95; objc-mode doesn't fontify Objective-C 2.0 keywords @syntesize and @property correctly

[Lars Ingebrigtsen]

Leo <sdl.web@gmail.com> writes:

> On 2012-08-22 11:32 +0800, Leo wrote:
>> Here is a list of OjbC2.0 directives with annotations:
>>
>>   http://maniacdev.com/cheatsheetobjccd.pdf
>>
>> Leo
>
> I have compiled a patch to improve support for Objective C.
>
> I am not sure where to add the following keywords so they live in
> c-other-decl-kwds for now. Please review the patch. Thanks.
>
>   1. @property
>      : @property (attributes) Type propertyName;
>   2. @dynamic
>      : @dynamic aProperty, bProperty;
>   3. @synthesize
>      : @synthesize aProperty, bProperty, cProperty=_ivar;
>   4. @compatibility_alias
>      : @compatibility_alias AliasClassName ExistingClassName;

[...]

> -  objc    '("@class" "@end" "@defs")
> +  objc    '("@class" "@defs" "@end" "@property" "@dynamic" "@synthesize"
> +	    "@compatibility_alias")

(etc)

It seems like this patch (from seven years ago) was never applied.  I
know nothing about Objective C, though.  Alan, could you have a look at
this?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#5953: 23.1.95; objc-mode doesn't fontify Objective-C 2.0 keywords @syntesize and @property correctly

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> It seems like this patch (from seven years ago) was never applied.  I
> know nothing about Objective C, though.  Alan, could you have a look at
> this?

Alan, did you find time to look at this patch?  It looks fairly
straightforward to me, but my knowledge of Objective C is very
rudimentary.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#5953: 23.1.95; objc-mode doesn't fontify Objective-C 2.0 keywords @syntesize and @property correctly

[Stefan Kangas]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> It seems like this patch (from seven years ago) was never applied.  I
>> know nothing about Objective C, though.  Alan, could you have a look at
>> this?
>
> Alan, did you find time to look at this patch?  It looks fairly
> straightforward to me, but my knowledge of Objective C is very
> rudimentary.

That was 23 weeks ago.  Alan, did you find any time to look at this
patch?  Thanks in advance.

Best regards,
Stefan Kangas

bug#5953: 23.1.95; objc-mode doesn't fontify Objective-C 2.0 keywords @syntesize and @property correctly

[Alan Mackenzie]

Hello, Stefan.

Sorry for the long delay in answering.

On Mon, May 04, 2020 at 02:53:59 +0200, Stefan Kangas wrote:
> Lars Ingebrigtsen <larsi@gnus.org> writes:

> > Lars Ingebrigtsen <larsi@gnus.org> writes:

> >> It seems like this patch (from seven years ago) was never applied.  I
> >> know nothing about Objective C, though.  Alan, could you have a look at
> >> this?

> > Alan, did you find time to look at this patch?  It looks fairly
> > straightforward to me, but my knowledge of Objective C is very
> > rudimentary.

> That was 23 weeks ago.  Alan, did you find any time to look at this
> patch?  Thanks in advance.

I've been trying to come to some sort of conclusion on this for quite a
long time now.

Somehow, adding nine keywords together with their semantics seems to go
outside the bounds of "trivial" for copyright purposes, even if they do
fit into the arbitrary maximum number of lines.  Kudos to Martin
Stjernholm, my predecessor, who made such compact amendments possible.
I don't know if Leo Liu, the author of the patch, has signed copyright
papers, but I strongly suspect not.

As I say, I don't know what to do with this patch.

> Best regards,
> Stefan Kangas

-- 
Alan Mackenzie (Nuremberg, Germany).

bug#5953: 23.1.95; objc-mode doesn't fontify Objective-C 2.0 keywords @syntesize and @property correctly

[Dmitry Gutov]

On 24.05.2020 22:24, Alan Mackenzie wrote:
> I don't know if Leo Liu, the author of the patch, has signed copyright
> papers, but I strongly suspect not.

He has, quite a few years ago.

Also see: git log --author "Leo Liu"

bug#5953: 23.1.95; objc-mode doesn't fontify Objective-C 2.0 keywords @syntesize and @property correctly

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > Somehow, adding nine keywords together with their semantics seems to go
  > outside the bounds of "trivial" for copyright purposes, even if they do
  > fit into the arbitrary maximum number of lines.

Would you like to show me the patch?  That description suggests that
maybe it is trivial.

-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

bug#5953: 23.1.95; objc-mode doesn't fontify Objective-C 2.0 keywords @syntesize and @property correctly

[Paul Smith]

On Mon, 2020-05-25 at 00:34 -0400, Richard Stallman wrote:
> [[[ To any NSA and FBI agents reading my email: please consider    ]]]
> [[[ whether defending the US Constitution against all enemies,     ]]]
> [[[ foreign or domestic, requires you to follow Snowden's example. ]]]
> 
>   > Somehow, adding nine keywords together with their semantics seems to go
>   > outside the bounds of "trivial" for copyright purposes, even if they do
>   > fit into the arbitrary maximum number of lines.
> 
> Would you like to show me the patch?  That description suggests that
> maybe it is trivial.

It's unfortunate that the SourceForge mailing list archives are so
gross.  FYI, this is a link to the email from 2012 with the patch
attached:

https://sourceforge.net/p/cc-mode/mailman/message/29722632/

This is a link to download the patch:

https://sourceforge.net/p/cc-mode/mailman/attachment/m2sjbfi7tl.fsf%40gmail.com/1/

I've included the patch itself below if you prefer that instead of the
above links.

Cheers!

--------------------------------
>From 3ea4329978ebe2e5cb9d4bfd1e544277cf8e0352 Mon Sep 17 00:00:00 2001
From: Leo Liu <sdl.web@gmail.com>
Date: Wed, 22 Aug 2012 16:54:18 +0800
Subject: [PATCH] Add ObjC 2.0 directives support

---
 lisp/progmodes/cc-langs.el | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/lisp/progmodes/cc-langs.el b/lisp/progmodes/cc-langs.el
index 78be8ac2..4aed2048 100644
--- a/lisp/progmodes/cc-langs.el
+++ b/lisp/progmodes/cc-langs.el
@@ -1884,7 +1884,8 @@ (c-lang-defconst c-other-decl-kwds
 `c-<>-type-kwds', or `c-<>-arglist-kwds' then the associated clauses
 will be handled."
   t       nil
-  objc    '("@class" "@end" "@defs")
+  objc    '("@class" "@defs" "@end" "@property" "@dynamic" "@synthesize"
+	    "@compatibility_alias")
   java    '("import" "package")
   pike    '("import" "inherit"))
 
@@ -2006,7 +2007,8 @@ (c-lang-defconst c-protection-kwds
   "Access protection label keywords in classes."
   t    nil
   c++  '("private" "protected" "public")
-  objc '("@private" "@protected" "@public"))
+  objc '("@private" "@protected" "@package" "@public"
+	 "@required" "@optional"))
 
 (c-lang-defconst c-block-decls-with-vars
   "Keywords introducing declarations that can contain a block which
@@ -2176,7 +2178,7 @@ (c-lang-defconst c-block-stmt-1-kwds
   "Statement keywords followed directly by a substatement."
   t    '("do" "else")
   c++  '("do" "else" "try")
-  objc '("do" "else" "@finally" "@try")
+  objc '("do" "else" "@finally" "@try" "@autoreleasepool")
   java '("do" "else" "finally" "try")
   idl  nil)
 
@@ -2292,7 +2294,8 @@ (c-lang-defconst c-constant-kwds
   t       nil
   (c c++) '("NULL" ;; Not a keyword, but practically works as one.
 	    "false" "true")		; Defined in C99.
-  objc    '("nil" "Nil" "YES" "NO" "NS_DURING" "NS_HANDLER" "NS_ENDHANDLER")
+  objc    '("nil" "Nil" "YES" "NO" "IBAction" "IBOutlet"
+	    "NS_DURING" "NS_HANDLER" "NS_ENDHANDLER")
   idl     '("TRUE" "FALSE")
   java    '("true" "false" "null") ; technically "literals", not keywords
   pike    '("UNDEFINED")) ;; Not a keyword, but practically works as one.
-- 
1.7.12

bug#5953: 23.1.95; objc-mode doesn't fontify Objective-C 2.0 keywords @syntesize and @property correctly

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

This patch is trivial.  Only 7 lines are changed, and the change
is directly controlled by the job to be done, so it has no
creativing.

IANAL, but as I understand US copyright law, there is nothing
copyrightable in this change.

So you can just install it.

-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

bug#5953: 23.1.95; objc-mode doesn't fontify Objective-C 2.0 keywords @syntesize and @property correctly

[Dmitry Gutov]

On 26.05.2020 07:11, Richard Stallman wrote:
> This patch is trivial.  Only 7 lines are changed, and the change
> is directly controlled by the job to be done, so it has no
> creativing.
> 
> IANAL, but as I understand US copyright law, there is nothing
> copyrightable in this change.

*And* the author has signed the copyright assignment papers long ago.

Good note about copyrightability, though.

bug#5953: 23.1.95; objc-mode doesn't fontify Objective-C 2.0 keywords @syntesize and @property correctly

[Alan Mackenzie]

Hello, Richard and Dmitry.

On Tue, May 26, 2020 at 13:23:36 +0300, Dmitry Gutov wrote:
> On 26.05.2020 07:11, Richard Stallman wrote:
> > This patch is trivial.  Only 7 lines are changed, and the change
> > is directly controlled by the job to be done, so it has no
> > creativing.

OK, thanks for that.

> > IANAL, but as I understand US copyright law, there is nothing
> > copyrightable in this change.

That is good to know.

> *And* the author has signed the copyright assignment papers long ago.

That is also very good to know.

> Good note about copyrightability, though.

And if you're still around, Leo, thanks very much for the patch!  I'll
commit it in the next day or so.

-- 
Alan Mackenzie (Nuremberg, Germany).

bug#5953: 23.1.95; objc-mode doesn't fontify Objective-C 2.0 keywords @syntesize and @property correctly

[Paul Smith]

On Tue, 2020-05-26 at 18:31 +0000, Alan Mackenzie wrote:
> > *And* the author has signed the copyright assignment papers long
> > ago.
> 
> That is also very good to know.

Curious as to how to find out this information?

I checked the copyright list available in /gd/gnuorg and did not see
any entry for "Leo Liu".  There were plenty of other names containing
"Liu" (and some "Leo"'s) but I have no idea how to tell if one of them
is this same person.

bug#5953: 23.1.95; objc-mode doesn't fontify Objective-C 2.0 keywords @syntesize and @property correctly

[Alan Mackenzie]

Hello, all.

On Tue, May 26, 2020 at 18:31:05 +0000, Alan Mackenzie wrote:
> On Tue, May 26, 2020 at 13:23:36 +0300, Dmitry Gutov wrote:
> > On 26.05.2020 07:11, Richard Stallman wrote:
> > > This patch is trivial.  Only 7 lines are changed, and the change
> > > is directly controlled by the job to be done, so it has no
> > > creativing.

> OK, thanks for that.

> > > IANAL, but as I understand US copyright law, there is nothing
> > > copyrightable in this change.

> That is good to know.

> > *And* the author has signed the copyright assignment papers long ago.

> That is also very good to know.

> > Good note about copyrightability, though.

> And if you're still around, Leo, thanks very much for the patch!  I'll
> commit it in the next day or so.

I've committed the patch, and with this post, I'm closing the bug.  Many
thanks to everybody who's been so patient.

> -- 
> Alan Mackenzie (Nuremberg, Germany).

bug#5953: 23.1.95; objc-mode doesn't fontify Objective-C 2.0 keywords @syntesize and @property correctly

[Dmitry Gutov]

On 26.05.2020 23:03, Paul Smith wrote:
> I checked the copyright list available in /gd/gnuorg and did not see
> any entry for "Leo Liu".  There were plenty of other names containing
> "Liu" (and some "Leo"'s) but I have no idea how to tell if one of them
> is this same person.

Search the file for his email (specifically: the part before @). The 
name written in the file is a bit different.

bug#5953: 23.1.95; objc-mode doesn't fontify Objective-C 2.0 keywords @syntesize and @property correctly

[Leo Liu]

On 2020-05-26 18:31 +0000, Alan Mackenzie wrote:
>> Good note about copyrightability, though.
>
> And if you're still around, Leo, thanks very much for the patch!  I'll
> commit it in the next day or so.

Yes. Thanks everyone to get this closed. I am still around and read the
emacs bug and devel mailing lists at lease once a week ;)

Leo