From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: Compiling emacs-27.0.91 on macOS Catalina Date: Fri, 15 May 2020 11:46:00 +0100 Message-ID: <20200515104600.GA52992@breton.holly.idiocy.org> References: <20200512221907.GB50065@breton.holly.idiocy.org> <83sgg47evg.fsf@gnu.org> <20200514192432.GA50681@breton.holly.idiocy.org> <83d0754tqs.fsf@gnu.org> <20200515062558.GA52382@breton.holly.idiocy.org> <83lflt34ja.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="9417"; mail-complaints-to="usenet@ciao.gmane.io" Cc: paranda@it.uc3m.es, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 15 12:48:56 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jZXtc-0001r6-A9 for ged-emacs-devel@m.gmane-mx.org; Fri, 15 May 2020 12:48:52 +0200 Original-Received: from localhost ([::1]:53448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZXtb-0005dj-D6 for ged-emacs-devel@m.gmane-mx.org; Fri, 15 May 2020 06:48:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZXsv-0004tv-3f for emacs-devel@gnu.org; Fri, 15 May 2020 06:48:09 -0400 Original-Received: from ip6-2001-08b0-03f8-8129-a41a-72f1-ae7e-5760.holly.idiocy.org ([2001:8b0:3f8:8129:a41a:72f1:ae7e:5760]:54667 helo=breton.holly.idiocy.org) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZXss-0003t0-FJ; Fri, 15 May 2020 06:48:07 -0400 Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 3E7162022CA176; Fri, 15 May 2020 11:46:00 +0100 (BST) Mail-Followup-To: Alan Third , Eli Zaretskii , paranda@it.uc3m.es, emacs-devel@gnu.org Content-Disposition: inline In-Reply-To: <83lflt34ja.fsf@gnu.org> Received-SPF: none client-ip=2001:8b0:3f8:8129:a41a:72f1:ae7e:5760; envelope-from=alan@breton.holly.idiocy.org; helo=breton.holly.idiocy.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/15 06:46:02 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) BAYES_00=-1.9, RDNS_DYNAMIC=0.982, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:250378 Archived-At: On Fri, May 15, 2020 at 12:56:25PM +0300, Eli Zaretskii wrote: > > Date: Fri, 15 May 2020 07:25:58 +0100 > > From: Alan Third > > Cc: paranda@it.uc3m.es, emacs-devel@gnu.org > > > > Alternatively we could check the results from trying to load the file. > > There's no way I can see to catch the error, but we can count the > > number of colours available. Is this too late for Emacs 27? > > I don't think I understand the effect of this change yet, so I cannot > answer the question. How will this prevent the problem? The color file is simply a native version of etc/rgb.txt. It contains colour values and their names. I'm not really sure why we save it, to be honest. On first run Emacs detects there is no color file (cl == nil in the code) and generates it from rgb.txt. Since we're unable to detect directly if loading the color file has thrown an error my change checks whether there are less colors loaded than there are in rgb.txt. If there are less then it will regenerate the file. It's not great, rgb.txt could change, but I assume at this stage that that's unlikely or rare. -- Alan Third