From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix misnamed variable breaking GNUstep Emacs.app build Date: Sat, 18 Apr 2020 20:49:47 +0100 Message-ID: <20200418194947.GA56686@breton.holly.idiocy.org> References: <864kth1z8g.wl-me@enzu.ru> <20200418123031.GA54322@breton.holly.idiocy.org> <864ktgy53k.wl-me@enzu.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="43911"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Ahmed Khanzada Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 18 22:21:21 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jPtxp-000BJd-85 for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Apr 2020 22:21:21 +0200 Original-Received: from localhost ([::1]:33124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPtxo-0007hO-BH for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Apr 2020 16:21:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48696) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPtxI-0007D3-5W for emacs-devel@gnu.org; Sat, 18 Apr 2020 16:20:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jPtxH-0000ug-0s for emacs-devel@gnu.org; Sat, 18 Apr 2020 16:20:47 -0400 Original-Received: from idiocy.org ([217.169.17.33]:63588 helo=breton.holly.idiocy.org) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPtxG-0000Jb-C2 for emacs-devel@gnu.org; Sat, 18 Apr 2020 16:20:46 -0400 Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id A596420221D769; Sat, 18 Apr 2020 20:49:47 +0100 (BST) Mail-Followup-To: Alan Third , Ahmed Khanzada , emacs-devel@gnu.org Content-Disposition: inline In-Reply-To: <864ktgy53k.wl-me@enzu.ru> Received-SPF: none client-ip=217.169.17.33; envelope-from=alan@breton.holly.idiocy.org; helo=breton.holly.idiocy.org X-detected-operating-system: by eggs.gnu.org: Mac OS X [generic] [fuzzy] X-Received-From: 217.169.17.33 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:247243 Archived-At: On Sat, Apr 18, 2020 at 12:19:11PM -0700, Ahmed Khanzada wrote: > On Sat, 18 Apr 2020 05:30:31 -0700, > The result of the git format patch -1 is attached to this email. > > Sorry for the inline patch, that is just how OpenBSD prefers it. Should > all patches be attachments going forward, or just the end stages before > ommit? Inline is sometimes easier to review. For discussion, if it’s not too big, inline is probably as good as anything. In this particular case I was just hoping you’d write the commit message. I suppose I wasn’t clear. If you look in the CONTRIBUTE file there’s information about the preferred format. It’s worth checking it out if you’re planning on contributing again. I’ll sort this patch and push it to master. Thanks! -- Alan Third