From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: Optional support for GDI+ on Windows (emacs-28) Date: Tue, 31 Mar 2020 21:36:06 +0200 (CEST) Message-ID: <20200331193602.GA82791@breton.holly.idiocy.org> References: <86lfnh8wzn.fsf@csic.es> <83pncs1ulv.fsf@gnu.org> <86ftdoedvh.fsf@csic.es> <83d08s1nf9.fsf@gnu.org> <20200331165749.GC81462@breton.holly.idiocy.org> <837dz01kxi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="69700"; mail-complaints-to="usenet@ciao.gmane.io" Cc: juanjose.garciaripoll@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 31 21:37:15 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJMhH-000I1k-2T for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Mar 2020 21:37:15 +0200 Original-Received: from localhost ([::1]:43486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJMhG-0004Yd-3k for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Mar 2020 15:37:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40266) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJMgI-0003KI-6n for emacs-devel@gnu.org; Tue, 31 Mar 2020 15:36:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJMgG-0006tb-OS for emacs-devel@gnu.org; Tue, 31 Mar 2020 15:36:13 -0400 Original-Received: from mailout-l3b-97.contactoffice.com ([212.3.242.97]:42532) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJMgE-0006rT-FZ; Tue, 31 Mar 2020 15:36:10 -0400 Original-Received: from smtpauth1.co-bxl (smtpauth1.co-bxl [10.2.0.15]) by mailout-l3b-97.contactoffice.com (Postfix) with ESMTP id 49B5788B; Tue, 31 Mar 2020 21:36:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1585683368; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To; l=1285; bh=alOZV/dNeHX7p94hy4noUNA978NVKZe7DSyGZfKEvoM=; b=rG4D+HwYsCA34q2KQ1vIitFTUrrW7k6HfjU7M9ZHtmVjwbZ3YGpMcxiXYkHC/UiV ApeQ2qkDbsCgoLTphqo1wfjUXKWGasaNkMI3XSbEyAytX085eSgd/Ax2p0uYWKrDgsq PNinpiCd1xNFVCTn1dhLbrlRVeS4qou6m/two6dDIzAgeg9C6Tm/GBZ6wxzoLDKMCd4 D0BmeEHEnV2hJqzcwW73enVGQLeTAgTxy9/oJOxbNYIHu0l72heAiM7ZyfFhqOqZTT7 Nwli4dtaHLe/s8p+MEkNYoVJ4325o9A73Ea7MS+5QBb3q71lJ0bnuioBRntTJkzNLs5 EslZa4gitA== Original-Received: by smtp.mailfence.com with ESMTPSA ; Tue, 31 Mar 2020 21:36:03 +0200 (CEST) Original-Received: by idiocy.org (Postfix, from userid 501) id 6045A202145D77; Tue, 31 Mar 2020 20:36:02 +0100 (BST) Mail-Followup-To: Alan Third , Eli Zaretskii , juanjose.garciaripoll@gmail.com, emacs-devel@gnu.org Content-Disposition: inline In-Reply-To: <837dz01kxi.fsf@gnu.org> X-ContactOffice-Account: com:241649512 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.3.242.97 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246155 Archived-At: On Tue, Mar 31, 2020 at 08:41:29PM +0300, Eli Zaretskii wrote: > > Date: Tue, 31 Mar 2020 18:57:52 +0200 (CEST) > > From: Alan Third > > Cc: Juan Jos=C3=A9 Garc=C3=ADa-Ripoll , > > emacs-devel@gnu.org > >=20 > > On Tue, Mar 31, 2020 at 07:47:38PM +0300, Eli Zaretskii wrote: > > >=20 > > > Like I said: this must not be a compile-time condition, we should > > > decide whether GDI+ is supported at runtime, and we should provide > > > variables to control whether GDI+ is used for each supported image > > > format. HAVE_GDIPLUS should guard code which uses GDI+, but it sho= uld > > > NOT decide whether that code is actually used. > >=20 > > May I request that however the above is implemented, it can be > > extended to the NS port=E2=80=99s use of NSImage vs libpng, etc. as w= ell? >=20 > Can you elaborate? I don't think I understand the request, probably > because I know very little about how NS deals with images in Emacs. Simply that since the proposed patch works largely the same as the NS port, if possible leave any implementation generic. That is, rather than create a variable called w32-png-use-gdi-plus, perhaps name it something like image=E2=80=93png-use-native. If it=E2=80=99s not possible then that=E2=80=99s fine. --=20 Alan Third