From: Alan Third <alan@idiocy.org>
To: Andrii Kolomoiets <andreyk.mad@gmail.com>
Cc: 40200@debbugs.gnu.org, 28872@debbugs.gnu.org, aaronjensen@gmail.com
Subject: bug#28872: [PATCH v2] Fix NS frame resizing issues (bug#40200, bug#28872)
Date: Sat, 28 Mar 2020 02:56:59 +0100 (CET) [thread overview]
Message-ID: <20200328015657.GA66478@breton.holly.idiocy.org> (raw)
In-Reply-To: <C0CF2FAE-FC57-4555-833F-28DFFF7E3859@gmail.com>
On Fri, Mar 27, 2020 at 03:22:08PM +0200, Andrii Kolomoiets wrote:
> On 26 Mar 2020, at 23:21, Alan Third <alan@idiocy.org> wrote:
> > Hopefully this works better.
>
> Found another changed behavior:
> 1. emacs -Q
> 2. (setq test/frame (make-frame `((parent-frame . ,(selected-frame)))))
> 3. (modify-frame-parameters test/frame '((height . 1) (top . (- 40))))
>
> Old behavior: child frame is at bottom of the parent frame.
This is wrong.
> New behavior: child frame is at top of the parent frame.
This is wrong too.
> Child frame moves to bottom after code from step 3 applied one more time.
Still wrong.
The bottom of the child frame should be 40 pixels from the bottom of
the parent frame.
This is quite annoying, it means Emacs 27 behaves wrongly. I wonder if
Emacs 26 does too, or has it been broken the whole time?
> Step 3 can be replaced with these two steps to achieve old behavior:
> (modify-frame-parameters test/frame '((height . 1)))
> (modify-frame-parameters test/frame '((top . (- 40))))
I inadvertently made order of operations matter when they shouldn’t.
I’ve got a fix for this, but it’s opening up a whole other can of
worms regarding frame positioning and the reporting of positions.
I think I know what to do but the last time I worked on this we had a
lot of edge cases that weren’t easy to test, with multiple monitors
and spaces. I think I’ll have to look at the old bug reports to work
out how we handle that.
--
Alan Third
next prev parent reply other threads:[~2020-03-28 1:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 18:13 bug#40200: 28.0.50; NS: text drawing glitches in maximized frame with frame-inhibit-implied-resize Andrii Kolomoiets
2020-03-23 19:22 ` Eli Zaretskii
2020-03-23 19:47 ` Andrii Kolomoiets
2020-03-23 23:54 ` Alan Third
2020-03-25 22:28 ` bug#40200: [PATCH] Fix NS frame resizing issues (bug#40200, bug#28872) Alan Third
2020-03-26 17:35 ` bug#28872: " Andrii Kolomoiets
2020-03-26 21:21 ` bug#28872: [PATCH v2] " Alan Third
2020-03-27 9:45 ` Andrii Kolomoiets
2020-03-27 13:22 ` Andrii Kolomoiets
2020-03-28 1:56 ` Alan Third [this message]
2020-04-04 14:17 ` bug#40200: [PATCH v3] " Alan Third
2020-04-06 6:57 ` Andrii Kolomoiets
2020-04-06 18:44 ` bug#28872: [PATCH v4] " Alan Third
2020-04-07 8:14 ` bug#40200: " Andrii Kolomoiets
2020-04-16 18:24 ` bug#28872: " Alan Third
2020-04-18 1:52 ` bug#40200: " HaiJun Zhang
2020-04-18 12:07 ` Alan Third
2020-04-18 14:12 ` HaiJun Zhang
2020-04-18 15:26 ` Alan Third
2020-04-19 1:49 ` HaiJun Zhang
2020-05-03 16:26 ` Alan Third
2020-05-03 17:13 ` Filipp Gunbin
2020-05-03 18:41 ` Alan Third
2020-05-03 19:49 ` Filipp Gunbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200328015657.GA66478@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=28872@debbugs.gnu.org \
--cc=40200@debbugs.gnu.org \
--cc=aaronjensen@gmail.com \
--cc=andreyk.mad@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.