From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: emacs-27 3bce7ec: CC Mode: Protect against consecutive calls to before-change-functions ... Date: Wed, 4 Mar 2020 21:24:47 +0000 Message-ID: <20200304212447.GA26206@ACM> References: <20200223194642.5362.21709@vcs0.savannah.gnu.org> <20200223194643.A9A05206ED@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="57036"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mutt/1.10.1 (2018-07-13) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 04 22:25:37 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j9bWK-000Ekd-Qe for ged-emacs-devel@m.gmane-mx.org; Wed, 04 Mar 2020 22:25:36 +0100 Original-Received: from localhost ([::1]:39920 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9bWJ-00028W-S7 for ged-emacs-devel@m.gmane-mx.org; Wed, 04 Mar 2020 16:25:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43263) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9bVd-0001PF-Ug for emacs-devel@gnu.org; Wed, 04 Mar 2020 16:24:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9bVc-0003RL-Rr for emacs-devel@gnu.org; Wed, 04 Mar 2020 16:24:53 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:50576 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1j9bVc-0003Oe-Il for emacs-devel@gnu.org; Wed, 04 Mar 2020 16:24:52 -0500 Original-Received: (qmail 26000 invoked by uid 3782); 4 Mar 2020 21:24:50 -0000 Original-Received: from acm.muc.de (p4FE15B29.dip0.t-ipconnect.de [79.225.91.41]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 04 Mar 2020 22:24:48 +0100 Original-Received: (qmail 26211 invoked by uid 1000); 4 Mar 2020 21:24:47 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:245242 Archived-At: Hello, Glenn. On Fri, Feb 28, 2020 at 11:54:23 -0500, Glenn Morris wrote: > Alan Mackenzie wrote: > > branch: emacs-27 > > commit 3bce7ec3826003fda1971224a20d7fe2cba8bf65 > > CC Mode: Protect against consecutive calls to before-change-functions ... > This causes srecode-utest-getset-output in > test/lisp/cedet/srecode-utest-getset.el to fail: > Test srecode-utest-getset-output backtrace: > parse-partial-sexp(1 627 nil nil nil syntax-table) > c-after-change-mark-abnormal-strings(100 320 0) > #f(compiled-function (fn) #)(c-after-change-mark- > mapc(#f(compiled-function (fn) #) (c-depropertize > c-after-change(100 320 0) > run-hook-with-args(c-after-change 100 320 0) > srecode-insert-fcn(# # srecode-insert-getset() > #f(compiled-function () #)() > ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test > ert-run-test(#s(ert-test :name srecode-utest-getset-output :document > ert-run-or-rerun-test(#s(ert--stats :selector (not (or ... ...)) :te > ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co > ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) > ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un > eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( > command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/cedet/srecode-utest- > command-line() > normal-top-level() > Test srecode-utest-getset-output condition: > (args-out-of-range # 1 627) > FAILED 1/1 srecode-utest-getset-output (1.709802 sec) Yes. I've fixed this bug in the emacs-27 branch. As a matter of interest, the scenario Mattias reported was caused by a different bug (also fixed). -- Alan Mackenzie (Nuremberg, Germany).