all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#39889: emacs-27 and master: unbalanced invocation of after-change-functions in cedet
@ 2020-03-03 20:15 Alan Mackenzie
  0 siblings, 0 replies; only message in thread
From: Alan Mackenzie @ 2020-03-03 20:15 UTC (permalink / raw)
  To: 39889

Hello, Emacs.

In both the emacs-27 and master branches, in
.../lisp/cedet/srecode/insert.el, function srecode-insert-fcn,
after-change-functions is invoked without a matching invocation of
before-change-functions.  This violates the specified use of these hooks
described on the page "Change Hooks" in the Elisp manual.

CC Mode can recover from this scenario, though its recovery is slow (it
essentially runs the change hooks over the entire buffer).

It is not clear whether or not the syntax-ppss mechanism will recover
gracefully from this bug.

Any other uses of before-change-functions will probably suffer
corruption from this bug.

It looks like a good solution might well be to surround the pertinent
code with the combine-change-calls macro, at least for Emacs-27 onwards.
For the use of the cedet package in older emacsen, an explicit
invocation of before-change-functions needs adding.

-- 
Alan Mackenzie (Nuremberg, Germany).





^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-03-03 20:15 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-03 20:15 bug#39889: emacs-27 and master: unbalanced invocation of after-change-functions in cedet Alan Mackenzie

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.