all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: 39724@debbugs.gnu.org, eliz@gnu.org
Subject: bug#39724: 26.3; Commit 44298ea6aa006ed227e539b02279bd3fc11fd2a6 breaks font display on macOS
Date: Fri, 21 Feb 2020 22:50:14 +0000	[thread overview]
Message-ID: <20200221225014.GA49998@breton.holly.idiocy.org> (raw)
In-Reply-To: <m28skvk42j.fsf@newartisans.com>

On Fri, Feb 21, 2020 at 01:45:08PM -0800, John Wiegley wrote:
> I noticed recently that no text was displaying in my Emacs 27 windows. As if
> everything were black and black, except that changing the font and background
> colors did not help.
> 
> It took two days of rebuilding, but I've isolated this as the breaking commit:
> 
> commit 44298ea6aa006ed227e539b02279bd3fc11fd2a6
> Author: Alan Third <alan@idiocy.org>
> Date:   Sat Feb 1 21:17:29 2020 +0000
> 
>     Use CGImage instead of NSBitmapImageRep (bug#32932)
> 
>     * src/nsterm.m (ns_update_end):
>     (ns_clear_frame): Remove forced draws.
>     (ns_draw_fringe_bitmap):
>     (ns_dumpglyphs_image): No longer need to invert images as the context
>     is already flipped.
>     ([EmacsView updateFrameSize:]):
>     ([EmacsView initFrameFromEmacs:]): Use new function.
>     ([EmacsView createDrawingBuffer]): Replaces createDrawingBufferWithRect:.
>     ([EmacsView focusOnDrawingBuffer]): Set CGImage context.
>     ([EmacsView windowDidChangeBackingProperties:]): Use new function.
>     ([EmacsView copyRect:to:]): Copy using CGImages.
>     ([EmacsView wantsUpdateLayer]):
>     ([EmacsView updateLayer]): New Functions.
>     ([EmacsView drawRect:]): We no longer do anything special here for
>     Cocoa.
>     ([EmacsView windowDidChangeBackingProperties:]): Fix indentation and
>     add NSTRACE.

Hi John, that commit isn’t in the emacs-27 branch, or if it is
something has gone terribly wrong.

> Anything prior to this works as expected. From this commit forward, all
> windows are black on black.

Zhang Haijun has reported something similar on the master branch. The
compile logs look as though there’s something wrong with his build
environment. What version of macOS are you using? Are there any errors
or warnings when you build it?
-- 
Alan Third





  reply	other threads:[~2020-02-21 22:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-21 21:45 bug#39724: 26.3; Commit 44298ea6aa006ed227e539b02279bd3fc11fd2a6 breaks font display on macOS John Wiegley
2020-02-21 22:50 ` Alan Third [this message]
2020-02-23 20:59   ` John Wiegley
2020-02-24  9:45     ` Alan Third
2020-02-24 17:56       ` John Wiegley
2020-02-25 21:06         ` Alan Third
2020-03-05 17:22           ` Alan Third
2020-08-24  8:36             ` Stefan Kangas
2020-10-01 12:38               ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200221225014.GA49998@breton.holly.idiocy.org \
    --to=alan@idiocy.org \
    --cc=39724@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.