From: Alan Mackenzie <acm@muc.de>
To: Liran Zvibel <liranz@gmail.com>
Cc: 18158@debbugs.gnu.org, Stefan Kangas <stefan@marxist.se>
Subject: bug#18158: Fix extra indent of d-mode "else static if" statements in cc-engine.el
Date: Fri, 31 Jan 2020 19:41:03 +0000 [thread overview]
Message-ID: <20200131194103.GA5872@ACM> (raw)
In-Reply-To: <8B3ABB9B-7A39-428A-A65B-B77D0614C9FE@gmail.com>
Hello, Liran.
Many thanks for the sample D file. I can indeed reproduce the problem,
and I'm looking into ways of fixing it properly, thus removing the need
for the workarounds which have found their way into d-mode.el.
On Tue, Jan 28, 2020 at 17:26:41 -0800, Liran Zvibel wrote:
> @("notrace") JSONValue objToJSON(T)(auto ref const T obj) @trusted {
> alias U = Unqual!T;
> static if (is(U == JSONValue)) {
> return obj;
> }
> else static if (__traits(compiles, obj.toJSON())) {
> return obj.toJSON();
> }
> else static if (is(U == typeof(null))) {
[ .... ]
> }
> }
> }
> :
> > On Jan 26, 2020, at 7:29 AM, Alan Mackenzie <acm@muc.de> wrote:
> > Hello, Stefan and Liran.
> > On Mon, Jan 20, 2020 at 22:18:05 +0100, Stefan Kangas wrote:
> >> Hi Alan,
> >> Could you please help review also the below patch for cc-engine.el?
> > I'm less than happy about putting a special purpose workaround into a
> > critical bit of CC Mode (c-add-stmt-syntax) without having even seen the
> > problem.
> > Liran, if you're still there and still interested, could you possibly
> > supply me with a sample of D source code containing the problem? I
> > would hope to be able to enhance CC Mode to handle it in a more general
> > and useful fashion.
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2020-01-31 19:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 15:33 bug#18158: Fix extra indent of d-mode "else static if" statements in cc-engine.el Liran Zvibel
2020-01-20 21:18 ` Stefan Kangas
2020-01-26 15:29 ` Alan Mackenzie
2020-01-29 1:26 ` Liran Zvibel
2020-01-31 19:41 ` Alan Mackenzie [this message]
2020-02-02 11:56 ` bug#18158: D Mode: Getting rid of the ugly advice on looking-at Alan Mackenzie
2020-02-02 16:59 ` Vladimir Panteleev
2020-02-07 21:31 ` Alan Mackenzie
[not found] ` <20200207213100.GB8591@ACM>
2020-02-13 13:37 ` Vladimir Panteleev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131194103.GA5872@ACM \
--to=acm@muc.de \
--cc=18158@debbugs.gnu.org \
--cc=liranz@gmail.com \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.