From: Alan Third <alan@idiocy.org>
To: tsuucat <tsuucat@icloud.com>
Cc: 38851@debbugs.gnu.org
Subject: bug#38851: 27.0.50; Recent my patch breaks isearch with macOS native input method
Date: Fri, 3 Jan 2020 20:29:43 +0000 [thread overview]
Message-ID: <20200103202943.GA60724@breton.holly.idiocy.org> (raw)
In-Reply-To: <CA6D9194-20BA-4F7D-852A-F32392883BE9@icloud.com>
On Thu, Jan 02, 2020 at 03:25:13AM +0900, tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote:
> I sent a patch for Bug#23412 and the patch was already merged.
> (http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-27&id=ba042176d8931cdf9441b3b4919ec74b75019494)
>
> Unfortunately, the patch breaks isearch with macOS native input method.
> I tried to modify ns-echo-working-text function and ns-delete-working-text
> function, but I cannot do it.
> This is because input-pending-p now returns t after pressing RET to confirm
> the conversion. (isearch-update function uses input-pending-p)
>
> The following patch treats ns-unput-working-text event by deleteWorkingText
> specially in read_char(). This solve the problem.
Thanks. I have no better ideas, so this will have to do. Does anyone
else have any opinions?
--
Alan Third
next prev parent reply other threads:[~2020-01-03 20:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-01 18:25 bug#38851: 27.0.50; Recent my patch breaks isearch with macOS native input method tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-01-03 20:29 ` Alan Third [this message]
2020-02-10 17:08 ` tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-02-10 21:44 ` Alan Third
2020-02-10 22:21 ` tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-02-11 15:56 ` Eli Zaretskii
2020-02-11 17:22 ` Alan Third
2020-02-13 19:17 ` tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-02-19 11:14 ` Alan Third
2020-02-11 17:05 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200103202943.GA60724@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=38851@debbugs.gnu.org \
--cc=tsuucat@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.