From: Alan Third <alan@idiocy.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: Mike Hamrick <mikeh@muppetlabs.com>, 38564@debbugs.gnu.org
Subject: bug#38564: 27.0.50; macOS "emacs -nw" git-gutter-mode segfault
Date: Thu, 19 Dec 2019 19:20:50 +0000 [thread overview]
Message-ID: <20191219192050.GB23983@breton.holly.idiocy.org> (raw)
In-Reply-To: <m2pnguxa0o.fsf@gmail.com>
On Thu, Dec 12, 2019 at 08:45:11AM +0100, Robert Pluim wrote:
> >>>>> On Wed, 11 Dec 2019 19:37:34 +0000, Alan Third <alan@idiocy.org> said:
>
> Alan> On Wed, Dec 11, 2019 at 11:12:41AM +0100, Robert Pluim wrote:
> >> Right idea, but one layer lower than needed. ns_color_index_to_rgba
> >> should not be calling ns_lookup_indexed_color in non-gui mode. Try
> >> this instead:
>
> Alan> Hi Robert, thanks for sorting this. One thing...
>
> >> + if (FRAME_DISPLAY_INFO (f))
>
> Alan> Would it not be better to use FRAME_NS_P?
>
> Yes. In fact, how about reverting my change to ns_color_index_to_rgba
> and doing this instead (you canʼt use FRAME_DISPLAY_INFO in
> dispextern.h without much bigger changes):
Hi Robert, I’m not sure if you were waiting for me, but I’m happy with
either approach.
--
Alan Third
next prev parent reply other threads:[~2019-12-19 19:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 1:33 bug#38564: 27.0.50; macOS "emacs -nw" git-gutter-mode segfault Mike Hamrick
2019-12-11 10:12 ` Robert Pluim
2019-12-11 15:15 ` Mike Hamrick
2019-12-11 15:35 ` Robert Pluim
2019-12-11 19:37 ` Alan Third
2019-12-12 7:45 ` Robert Pluim
2019-12-19 19:20 ` Alan Third [this message]
2019-12-19 18:03 ` Mike Hamrick
2019-12-19 19:14 ` Alan Third
2019-12-20 11:47 ` Robert Pluim
2019-12-20 20:21 ` Mike Hamrick
2019-12-29 20:41 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219192050.GB23983@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=38564@debbugs.gnu.org \
--cc=mikeh@muppetlabs.com \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.