From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#38406: 27.0.50; post-self-insert-hook does not hold its contract in cc-mode derived modes Date: Mon, 2 Dec 2019 18:31:56 +0000 Message-ID: <20191202183156.GA4175@ACM> References: <20191130143638.GA6716@ACM> <20191201150738.GB5085@ACM> <83imn0lyed.fsf@gnu.org> <20191201192709.GE5085@ACM> <83blsrn58a.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="29754"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.10.1 (2018-07-13) Cc: yyoncho@gmail.com, 38406@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 02 19:33:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ibqVT-0007aX-Py for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Dec 2019 19:33:12 +0100 Original-Received: from localhost ([::1]:43168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibqVS-0000Ih-3l for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Dec 2019 13:33:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33022) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibqVL-0000IN-EG for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2019 13:33:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibqVK-0000R5-Bd for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2019 13:33:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32957) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ibqVK-0000R1-81 for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2019 13:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ibqVK-0004Yq-4F for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2019 13:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Dec 2019 18:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38406 X-GNU-PR-Package: emacs Original-Received: via spool by 38406-submit@debbugs.gnu.org id=B38406.157531152317460 (code B ref 38406); Mon, 02 Dec 2019 18:33:02 +0000 Original-Received: (at 38406) by debbugs.gnu.org; 2 Dec 2019 18:32:03 +0000 Original-Received: from localhost ([127.0.0.1]:38930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibqUM-0004XY-Ob for submit@debbugs.gnu.org; Mon, 02 Dec 2019 13:32:02 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:18852 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1ibqUL-0004X9-6q for 38406@debbugs.gnu.org; Mon, 02 Dec 2019 13:32:02 -0500 Original-Received: (qmail 79959 invoked by uid 3782); 2 Dec 2019 18:31:59 -0000 Original-Received: from acm.muc.de (p4FE15992.dip0.t-ipconnect.de [79.225.89.146]) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 02 Dec 2019 19:31:56 +0100 Original-Received: (qmail 4180 invoked by uid 1000); 2 Dec 2019 18:31:56 -0000 Content-Disposition: inline In-Reply-To: <83blsrn58a.fsf@gnu.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172781 Archived-At: Hello, Eli. On Sun, Dec 01, 2019 at 22:47:01 +0200, Eli Zaretskii wrote: > > Date: Sun, 1 Dec 2019 19:27:09 +0000 > > Cc: yyoncho@gmail.com, 38406@debbugs.gnu.org > > From: Alan Mackenzie > > post-self-insert-hook's functions, unusually amongs hooks, interfere > > with its triggering event. This contrasts with, say, > > after-change-functions, where the functions don't insert into or > > delete from the buffer, or pre-redisplay-functions, where the > > functions don't try to prevent a particular window getting > > displayed. > You'd be surprised to know what some of those hooks do. Everything > you say they don't, and then some. Any chance you could name one (or even two), thus letting me see for myself? > There's nothing we can do to prevent people from shooting themselves > in the foot or hanging themselves with the rope we provided. In the case of post-self-insert-hook, the damaging functions are part of Emacs itself, not crazy user-written code. > And if you think you are the only one who needs to harden your code to > let people do the craziest things with these hooks, please don't think > so: you are definitely not alone. OK. > But breaking a hook's contract as a means to teach people not to shoot > themselves in the foot is not right. If the uses are legitimate, they > should be able to do them; if they aren't, let them cope with the > consequences. > > So to call this hook at the end of c-electric-brace would mean having to > > filter the hook first (at the very least, to remove > > electric-pair-post-self-insert-function), which just seems very hackish > > and unsatisfactory. > It doesn't seem too hackish to me, and as a nice bonus we will have > post-self-insert-hook act as per its contract again. > So could you please do that? TIA. OK, I'll do that. It's not a nice thing to do, but we're kind of lacking nice things in this situation. Give me a few days, please - I'm a touch busy in RL at the moment. Additionally, how about reversing the encouragement in the Elisp manual to put buffer changing functions onto post-self-insert-hook? -- Alan Mackenzie (Nuremberg, Germany).