From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#38296: Allow Option key to be modifier for non-char key and mouse events Date: Tue, 26 Nov 2019 20:33:24 +0000 Message-ID: <20191126203324.GA7891@breton.holly.idiocy.org> References: <20191121211207.GA96045@breton.holly.idiocy.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="29676"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.12.0 (2019-05-25) Cc: 38296@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 26 21:34:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iZhXJ-0007WI-3T for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Nov 2019 21:34:13 +0100 Original-Received: from localhost ([::1]:58828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZhXH-0004ZU-67 for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Nov 2019 15:34:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43202) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZhX9-0004XT-Gk for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 15:34:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZhX8-0001wP-CR for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 15:34:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47070) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZhX8-0001wF-6F for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 15:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iZhX8-0003rD-4Q for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 15:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Nov 2019 20:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38296 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38296-submit@debbugs.gnu.org id=B38296.157480041714787 (code B ref 38296); Tue, 26 Nov 2019 20:34:02 +0000 Original-Received: (at 38296) by debbugs.gnu.org; 26 Nov 2019 20:33:37 +0000 Original-Received: from localhost ([127.0.0.1]:53043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZhWj-0003qR-4O for submit@debbugs.gnu.org; Tue, 26 Nov 2019 15:33:37 -0500 Original-Received: from mail-wm1-f53.google.com ([209.85.128.53]:37176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZhWg-0003qD-Ji for 38296@debbugs.gnu.org; Tue, 26 Nov 2019 15:33:35 -0500 Original-Received: by mail-wm1-f53.google.com with SMTP id f129so4903534wmf.2 for <38296@debbugs.gnu.org>; Tue, 26 Nov 2019 12:33:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=vHTnhQRBwKrTIwx8cy4g6cmcwTOPxTXQG4ZYa3YlXMU=; b=tPtW4fi38nexUJam3aaETKJQERUZCGNJ4kaYX4UYLO+u2xo0NdHZKLFtoRyb3nhH2G hPugi4c9r+SxfGM5ptw+af8ME7lokjdmmUGlmX6JdpMTOSLpKkUYbwAi6Qa6zyy1tIWL uUokJJQm90sPnm89BtwS9fBSHEIIs6Yn8RVeYPo1IseN0ZizYwvRmrkO7RONkplEcPPK M8vFvk75m5PyF5Ewf6uETQybF5P7m2NWTOZN6Q7GAlkPheCvdH4FJyqG+eJkyaOq+0ED ljjnMMPLjgg6GW7NX7dkLiVO71SOo2wS/VYYtIpYQMN7Xu2+NEuCXoxOQBD6zKUBjGP9 54iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=vHTnhQRBwKrTIwx8cy4g6cmcwTOPxTXQG4ZYa3YlXMU=; b=eGh8yuGDACMsdNY7g2XoGl+uJ16AiftpRKu/fTYcZpSR70e0/z8XIDaWM5Vyl9GOeQ Fx1KU0yLqV/CjTcl+/Ubx4DwUC/+gbbzPJsSLbfdziXVyERwkqBALSkm99lHHX6yMY+n qdPzX/P3f6b9CTmJ5aazOAL53ZI68aMtiQ6f7m6TSVbMcdZpi3TNDgEvTsqghCCM6wFG 6hL1H10ujbtRhFj8Kiv5OrVrIFWctqnDYS4avVVpaH/tuHK/aT4yyMZZeJ8SeNgdsoo6 RTo9uQ/z8kpa2uETHtsEMs3OqIOH98Xlp81hvNVLFZ0uvQsc0OrP3sbzu9aAphxmc3Ja G+bA== X-Gm-Message-State: APjAAAWb+gbvyBJ9qaAX3/YGsHF+FmiiaykTsYjhuJe3jQ0bylHH0Uat emDn7qlZAnwJW/znA450jMI= X-Google-Smtp-Source: APXvYqxgu/mvYU2HzLkYhAGJEJABt07ja+4a2HgZDFRRaJYqR5RN6sxWesEhDK7d92WRq5sOIV9lAQ== X-Received: by 2002:a7b:c5d2:: with SMTP id n18mr807802wmk.37.1574800408247; Tue, 26 Nov 2019 12:33:28 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-d485-68d2-2174-d65b.holly.idiocy.org. [2001:8b0:3f8:8129:d485:68d2:2174:d65b]) by smtp.gmail.com with ESMTPSA id o1sm1261405wrn.84.2019.11.26.12.33.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Nov 2019 12:33:27 -0800 (PST) Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172482 Archived-At: On Mon, Nov 25, 2019 at 08:15:31PM +0100, Mattias Engdegård wrote: > 21 nov. 2019 kl. 22.12 skrev Alan Third : > > > Do you think this functionality will only be required for the > > alt/option key or will there be a demand to add it for command too? In > > my experience the characters available via command are rather more > > obscure, but I’ve little experience with non‐UK keyboards. > > Looking at Mitsuharu Yamamoto's Mac port made me change my mind: it > solves the problem by allowing the variables to have values on the > form (:ordinary SYMBOL :function SYMBOL :mouse SYMBOL), defining > each modifier key separately for ordinary keys, function keys and > mouse events. I had wondered about doing something like this, but not as flexible. Is this the exact interface used by the Mac port? I’m not keen on the word ‘ordinary’, but there’s no use in us doing something different. > This is more flexible, and turned out to be rather simple to > implement, so I think this is better than adding variables. I did it > for all ns-KEY-modifier and ns-right-KEY-modifier variables (KEY > being control, command, alternate and function), since it seemed > silly not to. The relevant macOS-specific documentation was improved > as well. Thanks, it looks good to me. I’ve got a few nitpicks re. the documentation: +The modifiers themselves can be customised; I think that should be a colon at the end, not a semi‐colon, although my grasp of semi‐colon use is tenuous at best. +The value of each variable is either a symbol, describing the key for +any purpose, or a list on the form ^ of +@key{Option} key in macOS is normally used for composing additional I would remove the word ‘normally’. I think it’s redundant since we’re already talking about ‘standard behaviour’. Unless anyone else has objections I don’t see any reason not to push this. -- Alan Third