From: "Edward J. Sabol" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 38193@debbugs.gnu.org
Subject: bug#38193: 26.2; Editing a message in RMAIL should trigger an update to its summary line
Date: Mon, 18 Nov 2019 19:15:03 -0500 (EST) [thread overview]
Message-ID: <20191119001503.8CF03203EC@alderaan.gsfc.nasa.gov> (raw)
In-Reply-To: <83lfsg6qoq.fsf@gnu.org> (message from Eli Zaretskii on Sat, 16 Nov 2019 12:50:13 +0200)
Eli Zaretskii
> Thanks. Does the patch below fix this?
Yes, it does! Thank you very much!
Regards,
Ed
>> Steps:
>> 1. Open an existing RMAIL file with multiple messages in rmail-mode.
>> 2. Press "h" to generate the corresponding rmail-summary buffer.
>> 3. Hit "e" to edit some message.
>> 4. Change the Subject: header of the message in some noticeable way.
>> 5. Press C-c C-c to finish editing the message.
>>
>> Result:
>> The corresponding summary line for the edited message is not updated to
>> reflect the message's new Subject: header. I expect that it should.
>> It used to work like that in older Emacs, pre 22.x for sure, so I
>> consider this to be a regression, albeit a very old one!
>>
>> Same for other headers like From: and To:.
>
> Thanks. Does the patch below fix this?
>
> diff --git a/lisp/mail/rmailedit.el b/lisp/mail/rmailedit.el
> index 01d5524..02ca2a8 100644
> --- a/lisp/mail/rmailedit.el
> +++ b/lisp/mail/rmailedit.el
> @@ -340,10 +340,11 @@ rmail-cease-edit
> ;; Delete previous body. This must be after all insertions at the end,
> ;; so the marker for the beginning of the next message isn't messed up.
> (delete-region end (point-max)))
> - (rmail-set-attribute rmail-edited-attr-index t))
> -;;;??? BROKEN perhaps.
> -;;; (if (boundp 'rmail-summary-vector)
> -;;; (aset rmail-summary-vector (1- rmail-current-message) nil))
> + (rmail-set-attribute rmail-edited-attr-index t)
> + (if (rmail-summary-exists)
> + (let ((msgnum rmail-current-message))
> + (with-current-buffer rmail-summary-buffer
> + (rmail-summary-update-line msgnum)))))
> (rmail-show-message)
> (rmail-toggle-header (if pruned 1 0))
> ;; Restore mime display state.
next prev parent reply other threads:[~2019-11-19 0:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 5:34 bug#38193: 26.2; Editing a message in RMAIL should trigger an update to its summary line Ed Sabol via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-11-16 10:50 ` Eli Zaretskii
2019-11-19 0:15 ` Edward J. Sabol via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2019-11-19 16:00 ` Eli Zaretskii
2019-11-19 19:07 ` Edward J. Sabol via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-11-19 19:25 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119001503.8CF03203EC@alderaan.gsfc.nasa.gov \
--to=bug-gnu-emacs@gnu.org \
--cc=38193@debbugs.gnu.org \
--cc=edward.j.sabol@nasa.gov \
--cc=eliz@gnu.org \
--cc=esabol@milkyway.gsfc.nasa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.