From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: :extend t inheritance Date: Mon, 28 Oct 2019 22:24:59 +0100 Message-ID: <20191028212459.3uf7usv7bnynfqqd@Ergus> References: <87zhhrmcaq.fsf@kenko.localhost.com> <83o8y6xnmn.fsf@gnu.org> <20191026014911.7riwc5oq6epjhdiq@Ergus> <8336fgvuby.fsf@gnu.org> <357181555.902089.1572117701015@mail.yahoo.com> <83ftjfthnj.fsf@gnu.org> <453335474.949467.1572131620451@mail.yahoo.com> <831ruyu46s.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="92772"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org, ingo.lohmar@posteo.net To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 28 22:25:39 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iPCWA-000Nx6-BS for ged-emacs-devel@m.gmane.org; Mon, 28 Oct 2019 22:25:38 +0100 Original-Received: from localhost ([::1]:44066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPCW9-0002Fh-3u for ged-emacs-devel@m.gmane.org; Mon, 28 Oct 2019 17:25:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43406) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPCVv-0002BJ-8l for emacs-devel@gnu.org; Mon, 28 Oct 2019 17:25:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPCVt-0008DK-71 for emacs-devel@gnu.org; Mon, 28 Oct 2019 17:25:22 -0400 Original-Received: from sonic311-14.consmr.mail.bf2.yahoo.com ([74.6.131.124]:43185) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iPCVs-0008C7-KT for emacs-devel@gnu.org; Mon, 28 Oct 2019 17:25:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1572297919; bh=qWLGGih8dRYOZkRIZIRmrGzCucRU6QOiyi1se+xXXr4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=Zxx8zobyeeZcoGumJ8R3Vs3lsvG7LcOkM4JNa4vyd4fCH2zKj63lzCX4nHu/toLkxAzEXa9AlNPHtNG7q+ReGL27CXEKkZ/uYPwG8ywSZx0xhgl+V5pKAAdGDFQQWxaS7iLcaZRSfTY3yALV22YD1n4Qu0nc/gfOw9zXpAlC+ogX08g6ZZ83jpMt4Ywl6b5ilNY32JoBNDiTpMXn0XNsHHHHXfZwgLUXzv577/2FfEqWOkFwJU8ADkd8LxvJ4z5LAXdQ1f+2roUIbNQS77GlRTBRjg79EGj0nThPn/piJU2tbI0sZv2P/UAXfvPnMqgDPqp7cKrTOLQF+mxY10ct7w== X-YMail-OSG: 6MBp7oAVM1mgynB_XECAoQpO9Gr8AmoKWBJ8kuJqwwZKqY0AVaYjEHgke_0VaEN 9A.hs4BNcY0pI6FPX37WKdohB857ob3.VdXZaKVcNF_o.SwKI5nTMyc62XruCz_Fg2ZxA6u4_rb4 eMJRLrSU0t56zYBGwfbs0lHUoIcEQ8skdtiDjbMkYDKXGlTQqPlnutUL_76e_B_B0vVoA8eJcFKT eGlJOVmBzYKv_.g5YjQL.QfS.qxtUwS4h9PkN2eCgKHTx0iMyDkEHGE6JBUGhHZWSQJ5n9IpnVe6 O2fJ6EPORkLTDR3g_Cb09_5WDOYKrezFf0ZzyH19U9YqyZXgTjeXQc6mQQWqC5eC4Usq4LtLgZQH sUIVapF_zN1IoF91o04KrPzTmkyq9JvmBjyxiXFJV307LsRe4jhB_DkkEyNgSv8S_A3kWaB45bCE IFmxOr.RC15iqN4cG.NtPL7776TL89rQoALSKgJg04q0wCy.EvjNGznbPY.woJgG8me9VglTjhdb vTnKYB6F8pyhrHWaRwrRfMSOrFO6V_6_OLD2RJ7jd_0b.Z90leu3OyD45ufcKKI1kvntOfJ.S6Ys Rqz.YHpV5kbgJ2kVKbEtawlUZ_mqVKIxqbBl69UxbzLxLhPxgSb97Q8e_QcUXoEoKWbw8rGHJ7zg tq6O8t.DVj6ow124e9ERAj8OlgS_RhQ_HRmRGpLEIn.bkYqDfNmkFK2FlPV6mD8wwjoPMtyA29oY p.IZ9ez.FRFnxmCZcF64bYYrmtHNP2Lx386JWHkUubmXLf1JiGnXdNvw_L9WfEfee7dcpFVf0p2H vfnbcD6pk0CjtSuwBcm3_rA7rOXQDhiOnSFmqwFYVm Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.bf2.yahoo.com with HTTP; Mon, 28 Oct 2019 21:25:19 +0000 Original-Received: by smtp405.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID bd3fcfa1f5cb0b72120be68d03da78ff; Mon, 28 Oct 2019 21:25:14 +0000 (UTC) Content-Disposition: inline In-Reply-To: <831ruyu46s.fsf@gnu.org> X-Mailer: WebService/1.1.14593 hermes Apache-HttpAsyncClient/4.1.4 (Java/1.8.0_181) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 74.6.131.124 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241562 Archived-At: Should I merge this into master finally? On Sun, Oct 27, 2019 at 07:51:07AM +0200, Eli Zaretskii wrote: >> Date: Sat, 26 Oct 2019 23:13:40 +0000 (UTC) >> From: Ergus >> Cc: ingo.lohmar@posteo.net, emacs-devel@gnu.org >> >> Ohh right, that's the other commit. When fixing this issue I found another error I didn't see in tui. After EOL we >> need to fill with the merged filtered face. To do that we need to add a stretch glyph; but we were just adding a >> normal glyph with a ' ' so the face was not really extended, just the background color because the X display >> engine always do that. But, for example, underline was not extended. This commit fixes just that. >> stretch_ascent was moved out of the if(column_indicator) because the new stretch_glyphs needs it any way >> and the two comments were 1) for old moved code not there anymore and 2) to describe the situation of the >> glyphs color extension (mention in previous paragraph) that we don't need to work around anymore because >> the glyph fills the entire screen now.. > >I'm still a bit confused: was the problem you found happening in GUI >frames or in text-mode frames? You say "tui", but then talk about >something X does... >