From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: :extend t inheritance Date: Sat, 26 Oct 2019 03:49:13 +0200 Message-ID: <20191026014911.7riwc5oq6epjhdiq@Ergus> References: <87zhhrmcaq.fsf@kenko.localhost.com> <83o8y6xnmn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="63329"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: Ingo Lohmar , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 26 03:50:16 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iOBDa-000GFs-5D for ged-emacs-devel@m.gmane.org; Sat, 26 Oct 2019 03:50:14 +0200 Original-Received: from localhost ([::1]:37874 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOBDY-0004G3-FC for ged-emacs-devel@m.gmane.org; Fri, 25 Oct 2019 21:50:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58965) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOBCy-0003qC-2B for emacs-devel@gnu.org; Fri, 25 Oct 2019 21:49:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iOBCw-0003Yx-2l for emacs-devel@gnu.org; Fri, 25 Oct 2019 21:49:35 -0400 Original-Received: from sonic311-32.consmr.mail.ir2.yahoo.com ([77.238.176.164]:46845) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iOBCv-0003YG-Ql for emacs-devel@gnu.org; Fri, 25 Oct 2019 21:49:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1572054571; bh=fu+lH5Ojy+ssi7MaucsgsH8XBw8o+P6ArcOCvgtyOZQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=L3PNHZYeO+/zN7PKTN03ihKK58Y6eNNU8DcSrivQAc60BUufI2X+l/NcwbvQhQvo1WJb0HVaJH2SFaPFNhh5saNoMPJ6JASf+fmKBtpjU4MAc4Xukw66I6DUh2zIuZmOgWd7PmKWjxjQv/75zSCGzUAEOtb4BhoJD84VMuLqRDzytchxPtqlyVyP3gBkqjfmqWB3LUxVA6YkYsd5+jPcqzOvGp8TWYnv/rj/v6WbuxtzllCgv7yUDkywokwvC5B8+815Jj3Jwp8BB6UbR4alU9sofR8QwEShwGntszkqPAQbZuMPnqm2uqsyXbgzfALUdL3jnaJ7EKrSYri3f6ZXwQ== X-YMail-OSG: FFqTalkVM1lzzwC6qCB4L76ESqO6auBNdi43kuUUIqv_MXnmcytNokoqT0jmUn0 PV2d8atF_EHRI.o_2CXtyQkDLC.aMKeEqrV1mcuPLolWgihFeidMAwcREj6T7QufVZepXioZ5F_0 DSPIPgmZd3rhlS67PNyyt.ObAV0HR9ryYfbnyf0dWA5itzO_os1m9MdVberdUCZlVuWdf1TQddor wa1bmaEDFcS5rNzNR7Ea1aaSesVZ67URFpQBHBX6oa1AwBT_etw6fySI8qAUT2lLlTN5dNKT9DDn nwWYepr2ymgWVAiyluK3Otp9qS2SBtutb4nP_lESVL2pTI4fIWqHxlFaE0udOT84Skhex67QwWTW tHh.kQ1ewqIYRtItAG9dVw.LWevbTzK6UXuU0s2VVO4qXemEkpGEFF71.ewGFEzOnplAHqCDUx3q _uc.agSbF37P9ugKdgB0Vxw6jJHCfdNeS_.A0_4vgCoInPHONkrfjxWU4pqc4js4glomkuYId2Lk rrS6FAVudI2Z.DAsgNX1csxSPlbQvZkIPRF6y3dTidSH2ueDjLIr9sbQqbplIew4OQGIcV3hIrmE BtyhxYlaL6OyKJWGCYTXAjLXPagbrv3khkUqJGpjKDKwjT.Vokesiv7VFJyeQ76svipmcp55ibuQ CRTJBogFto2uz2FguoLh1cv0pJM_0PuCmMJm_hvOVtBrji0MV3wAAOYE9NuP3U7kj_JTdaoBUqvb e4Erpnt9TojvSnafkN1rzSwQMepM3juSuMIFTNAE4EEacaK5TXb5VO8nE7WPLrZwYYSy8T69E0tD 9mwVIoc24WY6ETJrqQeY9kaVPLPJmzfe1NJzF.eEZQ Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ir2.yahoo.com with HTTP; Sat, 26 Oct 2019 01:49:31 +0000 Original-Received: by smtp426.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 51c6d6f2f32349e2fc01114c92932a06; Sat, 26 Oct 2019 01:49:27 +0000 (UTC) Content-Disposition: inline In-Reply-To: <83o8y6xnmn.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 77.238.176.164 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241428 Archived-At: Hi: I just added a branch `fix/inherit_extend_face` that fixes the issue with inheritance of the extend attribute with filter condition. There are two commits because I also detected another issue in gui I didn't see before because I don't use gui normally. Please give it a look and if everything is fine I'll move it to master ASAP. On Thu, Oct 24, 2019 at 04:46:08PM +0300, Eli Zaretskii wrote: >> From: Ingo Lohmar >> Date: Wed, 23 Oct 2019 22:34:05 +0200 >> >> I am messing around with the face :extend attribute and I am wondering >> about sth. The elisp manual says >> >> The value should be ???t??? to display the empty space between end of >> line and edge of the window using this face, or ???nil??? to not use >> this face for the space between the end of the line and the edge of >> the window. When Emacs merges several faces for displaying the >> empty space beyond end of line, only those faces with ???:extend??? >> non-???nil??? will be merged. >> >> I briefly read the original discussion of this feature, but did not find >> a reason for this peculiar behavior when it comes to inheritance; if >> there was a reason given, could someone point me to it? > >I don't think I understand what you are saying or asking. The text >that you cite doesn't mention inheritance at all. Could you clarify >the issue? > >> Background: I manage all faces without themes on my own, and I rely >> heavily on inheritance. As it stands now, IIUC (and according to some >> tests), I have to specify :extend t on ~30 faces (mostly diff, ediff, >> smerge, magit-ediff and -blame etc) that all derive from 3 or 4 base >> faces. It seems to me that this renders the whole point of inheritance >> moot. >> >> My natural reaction would have been to specify :extend t on some base >> faces, and for faces that inherit from them, explicitly say :extend nil >> only for those faces for which I do not want that extension. Isn't that >> at least as flexible, and more in the spirit of inheriting attributes? > >Are you saying that the :extend attribute isn't inherited via >:inherit? Or are you saying something else? In any case, could you >please show a recipe or an example of what you tried and how the >results didn't match your expectations? > >Thanks. >