From: Ergus <spacibba@aol.com>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
Emacs developers <emacs-devel@gnu.org>
Subject: Re: master 2bb0703 1/2: lisp/*.el: Force non-nil result to t, to match docstring
Date: Thu, 17 Oct 2019 04:49:46 +0200 [thread overview]
Message-ID: <20191017024946.6b7vmup4o3v3t3w6@Ergus> (raw)
In-Reply-To: <CAAeL0SSc2A1O+HxkivmJ0Cen5PNkaSoE5q-+MZO2LYJQNB6hng@mail.gmail.com>
On Thu, Oct 17, 2019 at 04:26:34AM +0200, Juanma Barranquero wrote:
>On Thu, Oct 17, 2019 at 4:19 AM Lars Ingebrigtsen <larsi@gnus.org> wrote:
>
>> I thought it was kinda opposite: When it's a predicate, we only care
>> about nil/non-nil.
>
>Most predicates are defined as t/nil, like numberp, booleanp, etc. Usually,
>the code that uses them only worries about the result being nil/non-nil,
>but there are some exceptions.
>
>Anyway, if you feel strongly about anything on my recent patches, feel free
>to change it.
AFAIK: In lisp true means anything non-nil for most of the
purposes. This change I am not sure how convenient is it. It just ads
some extra complexity to read with no benefit.
Maybe it made more sense to fix the docstrings to say non-nil instead of
forcing the code to return t?
next prev parent reply other threads:[~2019-10-17 2:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191017004602.22269.2935@vcs0.savannah.gnu.org>
[not found] ` <20191017004604.866DF20BC2@vcs0.savannah.gnu.org>
2019-10-17 1:08 ` master 2bb0703 1/2: lisp/*.el: Force non-nil result to t, to match docstring Lars Ingebrigtsen
2019-10-17 1:44 ` Juanma Barranquero
2019-10-17 2:19 ` Lars Ingebrigtsen
2019-10-17 2:26 ` Juanma Barranquero
2019-10-17 2:49 ` Ergus [this message]
2019-10-17 3:45 ` Juanma Barranquero
2019-10-17 3:47 ` Lars Ingebrigtsen
2019-10-17 3:59 ` Juanma Barranquero
2019-10-17 7:57 ` Eli Zaretskii
[not found] <<20191017004602.22269.2935@vcs0.savannah.gnu.org>
[not found] ` <<20191017004604.866DF20BC2@vcs0.savannah.gnu.org>
[not found] ` <<875zkonpqm.fsf@gnus.org>
[not found] ` <<CAAeL0SSg8_9vELEeH9BtC02Bpf26AVCgLhpsBSAgQ0nLzXtrMw@mail.gmail.com>
[not found] ` <<871rvcnmg1.fsf@gnus.org>
[not found] ` <<8336frdcs9.fsf@gnu.org>
2019-10-17 15:15 ` Drew Adams
2019-10-17 15:43 ` Juanma Barranquero
2019-10-17 18:02 ` Stefan Monnier
2019-10-17 18:18 ` Juanma Barranquero
2019-10-17 18:31 ` Stefan Monnier
2019-10-17 18:37 ` Eli Zaretskii
2019-10-17 19:29 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017024946.6b7vmup4o3v3t3w6@Ergus \
--to=spacibba@aol.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.