From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Question about display engine Date: Sun, 13 Oct 2019 20:25:42 +0200 Message-ID: <20191013182542.34euwh2gihawyots@Ergus> References: <20191012222305.jpjinkd5y2lz6xiv@Ergus> <83mue5kmfx.fsf@gnu.org> <20191013154052.yzluijtwvf2ppvks@Ergus> <83a7a4ljet.fsf@gnu.org> <20191013164424.4vyxdnm6ievyvjyf@Ergus> <837e58lgql.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="263599"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: rudalics@gmx.at, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 13 20:26:14 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iJiZJ-0016SE-MN for ged-emacs-devel@m.gmane.org; Sun, 13 Oct 2019 20:26:14 +0200 Original-Received: from localhost ([::1]:41398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJiZI-00060E-If for ged-emacs-devel@m.gmane.org; Sun, 13 Oct 2019 14:26:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54630) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJiZB-0005zu-6v for emacs-devel@gnu.org; Sun, 13 Oct 2019 14:26:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iJiZ9-00028S-QI for emacs-devel@gnu.org; Sun, 13 Oct 2019 14:26:04 -0400 Original-Received: from sonic301-22.consmr.mail.ir2.yahoo.com ([77.238.176.99]:44991) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iJiZ9-00025U-Bj for emacs-devel@gnu.org; Sun, 13 Oct 2019 14:26:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1570991160; bh=fJkeNezs5tOK10oxMMvyAoOdS7bZad+0fVumAJ21yyc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=QtJ4P7gMTzbhUrYoVpapXFL5jo62bA10WiaHUqYv5TCujzFdXYEt/eqPoX9opfqM7gWXa2f/nkOBYbTY47vfVRKfgdZJ/86AzxgZ7QUWaBNpEBA7tJM/xZv8mraw99Q1DiRKPn1iGXk1aSq3+lm42E5i/S0ZXlbi1WC66nvNQ1uzhYuTBOoEeRaZyXM31sDvsfeTbnIP5MiglUSVE+0YWu/+WUCZ7lTe0rn6OMGzIc80WwpYGlA0NDECA09SPhQchW/dF9f/BMAuOG6ZjgStPsGMnerYtq31pnEPrHSNhPuRxjmnRyJwRCrWTU44+QgBqjyCU78c+KNig2l6mDiyng== X-YMail-OSG: 8vaxqmkVM1lfOAL6eI7qEbzuNkIopTmOkoQvk2PbzRf6SSv.NIi._uy_vif626e YmVhku2HLoRbVGoBqBFwHpT778axJiA1cqbm875f9HyNHG_EZNFofPfJuodA2DmQBgSh4A2m2NVX aZSd_6fTK97YYckGZ8ifAWrc51.nb79FhyBGqPx.iSZt.ZIWE8GGG9GPIm1m5kiwOri0rWE3It3L UEy1nV5GsujP13yn8XD3bJHllM_fEkWH88NpOeZTs8Q6FkwJq_KZrmhpJD9YHbGesYEgaD35rs0P TD4wFO.WreFtgpPD3Ua1OhJLiv4jULG_AZy0Y3nBKNl0nOyejvJ4Sxh42L.Uo.XDyxWuKIKUrVXI pFUt7bhF_p1mh4JItj.HFxLNI2SHRnF1cEp6mpLpXQhAMqWBpbkqTrdoth.nMh3NxR6I7qiFxXkz _Rse7AbmeUfellr_boubP9SGZTnMZrLgKnx3P1.Le03B1rwVpdtolsVmiR3OnEF4xvXiOKqto6Dd jyG323X4mZmaTCWXorR31k3gpjIeenuGth4b.kyYsz16YeVPs__a6uFqjvSnutgrZx66G6GHYreP 3Flv592JSPfa8BqEzd1CnymqlxRN9gA0BCeiwU2xmjqxu8FWK830lI0XVG5_CukTcGC6cz2O8go0 n6ZrM9Y6z4E8V64uQzzSYQk5FE7xCjKkEo2KpdHuU1GvwQM.QjhSCfdFKU5tuBZ_dnUQ1z7DyWfr 17gPRXgZcpvLd7u799KK1jkUCHHhDn.Y6aGWHPIv90fPp8TwPgRQsOIi6goXT_snsX8giE5DBOgM XrwXJ2lM0F0E_D6o1bXlX_sM9cXH8tUwQfTAMMT6Xg Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ir2.yahoo.com with HTTP; Sun, 13 Oct 2019 18:26:00 +0000 Original-Received: by smtp409.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 5c183313a823fee7d213c0579e4e82ff; Sun, 13 Oct 2019 18:25:55 +0000 (UTC) Content-Disposition: inline In-Reply-To: <837e58lgql.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 77.238.176.99 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240975 Archived-At: On Sun, Oct 13, 2019 at 08:04:02PM +0300, Eli Zaretskii wrote: >> Date: Sun, 13 Oct 2019 18:44:24 +0200 >> From: Ergus >> Cc: rudalics@gmx.at, emacs-devel@gnu.org >> >> >Could it be that redisplay_window_0, or some function it calls, >> >signals an error, which is caught by internal_condition_case_1? What >> >happens if you put a breakpoint in signal_or_quit, does it get called >> >from redisplay_window or some other function called by >> >redisplay_windows? >> >> Yes, actually: >> >> #0 0x00005597732a0380 in signal_or_quit (error_symbol=0x2cd0, data=0x559775ee2633, keyboard_quit=false) at ../../src/eval.c:1586 >> #1 0x000055977314c308 in Fsignal (error_symbol=, error_symbol@entry=0x2cd0, data=) at ../../src/eval.c:1568 >> #2 0x000055977314c4c9 in xsignal (data=, error_symbol=0x2cd0) at ../../src/lisp.h:4139 >> #3 0x000055977314c4c9 in xsignal2 (error_symbol=error_symbol@entry=0x2cd0, arg1=, arg2=) at ../../src/eval.c:1713 >> #4 0x000055977314b76e in args_out_of_range (a1=, a2=) at ../../src/lisp.h:1032 >> #5 0x000055977314e97b in validate_interval_range (object=0x559775cee0d5, begin=0x7fff35ec34b8, end=0x7fff35ec34b8, force=) at ../../src/textprop.c:158 >> #6 0x00005597732f4050 in Ftext_properties_at (position=, object=) at ../../src/textprop.c:572 >> #7 0x00005597732f40bc in Fget_text_property (position=, prop=0x5d30, object=) at ../../src/textprop.c:592 >> #8 0x00005597731f8eec in face_at_buffer_position >> (w=0x5597758e7620, pos=0, endptr=endptr@entry=0x7fff35ec3650, limit=100, mouse=mouse@entry=false, base_face_id=1, attr_filter=LFACE_EXTEND_INDEX) >> at ../../src/xfaces.c:6090 > >Then looking at the position that causes the error will probably tell >you what's wrong. (Is OBJECT passed to Fget_text_property a string? >if not, position of zero is invalid.) > Actually conditioning the call to face_at_pos to when IT_CHARPOS (*it) != 0 seems to fix the issue with magit... but maybe we are just hiding something under the carpet here. Can you imagine something more general than that just this condition? Or what could be doing magit to expose this and not the other packages?