From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Tabs Date: Wed, 9 Oct 2019 12:39:36 +0200 Message-ID: <20191009103936.qjdwuidqnowswojw@Ergus> References: <20191007192836.phg3nhjj56dz3ui2@Ergus> <83a7abznro.fsf@gnu.org> <20191008085604.tjtxm6ndyuluocbs@Ergus> <83lftvy4s6.fsf@gnu.org> <20191008160038.6xvnytnoruzphzd6@Ergus> <83zhibw6qn.fsf@gnu.org> <20191008164048.bnad4wdkcbatqepp@Ergus> <83v9szw4o4.fsf@gnu.org> <20191008234350.ahxt4zcylxqludoc@Ergus> <837e5ewc0a.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="258484"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: michael_heerdegen@web.de, juri@linkov.net, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 09 19:10:46 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIFU5-00158U-OE for ged-emacs-devel@m.gmane.org; Wed, 09 Oct 2019 19:10:45 +0200 Original-Received: from localhost ([::1]:52828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIFU4-0004uH-59 for ged-emacs-devel@m.gmane.org; Wed, 09 Oct 2019 13:10:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57617) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iI9Nu-0003Hf-Cy for emacs-devel@gnu.org; Wed, 09 Oct 2019 06:39:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iI9Ns-00050u-RZ for emacs-devel@gnu.org; Wed, 09 Oct 2019 06:39:57 -0400 Original-Received: from sonic309-24.consmr.mail.ir2.yahoo.com ([77.238.179.82]:46103) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iI9Ns-00050f-D7 for emacs-devel@gnu.org; Wed, 09 Oct 2019 06:39:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1570617594; bh=wyEaMQhfQDTTLIJmSpCALt7J9xqFnBZw3YYz45NRTSU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=BAIj6vrQkxVJWAxU2HFD8KLijZ88wW35OafszF0mloridbdVxKfUqXJMQnjRXHNh8c+Z42NxRt4SAqWylXg1ll1olbS7qc4YTiwRq21DA9Vp3AaWn2xRyi+EsFeRwtlqqnkv9E57pxGH2pEcep4Jo3rjNAo+b0MIEfnmSNpmPdEZF+vZUXN4hMvGLUAPXko1BFM7ynAsS3ZTTuAuqswbbYhMhjbb/UhnEXAubSaE9UiyeEWIu2yWQ01BIZj0gfjlB/yukbhye9oEx7AqA/OHfbhec4yYSm5CLMzvbuXQFOqQIpIhUNg/zKo3zfEylbVb/mUCx/kQZPr1lLbo7E+c5w== X-YMail-OSG: sQyOpMgVM1nxS6a0U2KsTxgXQ15Z9PlNreTyDUmbIbdGwTcp.kxnSWFm_btcJ3w lH4wkbNsUGo4YLX4BN0sCGiQ6kjkB01zXoR23Fwt3IrwrISe1xBaWMv8qEgtbd7kPuD6TyaQeRF1 ItaAJq1UTYYemRt7JH0CJ_0bGDWDDRLjKPj6b7q1_8arbJjDqq1QdUYEOG66PG_Rpg9dryNJUoz. kVeuwvSK1RBHwpN3am0O9Ifmd5CiGRaJv1V0OJM.HexX_C8tBzqII_szqqPjQxoUeSRrQ3Ghfhmz bwDdhR1rCEEjmjnmj4rErxxVvknkcEIn3nABW8czjzK6OubNMHPT1g7pMCfGVJyLBnzFSRhOyFv9 6qG0r.q4AVaUWIImzARuiJ.YEkzZ.73ABn8JRer5UIVaPecdqsHndas4QbyY6YAC26lz9Uwf.FKl RXmVioekACKteEdh9pyJm52fJDyIDVgAxAGMTo11o78akTjhTYQm6Tt4fi2.oXps3Q969GQXJ6Vh 1kVJ1GtmmszB7Q04izKP6zUzzjw5Qw7tEB3JJ0nlA3NPWDzl1YOP3yIM9eG1HjPcjemxiLkuc0IE 1racyUJfEircp6T5SDmOf68c6Wx1lZt3xIt42FWveb3guYAcsgVr08LFnsB6.HvHAnvG26ya___v sCvOhd8JspSbgy4Z997bRzel0axJFu5QYWUu6J.rdRUU2gkLtL_qDKqLKSEwor1tjzOhyZ_dUH_Z rxv6sk.RukS1uZwYa2miFXnBinAjU4lTx46svX6D7yTil9CfJzB.zi44XQ3nhCO0TBLr1jdHqK0l TL1mez_mok1tX8YQS7QLGImwpf8waOM6EeRG5tJsld Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.ir2.yahoo.com with HTTP; Wed, 9 Oct 2019 10:39:54 +0000 Original-Received: by smtp404.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID abe754c9d757ba7f564bc59731dfe878; Wed, 09 Oct 2019 10:39:49 +0000 (UTC) Content-Disposition: inline In-Reply-To: <837e5ewc0a.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 77.238.179.82 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240767 Archived-At: Hi: On Wed, Oct 09, 2019 at 11:37:09AM +0300, Eli Zaretskii wrote: >> Date: Wed, 9 Oct 2019 01:43:50 +0200 >> From: Ergus >> Cc: michael_heerdegen@web.de, juri@linkov.net, emacs-devel@gnu.org >> >> > if (FRAME_GARBAGED_P (f)) >> > { >> > fset_redisplay (f); >> > f->garbaged = false; <<<<<<<<<<<<<<<<<<<< >> > goto retry_frame; >> > } >> > >> >(if your repository is up to date and you are on the master branch, >> >this should be line 15690), does the breakpoint fire after you type >> >the "C-x 6 f FILENAME RET" command? >> >> No actually. I only get some messages: >> But nothing else; the breakpoint is not reached. > >OK, so this is not due to the recent change which introduced the above >code. > >In your original message you wrote: > >> This used to work fine before... I just pull and recompiled (since >> saturday)... > >Can you tell what was the latest date when this problem in GUI frames >didn't exist in your builds? > >> Something else I observe is that when I leave the desktop and return >> back; the tab-bar is visible, but with the cursor there. When I move the >> cursor horizontally, the tabs image is substituted with the text that is >> supposed to be in the first visible line that is supposed to be bellow >> the tab-bar (attached image with the config.log open.) > >Yes, these and other symptoms you described all tell one thing: that >some redisplay optimization is taken that shouldn't be used in this >case. IOW, Emacs optimizes redisplay ignoring the fact that there is >now a tab bar, which usurps portions of display that previously >belonged to some window. I just don't yet understand why this >happens, because the call to SET_FRAME_GARBAGED in >x_change_tab_bar_height should have had the effect of disabling all >the redisplay optimizations for this frame... > >Does the change below fix this problem, per chance? > >diff --git a/src/xfns.c b/src/xfns.c >index 20e63a2..f2264be 100644 >--- a/src/xfns.c >+++ b/src/xfns.c >@@ -1660,6 +1660,8 @@ x_change_tab_bar_height (struct frame *f, int height) > > if ((height < old_height) && WINDOWP (f->tab_bar_window)) > clear_glyph_matrix (XWINDOW (f->tab_bar_window)->current_matrix); >+ else if (height > old_height) >+ clear_current_matrices (f); > > /* Recalculate tabbar height. */ > f->n_tab_bar_rows = 0; It solved partially the problem, which is good. 1) The tabs does not become visible automatically after C-x 6 f, and C-TAB works as yesterday. 2) But when I leave the desk and return they become visible but this time they are clickable. (unlike yesterday) They does not have a cursor as before and the first line is after the tab-bar as they should. So it seems that the problem is related with this.