From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Native line numbers landed on master Date: Wed, 2 Oct 2019 00:52:54 +0200 Message-ID: <20191001225254.mwjnxlynjdc3mz7y@Ergus> References: <834l4xbfmp.fsf@gnu.org> <87ef414dfn.fsf@wavexx.thregr.org> <83o9359w3l.fsf@gnu.org> <83eezycce5.fsf@gnu.org> <87muekj0i9.fsf@wavexx.thregr.org> <87d0fgagjl.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="62897"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: Lars Ingebrigtsen , Yuri D'Elia , Eli Zaretskii , Emacs developers To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 02 00:54:12 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFR23-000GCh-Lw for ged-emacs-devel@m.gmane.org; Wed, 02 Oct 2019 00:54:11 +0200 Original-Received: from localhost ([::1]:49182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFR22-0005tW-GE for ged-emacs-devel@m.gmane.org; Tue, 01 Oct 2019 18:54:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60973) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFR1D-0005rp-6b for emacs-devel@gnu.org; Tue, 01 Oct 2019 18:53:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFR1B-0003hn-T4 for emacs-devel@gnu.org; Tue, 01 Oct 2019 18:53:18 -0400 Original-Received: from sonic314-20.consmr.mail.ir2.yahoo.com ([77.238.177.146]:37499) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFR18-0003dx-0Z for emacs-devel@gnu.org; Tue, 01 Oct 2019 18:53:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1569970388; bh=sKVlB9+S6h0PGvDI0cr9qs2HXlWPmKD0Aw2/ien5Ypk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=t6oBbqKOO6aoACJRQqzM4N6rPSx+vAnK5yZLN+wRWtWIka3Ex6azNg2sZSzMsMLkPolJ4rYt/YWh5US9R/er0M8w2I4cZmHRKaWpFVRXUUB7ybrwBDe46qx8MI4r+7qnYUiZagtPploURJus1tyYBJoFmXR1HJlpgfyoYYxQvdizpQn1rUkRTxbLLohYHVI0ebHSFXiBMHhCIbqT9hf/r2DcQEhDOXfrqgn+kXTqiGpBhQZCCfWc/T4uCD60+M5LyKVisn/nGaHlbrYm7Rw1UsND0+KgdA5a0rajw5o3CBgucaN3al2cCNvvFu8AsEQwp04eRvIEOyLxQDBGNM21uA== X-YMail-OSG: VauKCkgVM1nPacQiQFGABVyuaYU5VMhqwIckwsOrgQIwzLne6T0yOaGfEC.H1Hu KaL3Wb0nU85htmRkIhb2Q9vZCs0EaiVUFyMXm57K5CPFdtDa45t4NtSE2taJr4_.NWysQ6Fhz7PJ qZthvGMAow5he084pMHZnOWOKslIMHsHEzk9a7w2B56i45L.pAhbedFgsASJDIIlI..gywvYiWwK 0zM8kasvaEEADrz_eOAPcSYWOoHkdLDbfPTNPuR0qrXVb_TOSfPRU6fAVUUoyGtjoZ6gcHqrCyfN WdZ3axGWm3Vwjt7OzWxjLumfIrUps24BrhUGFox5udKPWFk8gq4f934B3N3e8gJZFG3oTya8es.R 0Iys5ACgwQS3zV9DhhmUc7FM4DHixc7Slwo32sMS.eYAHxria2sUrbfz4ea4BGv9IvOE3pkVX6Lv KUZgcS293qqnG4I8DObSqMbvPkEETaiftVhiKA4cKsrlnM.LNH7UQqNeXbN9WgVubdeL4U47d2HM _q.asD0sVMXLC5egytf2UWz1D.nxFNZKc9Nx5UTHPGogSZgHMUKj64s5MKtwHZdQSoPES62inl4A L8SsPB4t4WPz8Eb_ES4Pj1hgElzylwZzBvPVkiDK1a08_ub83lzPw4dgw2E41ahVG1pyA00jvERB SgT1znsFHLb5L_ydFYBQfmKynpyL7RAFeCk2G5hCOXIfcYzJdobj8em5_MuuO_OI1wH11QC8v685 URrqXHcTR7x1OygrVEqqnl_X6TgzouRVccqGhe4i8cHLDcJqFmtn4m0MOBdLQD2szT_hx1s28mxh YtjQiymfLOp.OcQfzY1d7l3KO.M6Y_AiUy9Zyuva_H Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ir2.yahoo.com with HTTP; Tue, 1 Oct 2019 22:53:08 +0000 Original-Received: by smtp422.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 3dc77f68a320c91b0faf9966a0640e23; Tue, 01 Oct 2019 22:53:06 +0000 (UTC) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 77.238.177.146 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240453 Archived-At: Hi Juanma: I would like to suggest two small changes to the patch if you agree: 1) I don't have any strong feeling about using one or two values. But in any case they should be configurable. This will add more use cases that could benefit with this and I think it will be simple to implement (just need to add 2 int variables). 2) Is it possible to call merge_faces more lazily? I mean inside the `if` `else if` so only one of them will be called when needed. AFAIK maybe_produce_line_number is called for every line and the code needs only one of those merges every 5/10/x lines. (This will benefit more the user who sets the values in 1) bigger) Very thanks for this contribution. Ergus. On Tue, Oct 01, 2019 at 01:11:38PM +0200, Juanma Barranquero wrote: >On Tue, Oct 1, 2019 at 12:47 PM Lars Ingebrigtsen wrote: > >> What about an alist? >> >> '((5 some-face) >> (10 some-other-face) >> (100 yet-another-face)) > >There are many things that could be useful, but Eli already said several >months ago that he doesn't want to add bells and whistles that would make >redisplay slower and more fragile. > >My patch implements (more or less) something that he said back then that it >would be acceptable.