From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#24022: 24.5; C indentation failure Date: Sun, 29 Sep 2019 08:13:43 +0000 Message-ID: <20190929081343.GA3993@ACM> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="57779"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.10.1 (2018-07-13) Cc: robgssp@gmail.com, 24022@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 29 10:14:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEULO-000EvO-SG for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Sep 2019 10:14:15 +0200 Original-Received: from localhost ([::1]:37330 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEULN-0004Es-0m for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Sep 2019 04:14:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57824) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEULE-0004Eg-M1 for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2019 04:14:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iEULD-0003l9-Jr for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2019 04:14:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43336) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iEULC-0003ho-24; Sun, 29 Sep 2019 04:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iEULB-0007Oc-Rs; Sun, 29 Sep 2019 04:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Sun, 29 Sep 2019 08:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24022 X-GNU-PR-Package: emacs,cc-mode Original-Received: via spool by 24022-submit@debbugs.gnu.org id=B24022.156974483128404 (code B ref 24022); Sun, 29 Sep 2019 08:14:01 +0000 Original-Received: (at 24022) by debbugs.gnu.org; 29 Sep 2019 08:13:51 +0000 Original-Received: from localhost ([127.0.0.1]:52157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEUL0-0007O4-Sy for submit@debbugs.gnu.org; Sun, 29 Sep 2019 04:13:51 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:14979 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1iEUKy-0007Nu-Fi for 24022@debbugs.gnu.org; Sun, 29 Sep 2019 04:13:49 -0400 Original-Received: (qmail 34987 invoked by uid 3782); 29 Sep 2019 08:13:46 -0000 Original-Received: from acm.muc.de (p4FE15D9A.dip0.t-ipconnect.de [79.225.93.154]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 29 Sep 2019 10:13:43 +0200 Original-Received: (qmail 4609 invoked by uid 1000); 29 Sep 2019 08:13:43 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167619 Archived-At: Hello, Stefan On Sun, Sep 29, 2019 at 07:02:35 +0200, Stefan Kangas wrote: > Alan Mackenzie writes: > > Hello, robgssp. > > In article you wrote: > >> c-mode fails to indent correctly when a #if is followed by a > >> comment. Example: > >> int main() { > >> #if defined(a) // comment > >> if (b) { > >> body(); > >> } > >> #endif > >> } > >> Clearly this isn't the correct indentation. A clean run under -Q behaves > >> the same way. > > Yes. > > Thanks for taking the trouble to report this problem, and thanks even > > more for cutting the source down to a small, easy to handle test case. > > There have been extensive changes to CC Mode since the release of Emacs > > 24.5, and the problem isn't apparent in more recent versions. Bisecting > > the changes in mercurial suggest that this bug was "solved" by a commit on > > 2016-05-29. > > I've tried to adapt this commit so that it will apply to the Emacs 24.5 > > sources, but the changes are just too many for this to be practicable. > > Would it be OK for me to send you a tarball of the up-to-date CC Mode > > sources (~1.34 Mb) so that you could build these on Emacs 24.5 and check > > that the error really has been fixed (and not just in the cut down test > > case you've sent me)? > Hi Alan, > It looks like this has been fixed, but you were awaiting some further > verification from the reporter. Did you ever get such verification? I never did, no. > If not, perhaps we should just close this if you can't reproduce it. We should indeed close it. The problem has been solved. > I can't reproduce it on current master using the example given above. Indeed. Does this go under "wontfix" or "solved", or some other status? I marked it as "wontfix" in my own bug log, since I couldn't reasonably fix it in Emacs 24.5. > Best regards, > Stefan Kangas -- Alan Mackenzie (Nuremberg, Germany).