From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Question about display engine Date: Mon, 9 Sep 2019 15:56:02 +0200 Message-ID: <20190909135602.i36x4uxhbzczbq6x@Ergus> References: <318675867.1913640.1567711569517@mail.yahoo.com> <97f66744-8481-084a-ef23-2c50444e1f05@gmx.at> <20190906093117.25qfim4kcrmiqunk@Ergus> <83o8zw5zh8.fsf@gnu.org> <83mufg5yn1.fsf@gnu.org> <20190908005109.s7hhcczkrcbzewdc@Ergus> <377a8380-af26-776f-de79-2e24cc14e0e4@gmx.at> <20190908125306.mhb2eg7nxjs5z5pf@Ergus> <36b5122a-96a7-b798-1fed-423ea388b772@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="12597"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: Eli Zaretskii , emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 09 15:56:54 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i7KA1-00032U-Jf for ged-emacs-devel@m.gmane.org; Mon, 09 Sep 2019 15:56:53 +0200 Original-Received: from localhost ([::1]:57044 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7KA0-0007zB-94 for ged-emacs-devel@m.gmane.org; Mon, 09 Sep 2019 09:56:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35472) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7K9T-0007yt-NF for emacs-devel@gnu.org; Mon, 09 Sep 2019 09:56:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i7K9R-0005Et-NE for emacs-devel@gnu.org; Mon, 09 Sep 2019 09:56:18 -0400 Original-Received: from sonic302-20.consmr.mail.ir2.yahoo.com ([87.248.110.83]:46852) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i7K9R-0005CR-6C for emacs-devel@gnu.org; Mon, 09 Sep 2019 09:56:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1568037375; bh=S1yknpPHXo79kS/aOszq9jmQf28ztTUuLI0uEyvL7ls=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=kJyTu/7lOZp+AE9XCSVDVYfAH6jQPGJtIQIcw+oyPHZV4VHmOlAxpbJ6kSrhlwZVZvtdBh+H+iQtX9p7PbA0xgKjRNAHLb275ZRfT9brTk2e05Z0mOz2Tp9SYjlbcIorpTSLjH4UXZ8GWhALcXCK5PFUoBKzjsVsj9A+7rPxQqJ/Fu5IEMMIJlY91+ePJnapvs5NnwGqDWNbqfOxJXt+GoMZdD3EPFgXOHz2LqoYw0k/h8sRknc0zRF49wOZw7fMa4Eej3knzCimTT3IXhfryBBe3HajTTmYyOkgDWg3jPVwBrn2tw94lpQUHXltlN9HDr7s8RnY+oaXxuMhlVgYRg== X-YMail-OSG: EfgDqhkVM1kmWtGWpl8lGgPN0xKZgc.ocCxe0asQFI_yhM8PemdtD81Qy5ElVnv JEuhjlOU.8CgY2o7Jk54AeSF.dHah6AQc7zEIR_d_u1x7XHlhO0wAcb03GEWw7WrEVNK6EovG9ee L_AnFMI4722cT57P7UWpkpJBq3BST42V.Ok6337A1BGQ7z2533EX4mZqYJoT5shOgYRZMCA5JoQ. 0xkBHF1mF0SxZm1dpIyXSBCZPtq6gSjISKivtbFlSctgbig57VHrsN_D_JIoprUaC1oW.YnoUoyc PfRlqN8ahy6vPvGRZSPkRhlcj.khbEhBCv0V6Zm1wxM2RgipehxEk4cBz41QfvMG0qqA7QTX3GfH 4uUwz2qC8maa7P8Ttn1PUXRybO2E.Bxu724MZJ2n81ok9ED2lnZOI2edLZf.KfnUuiW_3q8m1V0Q V_bgMotE36QGo4JX6ZH0BwRNJX03f3AOqoCuYKjl7T69Gor5_KmhH66VpNcXqbJpXZiFnRJD7jqi e8zCXyVSWLhKig9ZxIKx8JCWeBlyMc2yzfE16CospWIIUE7ZWLpdGc0eutKC.x9TfQQrQL8Mu6rw TAYBepGxynkrGRTjeAjL8j_abeWFDQNqHCIprKKdiO0LdQtizhF__4xVMaWCq_0uWDA5p3oqXySC ugsf9C6z5bGTp1LgFSb8vSw8T6iJIKmvoMJPuxccsL7E3u5vYMt87IcdkomvuLhV0WLRR1e1nl3N J5tNgS5ENJwy.Dc2ceRjqlFxL8jHQkDZoMvmWdQ2D778MwfHegeQpAUmlcaxyeM9JHZ23zVuGrex 9eTRvCaxwHTJFbIxOY1LGVoJT.8Ak3YnZCcX09ubQs Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ir2.yahoo.com with HTTP; Mon, 9 Sep 2019 13:56:15 +0000 Original-Received: by smtp428.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID c63371c3cbb8623eb4e3985fc4a899c8; Mon, 09 Sep 2019 13:56:10 +0000 (UTC) Content-Disposition: inline In-Reply-To: <36b5122a-96a7-b798-1fed-423ea388b772@gmx.at> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 87.248.110.83 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239954 Archived-At: On Mon, Sep 09, 2019 at 09:39:13AM +0200, martin rudalics wrote: >> I fixed that, try now please (it is in savannah already). > >Thank you. Works now as expected. > >I'm still not convinced that it is a good idea to unconditionally run >handle_face_prop_general from extend_face_to_end_of_line. It will >penalize processing every line shown in a window even if no attribute >processed is affected by a nil :extend attribute. But if you and Eli >think it's cleaner to do it this way, I will not object further. > >Thanks again, martin > Hi Martin: I actually don't agree either... but the merge process is a destructive operation (like a binary | ) So it means that we lost information during the merge process and we don't have a method to know the merged faces only with the face_id (in the general case) and mergng different faces could produce the same result. We can do some optimizations like condition the call if the face_id at position is not the default face for example. Or compare with the previous call result... but I think that only Eli can suggest which are applicable in this case.