From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Question about display engine Date: Sun, 8 Sep 2019 14:53:06 +0200 Message-ID: <20190908125306.mhb2eg7nxjs5z5pf@Ergus> References: <318675867.1913640.1567711569517.ref@mail.yahoo.com> <318675867.1913640.1567711569517@mail.yahoo.com> <97f66744-8481-084a-ef23-2c50444e1f05@gmx.at> <20190906093117.25qfim4kcrmiqunk@Ergus> <83o8zw5zh8.fsf@gnu.org> <83mufg5yn1.fsf@gnu.org> <20190908005109.s7hhcczkrcbzewdc@Ergus> <377a8380-af26-776f-de79-2e24cc14e0e4@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="75057"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: Eli Zaretskii , emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 08 14:53:57 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i6whW-000JO8-O2 for ged-emacs-devel@m.gmane.org; Sun, 08 Sep 2019 14:53:54 +0200 Original-Received: from localhost ([::1]:48668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i6whU-00040Z-VC for ged-emacs-devel@m.gmane.org; Sun, 08 Sep 2019 08:53:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45449) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i6wh1-00040G-3f for emacs-devel@gnu.org; Sun, 08 Sep 2019 08:53:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i6wgz-0007RY-AN for emacs-devel@gnu.org; Sun, 08 Sep 2019 08:53:22 -0400 Original-Received: from sonic305-20.consmr.mail.ir2.yahoo.com ([77.238.177.82]:34199) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i6wgy-0007Q3-LP for emacs-devel@gnu.org; Sun, 08 Sep 2019 08:53:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1567947199; bh=Vv4UvlFM7fWIuQnZvhMZW7fO8ObxrIX1cBC9yW/ddWU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=YY1u71HS4J/2KhT8AhGWcmeQJh7Lpdp10Qhe77VvRbfyR+dNgrGwCDoO2hVXbU+C/k+M1afLqgd1mPPQGQ/57D8889J1WfaJhidzMJjg35AYvh2tmvEQYQoihGK3n8+4jIk+RAscxpYf2NVLj2WdSaafzuJTaCNyFGKMyaBL4eq1ggXW+30phuAPy1sSoEHFJJaqPvfTIvOqNAcqJ+7hGlJz7owlQfMPdnkszQHSWgfztGRFtcVAvavkzAooZnBNwI32LygdKuYQDbDT7zW9Xb/J8St77GEtjON1n9H0zXIJm4DvLAzmd57zUlmow1iQ9lKou6Eojp90/uGfOq0qtA== X-YMail-OSG: 2UAwBQcVM1nnfR6JKa4S9Z408XhTLVjlFrx7cRkEwZmSgZDrSk7xaxWp0oRc.1q p3OUvYAhahBYasRZ8PxsR_yihDjSAalWiz_hdpAACulauTJ__rVteHeu7Gcm.09f_o3h5MAUjCSR WJ4gCX40iA2aJRGFtf59MdFsWw443ttytWiUs0coBDVb_IWplzWdh4nYLgxDIeAzJHAnDHx7MquA _fYz6PAk5MlzPIx37UMFpDJZxEuKVZ3XERmlPISEqmhwOAAmca9erkBfAXZD3B2HYwNFauiSugU7 3SEsxbsUxeCyV9E7FY.EcXPjJ_XNKRn6wSrUY03H9LWY_R0hF8FJZBBTbyAL_GvLIGWSXydtqvXw a0ZD11DuUav9G5u0iIIr040e.22csdeCCtmmYpRZMV48VMEpFr2_cRrcszYBzFVwvVGCRRIzQk1S hhyJgPvKxGghoKO1tTAJkkjiU2CHf67zY9k51NbHLbJ0FIW0lOR6HDy43zNwrw57CazBkDASe4uV 0ZseLCz_h2VbhJLUbe3fzXmBkXiOxbkjFOUlNRebAANq8DjVuqjf4uEfIt55pyZMQOdrqqIPIOFj u130kjd0LiSI.VEPvOAo5lsSwf2_pTolzKR4UdGKVRljTSwwfkG4pS0FabX2iqTWQ.40RQ_CfOi6 hmT12iT8dPDdJrEyTi3ks1rSBDaCDNNXLIrTTXeV0ryZ6Fe7aoLfQ2zoW74OHjvXokZgu0rP7rqL 8PlCO3AS80qQhan1unj77TnAhL6RRnfWXsSNnPb_Ch6RKAJf9as1R5_41T2adzJdR5cU_NzI6ot_ nEJDJyX_gXDWvFpZuQTUeZ5swouGols9NSZZsd_4yo Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ir2.yahoo.com with HTTP; Sun, 8 Sep 2019 12:53:19 +0000 Original-Received: by smtp416.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 42775847ea9798b869a8e07d7d342b0d; Sun, 08 Sep 2019 12:53:14 +0000 (UTC) Content-Disposition: inline In-Reply-To: <377a8380-af26-776f-de79-2e24cc14e0e4@gmx.at> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.177.82 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239938 Archived-At: On Sun, Sep 08, 2019 at 10:40:42AM +0200, martin rudalics wrote: >> Please give a look to the attached patch and check if it is working fine >> for you. (I added a new branch "extend_face_id" in savannah too) > >Thanks. The problem with my standard use case on your branch is that >when I customize 'font-lock-comment-face' to have a specific >:background and :extend nil, the background I specified nevertheless >extends to the end of the line. So I wonder why it works to not >extend the region while it apparently does not work to not extend >'font-lock-comment-face'. > >martin > I fixed that, try now please (it is in savannah already). The problem was the merge I was doing in face_at_buffer_position which was unconditionaly merged for props. I conditioned only the overlays. It seems like font-lock-comment-face is a prop while region is an overlay. Right now as I modified merge_face_ref the conditional merge only works when CONSP (face_ref) == false and I am not sure what to do to make it work also for CONSP (face_ref) or if it even needed...