From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Question about display engine Date: Fri, 6 Sep 2019 11:31:18 +0200 Message-ID: <20190906093117.25qfim4kcrmiqunk@Ergus> References: <318675867.1913640.1567711569517.ref@mail.yahoo.com> <318675867.1913640.1567711569517@mail.yahoo.com> <97f66744-8481-084a-ef23-2c50444e1f05@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="92153"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: eliz@gnu.org, emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 06 11:32:58 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i6Abw-000Nnx-PW for ged-emacs-devel@m.gmane.org; Fri, 06 Sep 2019 11:32:57 +0200 Original-Received: from localhost ([::1]:53826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i6Abv-0004ia-JL for ged-emacs-devel@m.gmane.org; Fri, 06 Sep 2019 05:32:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35102) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i6Aad-0004iS-G6 for emacs-devel@gnu.org; Fri, 06 Sep 2019 05:31:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i6Aaa-0005rU-IM for emacs-devel@gnu.org; Fri, 06 Sep 2019 05:31:34 -0400 Original-Received: from sonic308-17.consmr.mail.ir2.yahoo.com ([77.238.178.145]:42708) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i6AaY-0005p1-Tv for emacs-devel@gnu.org; Fri, 06 Sep 2019 05:31:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1567762288; bh=j9pnMovVQ7aCP5GKRbJQURMb72qnQvnaYuYeZzXmwJc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=hsCv4OzziMjjkZ/a/GaS+HLCOtgB4dx4zXhgudqymeDefB0RVT4M7ksKspqU4O8rpllUuM4w4xQx1qzSNbVVjowYCKoo+HpOWUKOwjHO2R+I8M+S4EYi8JbphRV2Lbi+R5Lnn7rR55af46DlAfAAv/cZlGishNd1DcxTNYYQN+Kl2emXNW8hAr4IhYbmlKnEy8MF94ZnweE1VRVNK3Dl5EW/Brp+g5hMnwBiuoVLcZL33KvNCIQQAaYeWYmvKY1PFhxtrOc8VSt2u6P1tsDTYBCs1Zt5z+LdAqa6A+U6GFL9n83VBuqTg3y6fVcx+2oLofyhfifeedWMAhYnEJaUZw== X-YMail-OSG: VNnE0IEVM1lPnN8XETEQiusDrbharjJOlLFX6wgRKehraeHbkI7GijDcxvHhtUv Ix6sYaR0IZpH622RjrnNimIhXF.7ovglN7Anc9eBTr6w_VW7Ou7M6CPRpWXDaB1j0Hp.sR_OTQqc J6ta7BgrS1jgAaACKBCQ.dhQBRMs9ksat8Hz.gh0sEdaQytoD.VjBdrJMYpiQv.9iW.INoM_bntJ 46Li6YtU5s3rz8V6TxzAYT4Wiwztnd1UrpwUo7QVHpp65ug41TAF.j6DXu8ZqLj.TPRZXxmVsNw0 1jVHOA7KbEduMM5CcNqrmGcuupRJ3w6QH995My.Y54aKL7n.aVa48.qYeS9Q4UhOv19bBPL78stn Rmstmj4OoCen8xKMqccpr16j93nb9bY_xI_qqLBfSfZ.WHFgV1D0WbvZZ0qcAf2jDyCluc7se33p 7IftY1SxJBUEyFiZNIEQyEyRLZ9HPKhYfGmNI29zW3tjgyODoGcnfkdse_cnt5LdcTGJb0i3XOZx MZ74PnLDKpa8f8aeJlLipbf61zlZuVHot_alWtI6eQobf_TxdT_W29BxlKnPnSd8pqLUAFRWpiZX MZ9PNMcinhbGvN2DAOgT024LwoozAZV_c4z5D3um69Y2FgvCfYl7761GzXkS2MMF3NXeofXqrr5M ZLxcPCHvj3aVXwmZmGWVnE5SkqcH2WX5mw_lK7PdrcVxCPbMK1Tjc10H8Qu5DThvx.Gm7HUJkAFp XFC8GrOI.w5Q3pRE3BnhOBEmTRq8jf0aSR6TfRAeuIW6UCf9rK1LXVK9Hgv_VuQmE2R9P85mmBTF gVYSZfPLTWBwKkZ5BiFRy0kW150rRUMCHLAv7BBveM Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ir2.yahoo.com with HTTP; Fri, 6 Sep 2019 09:31:28 +0000 Original-Received: by smtp419.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID bafe887027d63ef19e4115c57cda8db3; Fri, 06 Sep 2019 09:31:25 +0000 (UTC) Content-Disposition: inline In-Reply-To: <97f66744-8481-084a-ef23-2c50444e1f05@gmx.at> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.178.145 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239894 Archived-At: On Fri, Sep 06, 2019 at 10:22:48AM +0200, martin rudalics wrote: >Thanks for the new patch. It applies and Emacs builds here on Windows >without problems. > >> The issue is actually related with the fact that >> extend_face_id is never restarted to face_id when going back from an >> extend to a non_extend face between lines (for example when mark is >> active and the iterator crosses the pointer to outside the selected >> region like in the picture). > >The end of the region is a stop position for the iterator. It can >occur in the middle of a line, so handling this problem at the >beginning of a display line would be neither sufficient nor useful. >When the stop position coinciding with the end of the region is >processed, the extend_face_id has to be reset to some new face_id at >that position. > >I'm yet too silly to understand your patch so I cannot figure out >where this should happen. But the following parts appear somehow >suspicious: > > /* Update the faces id and extend. */ > it->face_id = new_face_id; > > if (FACE_EXTENSIBLE_P (new_face)) > it->extend_face_id = new_face_id; > >At the end of the region this may get you a new_face that is not >extensible. But that means that you do not reset it->extend_face_id >although you should (IMHO). > >Just to make sure that we see the same things: Is my interpretation >correct that in your screenshot you use blue for the region and black >as default background and the regions starts at line 9 of your window? > Yes that's it. >martin