From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#36832: Supply option to suppress scrolling in compilation mode buffers. Date: Sun, 25 Aug 2019 10:32:31 +0000 Message-ID: <20190825103231.GA4724@ACM> References: <20190728203221.GD5072@ACM> <83tvb3imgb.fsf@gnu.org> <20190730155937.GD5427@ACM> <83pnlrijiu.fsf@gnu.org> <20190730193235.GE5427@ACM> <83ef26i8si.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="53946"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.10.1 (2018-07-13) Cc: 36832@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 25 12:33:27 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i1ppu-000DwB-Nf for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Aug 2019 12:33:26 +0200 Original-Received: from localhost ([::1]:41720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1ppt-0002Ys-DI for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Aug 2019 06:33:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51118) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1ppX-0002Y9-IK for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 06:33:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i1ppW-00029Q-FS for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 06:33:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34834) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i1ppW-000296-Be for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 06:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i1ppW-0000mf-6n for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 06:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Aug 2019 10:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36832 X-GNU-PR-Package: emacs Original-Received: via spool by 36832-submit@debbugs.gnu.org id=B36832.15667291572983 (code B ref 36832); Sun, 25 Aug 2019 10:33:02 +0000 Original-Received: (at 36832) by debbugs.gnu.org; 25 Aug 2019 10:32:37 +0000 Original-Received: from localhost ([127.0.0.1]:43654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1pp7-0000m2-DU for submit@debbugs.gnu.org; Sun, 25 Aug 2019 06:32:37 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:55341 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1i1pp4-0000lt-Ua for 36832@debbugs.gnu.org; Sun, 25 Aug 2019 06:32:35 -0400 Original-Received: (qmail 31958 invoked by uid 3782); 25 Aug 2019 09:39:46 -0000 Original-Received: from acm.muc.de (p2E5D5A8B.dip0.t-ipconnect.de [46.93.90.139]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 25 Aug 2019 11:39:44 +0200 Original-Received: (qmail 5417 invoked by uid 1000); 25 Aug 2019 10:32:31 -0000 Content-Disposition: inline In-Reply-To: <83ef26i8si.fsf@gnu.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165821 Archived-At: Hello, Eli. On Wed, Jul 31, 2019 at 17:21:49 +0300, Eli Zaretskii wrote: > > Date: Tue, 30 Jul 2019 19:32:35 +0000 > > Cc: 36832@debbugs.gnu.org > > From: Alan Mackenzie > > The current code does two things, sometimes, on being hit: (i) it > > puts an indicator into the fringe; (ii) it scrolls the compile mode > > window upwards, the pertinent line moving either to the top, or to a > > specified window line. > > Unfortunately, the code which does these things seems to be fragmented, > > and there is just one user option to control (i) and (ii) above. > > One solution would be always to mark to the line in the compile mode > > window, whether by an indicator in the fringe or a ">" or "=>" at column > > 0. Then only scroll the compile mode window when the user has explicitly > > requested this by the user option compilation-context-lines. > Yes, that would be an okay solution. I've just committed a patch to master which does the above. When compilation-context-lines has the value t, it no longer scrolls the compilation-mode buffer line to the top of the window, instead using an overlay with before-string property "=>" to mark the current line. This time, the changes are entirely within compile.el. (Plus a documentation change and a NEWS entry.) If there are no objections, I'll close this bug as fixed. -- Alan Mackenzie (Nuremberg, Germany).