all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 36832@debbugs.gnu.org
Subject: bug#36832: Supply option to suppress scrolling in compilation mode buffers.
Date: Sun, 25 Aug 2019 10:32:31 +0000	[thread overview]
Message-ID: <20190825103231.GA4724@ACM> (raw)
In-Reply-To: <83ef26i8si.fsf@gnu.org>

Hello, Eli.

On Wed, Jul 31, 2019 at 17:21:49 +0300, Eli Zaretskii wrote:
> > Date: Tue, 30 Jul 2019 19:32:35 +0000
> > Cc: 36832@debbugs.gnu.org
> > From: Alan Mackenzie <acm@muc.de>

> > The current code does two things, sometimes, on <CR> being hit: (i) it
> > puts an indicator into the fringe; (ii) it scrolls the compile mode
> > window upwards, the pertinent line moving either to the top, or to a
> > specified window line.

> > Unfortunately, the code which does these things seems to be fragmented,
> > and there is just one user option to control (i) and (ii) above.

> > One solution would be always to mark to the line in the compile mode
> > window, whether by an indicator in the fringe or a ">" or "=>" at column
> > 0.  Then only scroll the compile mode window when the user has explicitly
> > requested this by the user option compilation-context-lines.

> Yes, that would be an okay solution.

I've just committed a patch to master which does the above.  When
compilation-context-lines has the value t, it no longer scrolls the
compilation-mode buffer line to the top of the window, instead using an
overlay with before-string property "=>" to mark the current line.

This time, the changes are entirely within compile.el.  (Plus a
documentation change and a NEWS entry.)

If there are no objections, I'll close this bug as fixed.

-- 
Alan Mackenzie (Nuremberg, Germany).





  reply	other threads:[~2019-08-25 10:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-28 20:32 bug#36832: Supply option to suppress scrolling in compilation mode buffers Alan Mackenzie
2019-07-30 15:14 ` Eli Zaretskii
2019-07-30 15:59   ` Alan Mackenzie
2019-07-30 16:17     ` Eli Zaretskii
2019-07-30 19:20       ` Juri Linkov
2019-07-31 14:20         ` Eli Zaretskii
2019-07-30 19:32       ` Alan Mackenzie
2019-07-31 14:21         ` Eli Zaretskii
2019-08-25 10:32           ` Alan Mackenzie [this message]
2019-09-01 21:50 ` Mattias Engdegård
     [not found] ` <handler.36832.B.156434595120203.ack@debbugs.gnu.org>
2019-09-03 17:44   ` Alan Mackenzie
2019-09-04 12:41 ` Mattias Engdegård
2019-09-05 17:50   ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190825103231.GA4724@ACM \
    --to=acm@muc.de \
    --cc=36832@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.