From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.bugs Subject: bug#36858: 27.0.50; display bugs with display-fill-column-indicator-mode Date: Wed, 7 Aug 2019 21:46:21 +0200 Message-ID: <20190807194621.6ankodv7hclbvmdz@Ergus> References: <83wofwexkr.fsf@gnu.org> <20190805152747.4vyzejqoiy33l4ou@Ergus> <83tvatavmh.fsf@gnu.org> <20190807162033.hpphf2pbfo4p6vam@Ergus> <83h86taq4v.fsf@gnu.org> <20190807170654.b6wsccs3b2acduff@Ergus> <83ef1wc2ae.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="202041"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: 36858@debbugs.gnu.org, rotim.davor@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 07 21:47:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hvRu2-000qSl-0G for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Aug 2019 21:47:18 +0200 Original-Received: from localhost ([::1]:44742 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvRu0-0002lw-OS for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Aug 2019 15:47:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53423) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvRtp-0002jN-HB for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2019 15:47:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvRtn-0008SZ-4a for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2019 15:47:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58868) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hvRtm-0008QP-Ir for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2019 15:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hvRtm-0001os-Dc for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2019 15:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ergus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Aug 2019 19:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36858 X-GNU-PR-Package: emacs Original-Received: via spool by 36858-submit@debbugs.gnu.org id=B36858.15652071986941 (code B ref 36858); Wed, 07 Aug 2019 19:47:02 +0000 Original-Received: (at 36858) by debbugs.gnu.org; 7 Aug 2019 19:46:38 +0000 Original-Received: from localhost ([127.0.0.1]:39456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hvRtO-0001ns-Bv for submit@debbugs.gnu.org; Wed, 07 Aug 2019 15:46:38 -0400 Original-Received: from sonic313-21.consmr.mail.ir2.yahoo.com ([77.238.179.188]:36880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hvRtM-0001nd-FK for 36858@debbugs.gnu.org; Wed, 07 Aug 2019 15:46:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1565207189; bh=lC4vFUZND9sfq8WMly83IlaKcIk8jsbW5/MEFfd4W70=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=LDCCQtLpf0xjmrc05E1PrQfyM3l+zRyX5PkVUCF/wCiOyIKwBZmlOgVdRuugTvtK+ef10ScJ4R/Qz2X0xmeoXB4bz/1gxnQ4f23jKeR4Dd9NBX0zJm9PDdeR9qYTNU3qzvbrfuwsnp9MGV4lfdpspvzVuaU78lxcl7pCqqvyGDjTl/B7pmHJKevSZyNFCMRLox5Qr6ZuEG95fxTUo+BTeBVG7F/c2CdttAVVYVNtprWfY++ImNMwCvLxrAA3uvdXHkW+j9PLQ/xToijF1q04TWUOZz5UwTrAQnnMMwZqfQKBcdjS+35SIwg9VjBAqFvhLUxl0zYdT4Je4/oTXnfTgw== X-YMail-OSG: aW2aA7MVM1m4JdF2XBmBZEjcDNXoaIsVnvwFc9ajW3ecjd3QmRG_x7o.IGb3fb4 0KqrrHFjeyMvh4qBlYjoI40PrMWxO8LckapNoJ4Oa2H1RSyRttRCSLfmquzO2_iSLlmuWU65r4eh WBIck2_lRJwtDHIM8ZThY.3ewlM_XkVYLMln44Q8Vn2jO9fWy0zOcLkzhuneJu8r_0fdFaOlf2KL RjySbT7Il7_P82ORDnAUCzGAwV.OKphWTEMk5hghr5qdht.SHJ6H8FrBJFX72aATQmwoLDiAZIvp 9vS7ehjL9BJyFMzgCsuAQ0.YvxiIVscTTl965p_CJD6FqybZL1bEoQjSeXjPy5vvxGiFxT0vgEW6 QzmA4qgX7NS6JTTO5sqwXx_lmoRoSmpwkAXivLFOgk9NRY7cUu.XdtlmVDIUYNisyHL3HdWQ6Hsq AoxGhsXJP9h9e3dAoBk2Cnmzpw9C9KyPLtGa7RpDZhF9jg1baiN8zgBIVEnAh.l6z3SVnEED745E 0yn7_K03Cc3IV5bBrxNqHyg7aLa56jjuGOj03ktlf.kMTDH7DWGoUPqxbLJ6yJnN5tVVMZ5u6nTY Y32V6ovx__KUWjnaKykJU8B_VltsIu80sq4BFCsfM2YFNOIjlRZXXDaAQOkditARzSPriN9QCiSh s3dfst2CVeB568kZZYa4ec2HHqnZilsmnMn3ydNvr.q0Hvu.9NuhGNldWD0rZMsurZ8QDjS0svPr rRmTEf4jE9kh7dryJkpMmmB7zo5kwZ4ZMJg4xbHUveQa2QJBSEtqg4xzYgJxjFAa7Oe.yRnsOAix 6Mt3QcWoFjU5KSeXIE21lPwe_Um9PoqruNTGg8Gsa9 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ir2.yahoo.com with HTTP; Wed, 7 Aug 2019 19:46:29 +0000 Original-Received: by smtp416.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 5440ac17a1c0f57cd52171d272f30e95; Wed, 07 Aug 2019 19:46:25 +0000 (UTC) Content-Disposition: inline In-Reply-To: <83ef1wc2ae.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164732 Archived-At: On Wed, Aug 07, 2019 at 08:29:13PM +0300, Eli Zaretskii wrote: >> This issue is already fixed with the other condition I mentioned: >> >> IT_CHARPOS (*it) < ZV >> >> But ends_at_zv_p this also need to be fixed because there are some tests >> inside extend_face_to_end_of_line that compare with ends_at_zv_p. In the >> worst case we need to remove these comparisons. > >Not sure I understand why the comparisons need to be removed. Can you >elaborate? > >> But ideally the flag must be set before right? > >In a buffer showing only buffer text (no after-strings at EOB), all >the glyph rows starting from the one showing EOB have their >ends_at_zv_p flag set. Hi: In my tests inside extend_face_to_end_of_line the flag ends_at_zv_p is always false. And for the last line (where it is supposed to be true) the function extend_face_to_end_of_line is not called at all. So actually all the code like: if (it->glyph_row->ends_at_zv_p) it->face_id = default_face->id; else it->face_id = face->id; does nothing now. We should fix this in order to create an indicator also for the last line. I think that the problem is in the condition: if (!get_next_display_element (it)) inside display_line that filters the call to extend_face_to_end_of_line with: if (row->reversed_p || lookup_basic_face (it->w, it->f, DEFAULT_FACE_ID) != DEFAULT_FACE_ID) extend_face_to_end_of_line (it); And needs to be extended probably with with: || (!row_text_area_empty (row))